* [dpdk-dev] [PATCH] app/testpmd: fix dead code
@ 2015-12-15 15:42 Jingjing Wu
2015-12-15 15:50 ` Mcnamara, John
0 siblings, 1 reply; 3+ messages in thread
From: Jingjing Wu @ 2015-12-15 15:42 UTC (permalink / raw)
To: dev
Coverity issue (CID 119254): Control flow issues (DEADCODE).
Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic class")
Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
app/test-pmd/config.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index e2030b0..7088f6f 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1251,10 +1251,7 @@ dcb_fwd_config_setup(void)
/* reinitialize forwarding streams */
init_fwd_streams();
sm_id = 0;
- if ((rxp & 0x1) == 0)
- txp = (portid_t) (rxp + 1);
- else
- txp = (portid_t) (rxp - 1);
+ txp = 1;
/* get the dcb info on the first RX and TX ports */
(void)rte_eth_dev_get_dcb_info(fwd_ports_ids[rxp], &rxp_dcb_info);
(void)rte_eth_dev_get_dcb_info(fwd_ports_ids[txp], &txp_dcb_info);
--
2.4.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix dead code
2015-12-15 15:42 [dpdk-dev] [PATCH] app/testpmd: fix dead code Jingjing Wu
@ 2015-12-15 15:50 ` Mcnamara, John
2015-12-15 17:08 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Mcnamara, John @ 2015-12-15 15:50 UTC (permalink / raw)
To: Wu, Jingjing, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jingjing Wu
> Sent: Tuesday, December 15, 2015 3:43 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix dead code
>
> Coverity issue (CID 119254): Control flow issues (DEADCODE).
>
> Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic
> class")
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix dead code
2015-12-15 15:50 ` Mcnamara, John
@ 2015-12-15 17:08 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-12-15 17:08 UTC (permalink / raw)
To: Wu, Jingjing; +Cc: dev
> > Coverity issue (CID 119254): Control flow issues (DEADCODE).
> >
> > Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic
> > class")
> > Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-15 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-15 15:42 [dpdk-dev] [PATCH] app/testpmd: fix dead code Jingjing Wu
2015-12-15 15:50 ` Mcnamara, John
2015-12-15 17:08 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).