* [dpdk-dev] [PATCH] mempool/stack: build on Windows
@ 2021-09-30 23:44 Jie Zhou
2021-10-01 0:50 ` [dpdk-dev] [PATCH v2] " Jie Zhou
0 siblings, 1 reply; 5+ messages in thread
From: Jie Zhou @ 2021-09-30 23:44 UTC (permalink / raw)
To: dev
Cc: pallavi.kadam, dmitry.kozliuk, roretzla, navasile, dmitrym,
talshn, thomas
Enable the build of mempool/stack on Windows
Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
drivers/mempool/stack/meson.build | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build
index 371cf131b1..580dde79eb 100644
--- a/drivers/mempool/stack/meson.build
+++ b/drivers/mempool/stack/meson.build
@@ -1,11 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation
-if is_windows
- build = false
- reason = 'not supported on Windows'
-endif
-
sources = files('rte_mempool_stack.c')
deps += ['stack']
--
2.31.0.vfs.0.1
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH v2] mempool/stack: build on Windows
2021-09-30 23:44 [dpdk-dev] [PATCH] mempool/stack: build on Windows Jie Zhou
@ 2021-10-01 0:50 ` Jie Zhou
2021-10-01 7:42 ` Dmitry Kozlyuk
0 siblings, 1 reply; 5+ messages in thread
From: Jie Zhou @ 2021-10-01 0:50 UTC (permalink / raw)
To: dev
Cc: pallavi.kadam, dmitry.kozliuk, roretzla, navasile, dmitrym,
talshn, thomas
enable build mempool/stack on Windows
----
V2 change:
- enable build lib stack on Windows which mempool/stack depends on
Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
---
drivers/mempool/stack/meson.build | 5 -----
lib/meson.build | 1 +
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/mempool/stack/meson.build b/drivers/mempool/stack/meson.build
index 371cf131b1..580dde79eb 100644
--- a/drivers/mempool/stack/meson.build
+++ b/drivers/mempool/stack/meson.build
@@ -1,11 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2017-2019 Intel Corporation
-if is_windows
- build = false
- reason = 'not supported on Windows'
-endif
-
sources = files('rte_mempool_stack.c')
deps += ['stack']
diff --git a/lib/meson.build b/lib/meson.build
index 1673ca4323..9c4841fe40 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -85,6 +85,7 @@ if is_windows
'gso',
'latencystats',
'pdump',
+ 'stack',
] # only supported libraries for windows
endif
--
2.31.0.vfs.0.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2] mempool/stack: build on Windows
2021-10-01 0:50 ` [dpdk-dev] [PATCH v2] " Jie Zhou
@ 2021-10-01 7:42 ` Dmitry Kozlyuk
2021-10-01 14:44 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Dmitry Kozlyuk @ 2021-10-01 7:42 UTC (permalink / raw)
To: Jie Zhou; +Cc: dev, pallavi.kadam, roretzla, navasile, dmitrym, talshn, thomas
2021-09-30 17:50 (UTC-0700), Jie Zhou:
> enable build mempool/stack on Windows
Nit: in commit body, we use correct capitalization, punctuation, and spelling.
> ----
> V2 change:
> - enable build lib stack on Windows which mempool/stack depends on
>
>
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] mempool/stack: build on Windows
2021-10-01 7:42 ` Dmitry Kozlyuk
@ 2021-10-01 14:44 ` Thomas Monjalon
2021-10-01 14:52 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2021-10-01 14:44 UTC (permalink / raw)
To: Jie Zhou
Cc: dev, pallavi.kadam, roretzla, navasile, dmitrym, talshn, Dmitry Kozlyuk
01/10/2021 09:42, Dmitry Kozlyuk:
> 2021-09-30 17:50 (UTC-0700), Jie Zhou:
> > enable build mempool/stack on Windows
>
> Nit: in commit body, we use correct capitalization, punctuation, and spelling.
>
> > ----
> > V2 change:
> > - enable build lib stack on Windows which mempool/stack depends on
> >
> >
> > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
>
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] mempool/stack: build on Windows
2021-10-01 14:44 ` Thomas Monjalon
@ 2021-10-01 14:52 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2021-10-01 14:52 UTC (permalink / raw)
To: Jie Zhou
Cc: dev, pallavi.kadam, roretzla, navasile, dmitrym, talshn, Dmitry Kozlyuk
01/10/2021 16:44, Thomas Monjalon:
> 01/10/2021 09:42, Dmitry Kozlyuk:
> > 2021-09-30 17:50 (UTC-0700), Jie Zhou:
> > > enable build mempool/stack on Windows
> >
> > Nit: in commit body, we use correct capitalization, punctuation, and spelling.
> >
> > > ----
> > > V2 change:
> > > - enable build lib stack on Windows which mempool/stack depends on
> > >
> > >
> > > Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> >
> > Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
>
> Applied, thanks.
Note: I had to add #include <sys/queue.h> because of a recent commit.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-01 14:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-30 23:44 [dpdk-dev] [PATCH] mempool/stack: build on Windows Jie Zhou
2021-10-01 0:50 ` [dpdk-dev] [PATCH v2] " Jie Zhou
2021-10-01 7:42 ` Dmitry Kozlyuk
2021-10-01 14:44 ` Thomas Monjalon
2021-10-01 14:52 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).