From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f178.google.com (mail-we0-f178.google.com
 [74.125.82.178]) by dpdk.org (Postfix) with ESMTP id C99905934
 for <dev@dpdk.org>; Fri, 23 May 2014 18:10:43 +0200 (CEST)
Received: by mail-we0-f178.google.com with SMTP id u56so5021968wes.37
 for <dev@dpdk.org>; Fri, 23 May 2014 09:10:53 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=kgXfyyjdXm0cPxwTW4AV0CE2LgEnOT5KYD6fyL7yXAs=;
 b=DJLqtfNQdihC89pmoSES3JYnK/LNq++indOYXlqFRslTCe4C/OvRApMkRE8vx/LFDn
 uxQjE/0EPtuA9j44xuWGKCW1vseWEEUw3nYIqS23Mw6uj+pqIdGQXSliiO9s86y4EKMP
 k7N1b8sJPE7J+7MJcc/wI8U/8PtyEhBHj9kWamBpdFcp6cEKC16S13oAhzHz3C4HhSvg
 zUlEKPJLqRNhwSVN9HhpLD//oIs75xcgcdntk8E4Vus4rvzJ3mSeSHWPgKX4InAyRIvh
 yKMA/igW0W4q8TDuVMPCbcetjg1pazC3cVNvkUrpMk/Cq4aZOpTprvW1WDOUrq0s5j7t
 p8GQ==
X-Gm-Message-State: ALoCoQkRtzS9PWuFhV3BysW0Djec+Bn8vo6hUiSh8obEknea6iYQ5KoAV4NPdYpZk7/sdFTVWc9J
X-Received: by 10.194.84.101 with SMTP id x5mr5263194wjy.52.1400861453056;
 Fri, 23 May 2014 09:10:53 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id vc2sm4429377wjc.2.2014.05.23.09.10.51
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 23 May 2014 09:10:52 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Date: Fri, 23 May 2014 18:10:49 +0200
Message-ID: <1633454.Txn6nOcm6F@xps13>
Organization: 6WIND
User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; )
In-Reply-To: <1400855964-20482-1-git-send-email-bruce.richardson@intel.com>
References: <1400855964-20482-1-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix misnamed variable in rte.app.mk
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 23 May 2014 16:10:44 -0000

2014-05-23 15:39, Bruce Richardson:
> The variable CONFIG_RTE_BUILD_SHARED_LIB was in rte.app.mk as
> "RTE_BUILD_SHARED_LIB", which meant that none of the example apps linked
> in the PMDs and just didn't work with any eth ports in any static builds
> 
> Link for l2fwd before patch:
>   "... -Wl,--whole-archive -Wl,-lrte_kni -Wl,-lrte_timer -Wl,-lrte_hash
> -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm
> -Wl,-lrt -Wl,--start-group -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lethdev
> -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal
> -Wl,-lrte_cmdline -Wl,-lrt -Wl,-lm -Wl,-ldl -Wl,--end-group
> -Wl,--no-whole-archive"
> 
> Link for l2fwd after patch:
>   "...  -Wl,--whole-archive -Wl,-lrte_kni -Wl,-lrte_timer -Wl,-lrte_hash
> -Wl,-lrte_lpm -Wl,-lrte_power -Wl,-lrte_meter -Wl,-lrte_sched -Wl,-lm
> -Wl,-lrt -Wl,--start-group -Wl,-lrte_kvargs -Wl,-lrte_mbuf -Wl,-lethdev
> -Wl,-lrte_malloc -Wl,-lrte_mempool -Wl,-lrte_ring -Wl,-lrte_eal
> -Wl,-lrte_cmdline -Wl,-lrte_pmd_vmxnet3_uio -Wl,-lrte_pmd_virtio_uio
> -Wl,-lrte_pmd_ixgbe -Wl,-lrte_pmd_e1000 -Wl,-lrte_pmd_ring -Wl,-lrt
> -Wl,-lm -Wl,-ldl -Wl,--end-group -Wl,--no-whole-archive"
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

This bug has been introduced in commit 3660cdf990:
	pcap: convert to use of PMD_REGISTER_DRIVER and fix linking
Note: bug fixes should include reference to root cause in the log.

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Applied with this title:
	mk: fix linking drivers in static apps

-- 
Thomas