From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0FA6A29AC for ; Fri, 21 Jul 2017 08:01:09 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7B7F220A7C; Fri, 21 Jul 2017 02:01:09 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 21 Jul 2017 02:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=8fpb9t6/8lPi1z9 WzfY18mtWRLJ2hey7EKgJRPVr3F8=; b=mTkkAkpbDMrJHmbvS4y9iw0wX6Da/uP 1t4BDoIngp6cCBIsUaBwpiLRj9FBQ65561IBP75FD96hwAXYZBPegW1e6RFo64hW e7qEq0BsbwHlJuH6TPE8bEHMnX6unC7SmcydV+/7DFD5zW2c4M8nKjbZW0PzJ7b2 GgsFpija3czs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=8fpb9t6/8lPi1z9WzfY18mtWRLJ2hey7EKgJRPVr3F8=; b=CzjPbMP1 Ef899h0fSRHVozvoTRqGYLq9/dTIkqsg9X7e5E48w3xRNmZ0d0VpuwOb4VYqGWHF 59Cyk6rHUQUWESjf08msaw9v7rLZM5Wxx8G58iUnhdPSVEDS/p96+8Ji4iCjhfiL 9rz7y0S1kCR79/CLpePKAjrSJVe2F49lNJKG4yS8yQHdmOa2X9HNcatcTLUxOKbC q+augfpR3lfKHRSCzSCV/Jjwzh8YdjJlum9bWMo/zkeAHDSl1XoermbaSf7GHrMc jy8SL7NE08UgzN/I10MbFUckAotlqXqFXGxpCSwnYNZz6QBXj4pNVBOCDLgFR/Tp EEZvcp5EIWGuXA== X-ME-Sender: X-Sasl-enc: a0KjgOvIhlDN2e7qd/jEbp3yfGHiaLKeglg7/5menb5A 1500616868 Received: from xps.localnet (unknown [37.169.141.147]) by mail.messagingengine.com (Postfix) with ESMTPA id CFF907E1FC; Fri, 21 Jul 2017 02:01:08 -0400 (EDT) From: Thomas Monjalon To: Hemant Agrawal Cc: dev@dpdk.org Date: Fri, 21 Jul 2017 09:01:05 +0300 Message-ID: <16337430.qy0lxGFHke@xps> In-Reply-To: <1499941699-19478-1-git-send-email-hemant.agrawal@nxp.com> References: <1499941699-19478-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: disable NUMA related warnings on non-NUMA systems X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jul 2017 06:01:10 -0000 13/07/2017 13:28, Hemant Agrawal: > Disabling NUMA warnings on non-NUMA systems. > > "EAL: eal_parse_sysfs_value(): cannot open sysfs value > /sys/bus/pci/devices/0000:00:00.0/numa_node > EAL: numa_node is invalid or not present. Set it 0 as default > EAL: cannot open /proc/self/numa_maps, consider that all memory is > in socket_id 0" > > Signed-off-by: Hemant Agrawal If I understand well, you are disabling every warnings when DPDK is compiled without libnuma. I think we should keep one warning in case libnuma is not available but it is running on a NUMA system. What about adding this kind of sysfs check? #ifndef RTE_EAL_NUMA_AWARE_HUGEPAGES if (sysfs/numa_node is present) RTE_LOG(WARN, "Only the first NUMA node will be used\n"); #endif