From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id E8D41108A for ; Mon, 6 Mar 2017 11:17:56 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id v186so59727440wmd.0 for ; Mon, 06 Mar 2017 02:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=KlASae6YqDMQS/FYceZLH0BsPPNe3Kk0trEVM/woBP4=; b=mPnrd13QlGeediFjlTpR6l0h2JglUBnpHE6sA8NMwI2inaAuXjFmqmN7/W6FgV80iY 2Gn4a+ymcXxn/aLj2dEV6Ul/68ZE4KRdRRh43ULfZqwmpyxH3NtuSSatzdmg9DNZfgrb IeP8XgRH2cfePmh1YALUNBVz7GmFxhU01if6+ac8K5GvNABkLt9dTOkDtEpZ9GPdhSAv XK1fwYc/qgIJJrHbfT01jUb8rWt/P+WSdDpR2+uu9JCVwRQj4xJ1/OzAMd9ZXLWzE2Bc WCIckTEN3glKWWrBtLtHKguoUdKrw2+rdhoidbD/xv4z/b52OKlVXjrRAs5UmrjH6Oj5 xDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=KlASae6YqDMQS/FYceZLH0BsPPNe3Kk0trEVM/woBP4=; b=pJ0xPB8GRTr6CpXs8JVDA5cTGYhUXffCDl+a9qVC6rbkyZ6RQQnTq80TeQlBR0TPys d1r5CX0ei1Hb1CNhtBB4+coTDvNGh3zhzfMO3xKyLnM9cjMNuFSdrjRK4927TVZ9FeTB nsnzLqwRiI4DTCcXWF/k1XfaKkqXxRUk5SOtPKDoT7zEtaw/zvs+Iv/mCxQiPnCrkXgT siH4RzL160BolYFOtPUHRkiEy8xItMnlXu+WEGR0y2dNksjtJHi32Rlt5Xb7nzS437ya bsIZQw+4+5kSN8MjNPqEwqqcJhRCRJ54Q7GR7R8ev13CrtlgE2+z0upzqrHqGbv15wb/ D6ww== X-Gm-Message-State: AMke39lBTQHXtauTqnc6xorDoudhgqvccihtNATGDpXokVn/40faBtMjcBlF0eTcutIA/8hF X-Received: by 10.28.220.65 with SMTP id t62mr2959404wmg.85.1488795476650; Mon, 06 Mar 2017 02:17:56 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 40sm26363267wry.22.2017.03.06.02.17.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Mar 2017 02:17:56 -0800 (PST) From: Thomas Monjalon To: Kuba Kozak , Jacek Piasecki Cc: dev@dpdk.org Date: Mon, 06 Mar 2017 11:17:54 +0100 Message-ID: <1634037.UG6F3tOjLg@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1488545672-5208-2-git-send-email-kubax.kozak@intel.com> References: <1488545672-5208-1-git-send-email-kubax.kozak@intel.com> <1488545672-5208-2-git-send-email-kubax.kozak@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add retrieving xstats by group and xstats by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 10:17:57 -0000 Hi, 2017-03-03 13:54, Kuba Kozak: > From: Jacek Piasecki > > This patch extends library for retriving xstats by specified groups and > single xstat by given name. > > Signed-off-by: Jacek Piasecki > Signed-off-by: Kuba Kozak As you probably know, it is difficult to have a good review (or a simple review at all). The most difficult part in such a change is not writing the code, it is explaining your idea and getting people to agree. Please show you have thought about the API, seen an issue or a lack, and propose an idea with a clear target. In short, we are missing a "why" and "how". You must also explain what is a group, better than a list of #define.