* [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API
@ 2018-02-27 13:11 Andrew Rybchenko
2018-02-27 13:11 ` [dpdk-dev] [PATCH 1/3] net/sfc/base: support drop filters on EF10 family NICs Andrew Rybchenko
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2018-02-27 13:11 UTC (permalink / raw)
To: dev
Update base driver and the PMD itself to support drop action in flow API.
It should be applied on top of [1].
[1] http://dpdk.org/ml/archives/dev/2018-February/091530.html
Andrew Rybchenko (1):
doc: add flow API drop action support to net/sfc
Roman Zhukov (2):
net/sfc/base: support drop filters on EF10 family NICs
net/sfc: support DROP action in flow API
doc/guides/nics/sfc_efx.rst | 2 ++
doc/guides/rel_notes/release_18_05.rst | 1 +
drivers/net/sfc/base/ef10_filter.c | 13 +++++++++----
drivers/net/sfc/sfc_flow.c | 7 +++++++
4 files changed, 19 insertions(+), 4 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH 1/3] net/sfc/base: support drop filters on EF10 family NICs
2018-02-27 13:11 [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API Andrew Rybchenko
@ 2018-02-27 13:11 ` Andrew Rybchenko
2018-02-27 13:11 ` [dpdk-dev] [PATCH 2/3] net/sfc: support DROP action in flow API Andrew Rybchenko
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2018-02-27 13:11 UTC (permalink / raw)
To: dev; +Cc: Roman Zhukov
From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Add support for filters which drop packets when forming MCDI request
for a filter.
Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/ef10_filter.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/drivers/net/sfc/base/ef10_filter.c b/drivers/net/sfc/base/ef10_filter.c
index 54e1c35..54ea9e3 100644
--- a/drivers/net/sfc/base/ef10_filter.c
+++ b/drivers/net/sfc/base/ef10_filter.c
@@ -209,10 +209,15 @@ efx_mcdi_filter_op_add(
EVB_PORT_ID_ASSIGNED);
MCDI_IN_SET_DWORD(req, FILTER_OP_EXT_IN_MATCH_FIELDS,
match_flags);
- MCDI_IN_SET_DWORD(req, FILTER_OP_EXT_IN_RX_DEST,
- MC_CMD_FILTER_OP_EXT_IN_RX_DEST_HOST);
- MCDI_IN_SET_DWORD(req, FILTER_OP_EXT_IN_RX_QUEUE,
- spec->efs_dmaq_id);
+ if (spec->efs_dmaq_id == EFX_FILTER_SPEC_RX_DMAQ_ID_DROP) {
+ MCDI_IN_SET_DWORD(req, FILTER_OP_EXT_IN_RX_DEST,
+ MC_CMD_FILTER_OP_EXT_IN_RX_DEST_DROP);
+ } else {
+ MCDI_IN_SET_DWORD(req, FILTER_OP_EXT_IN_RX_DEST,
+ MC_CMD_FILTER_OP_EXT_IN_RX_DEST_HOST);
+ MCDI_IN_SET_DWORD(req, FILTER_OP_EXT_IN_RX_QUEUE,
+ spec->efs_dmaq_id);
+ }
#if EFSYS_OPT_RX_SCALE
if (spec->efs_flags & EFX_FILTER_FLAG_RX_RSS) {
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH 2/3] net/sfc: support DROP action in flow API
2018-02-27 13:11 [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API Andrew Rybchenko
2018-02-27 13:11 ` [dpdk-dev] [PATCH 1/3] net/sfc/base: support drop filters on EF10 family NICs Andrew Rybchenko
@ 2018-02-27 13:11 ` Andrew Rybchenko
2018-02-27 13:11 ` [dpdk-dev] [PATCH 3/3] doc: add flow API drop action support to net/sfc Andrew Rybchenko
2018-03-09 10:52 ` [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API Ferruh Yigit
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2018-02-27 13:11 UTC (permalink / raw)
To: dev; +Cc: Roman Zhukov
From: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Signed-off-by: Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
doc/guides/nics/sfc_efx.rst | 2 ++
drivers/net/sfc/sfc_flow.c | 7 +++++++
2 files changed, 9 insertions(+)
diff --git a/doc/guides/nics/sfc_efx.rst b/doc/guides/nics/sfc_efx.rst
index f41ccdb..36e98d3 100644
--- a/doc/guides/nics/sfc_efx.rst
+++ b/doc/guides/nics/sfc_efx.rst
@@ -183,6 +183,8 @@ Supported actions:
- RSS
+- DROP
+
Validating flow rules depends on the firmware variant.
Ethernet destinaton individual/group match
diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c
index 2b8bef8..4fe20a2 100644
--- a/drivers/net/sfc/sfc_flow.c
+++ b/drivers/net/sfc/sfc_flow.c
@@ -1497,6 +1497,13 @@ sfc_flow_parse_actions(struct sfc_adapter *sa,
break;
#endif /* EFSYS_OPT_RX_SCALE */
+ case RTE_FLOW_ACTION_TYPE_DROP:
+ flow->spec.template.efs_dmaq_id =
+ EFX_FILTER_SPEC_RX_DMAQ_ID_DROP;
+
+ is_specified = B_TRUE;
+ break;
+
default:
rte_flow_error_set(error, ENOTSUP,
RTE_FLOW_ERROR_TYPE_ACTION, actions,
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH 3/3] doc: add flow API drop action support to net/sfc
2018-02-27 13:11 [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API Andrew Rybchenko
2018-02-27 13:11 ` [dpdk-dev] [PATCH 1/3] net/sfc/base: support drop filters on EF10 family NICs Andrew Rybchenko
2018-02-27 13:11 ` [dpdk-dev] [PATCH 2/3] net/sfc: support DROP action in flow API Andrew Rybchenko
@ 2018-02-27 13:11 ` Andrew Rybchenko
2018-03-09 10:52 ` [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API Ferruh Yigit
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Rybchenko @ 2018-02-27 13:11 UTC (permalink / raw)
To: dev
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
doc/guides/rel_notes/release_18_05.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst
index 894f636..d162daf 100644
--- a/doc/guides/rel_notes/release_18_05.rst
+++ b/doc/guides/rel_notes/release_18_05.rst
@@ -46,6 +46,7 @@ New Features
Updated the sfc_efx driver including the following changes:
* Added support for NVGRE, VXLAN and GENEVE filters in flow API.
+ * Added support for DROP action in flow API.
API Changes
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API
2018-02-27 13:11 [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API Andrew Rybchenko
` (2 preceding siblings ...)
2018-02-27 13:11 ` [dpdk-dev] [PATCH 3/3] doc: add flow API drop action support to net/sfc Andrew Rybchenko
@ 2018-03-09 10:52 ` Ferruh Yigit
3 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2018-03-09 10:52 UTC (permalink / raw)
To: Andrew Rybchenko, dev
On 2/27/2018 1:11 PM, Andrew Rybchenko wrote:
> Update base driver and the PMD itself to support drop action in flow API.
>
> It should be applied on top of [1].
>
> [1] http://dpdk.org/ml/archives/dev/2018-February/091530.html
>
> Andrew Rybchenko (1):
> doc: add flow API drop action support to net/sfc
>
> Roman Zhukov (2):
> net/sfc/base: support drop filters on EF10 family NICs
> net/sfc: support DROP action in flow API
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-09 10:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-27 13:11 [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API Andrew Rybchenko
2018-02-27 13:11 ` [dpdk-dev] [PATCH 1/3] net/sfc/base: support drop filters on EF10 family NICs Andrew Rybchenko
2018-02-27 13:11 ` [dpdk-dev] [PATCH 2/3] net/sfc: support DROP action in flow API Andrew Rybchenko
2018-02-27 13:11 ` [dpdk-dev] [PATCH 3/3] doc: add flow API drop action support to net/sfc Andrew Rybchenko
2018-03-09 10:52 ` [dpdk-dev] [PATCH 00/3] net/sfc: support drop action in flow API Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).