From: "Min Hu (Connor)" <humin29@huawei.com> To: Stephen Hemminger <stephen@networkplumber.org>, Ferruh Yigit <ferruh.yigit@intel.com> Cc: <dev@dpdk.org>, <bruce.richardson@intel.com>, <thomas.monjalon@6wind.com>, <lihuisong@huawei.com> Subject: Re: [dpdk-dev] [RFC V4] app/testpmd: fix queue stats mapping configuration Date: Mon, 23 Nov 2020 15:22:36 +0800 Message-ID: <16360f53-28b3-d702-72c0-5523198f583f@huawei.com> (raw) In-Reply-To: <20201120202928.126217ad@hermes.local> 在 2020/11/21 12:29, Stephen Hemminger 写道: > On Fri, 20 Nov 2020 23:33:40 +0000 > Ferruh Yigit <ferruh.yigit@intel.com> wrote: > >> On 11/20/2020 11:21 PM, Stephen Hemminger wrote: >>> On Fri, 20 Nov 2020 17:26:55 +0000 >>> Ferruh Yigit <ferruh.yigit@intel.com> wrote: >>> >>>> On 11/20/2020 11:50 AM, Min Hu (Connor) wrote: >>>>> From: Huisong Li <lihuisong@huawei.com> >>>>> >>>>> Currently, the queue stats mapping has the following problems: >>>>> 1) Many PMD drivers don't support queue stats mapping. But there is no >>>>> failure message after executing the command "set stat_qmap rx 0 2 2". >>>>> 2) Once queue mapping is set, unrelated and unmapped queues are also >>>>> displayed. >>>>> 3) The configuration result does not take effect or can not be queried >>>>> in real time. >>>>> 4) The mapping arrays, "tx_queue_stats_mappings_array" & >>>>> "rx_queue_stats_mappings_array" are global and their sizes are based on >>>>> fixed max port and queue size assumptions. >>>>> 5) These record structures, 'map_port_queue_stats_mapping_registers()' >>>>> and its sub functions are redundant for majority of drivers. >>>>> 6) The display of the queue stats and queue stats mapping is mixed >>>>> together. >>>>> >>>>> Since xstats is used to obtain queue statistics, we have made the following >>>>> simplifications and adjustments: >>>>> 1) If PMD requires and supports queue stats mapping, configure to driver in >>>>> real time by calling ethdev API after executing the command >>>>> "set stat_qmap rx/tx ...". If not, the command can not be accepted. >>>>> 2) Based on the above adjustments, these record structures, >>>>> 'map_port_queue_stats_mapping_registers()' and its sub functions can be >>>>> removed. "tx-queue-stats-mapping" & "rx-queue-stats-mapping" parameters, >>>>> and 'parse_queue_stats_mapping_config()' can be removed too. >>>>> 3) remove display of queue stats mapping in 'fwd_stats_display()' & >>>>> 'nic_stats_display()', and obtain queue stats by xstats. >>>>> Since the record structures are removed, 'nic_stats_mapping_display()' >>>>> can be deleted. >>>>> >>>>> Fixes: 4dccdc789bf4b ("app/testpmd: simplify handling of stats mappings error") >>>>> Fixes: 013af9b6b64f6 ("app/testpmd: various updates") >>>>> Fixes: ed30d9b691b21 ("app/testpmd: add stats per queue") >>>>> >>>>> Signed-off-by: Huisong Li <lihuisong@huawei.com> >>>> >>>> Overall looks good to me. >>>> I did a quick test didn't see anything unexpected. 'xstats' or 'dpdk-proc-info' >>>> app still can be used to get queue stats and "set stat_qmap ..." is working as >>>> expected. >>>> >>>> But it is a little late for this release cycle, would you be OK to get this at >>>> the beginning of next release? >>> >>> Could we plan to deprecate queue stats mapping in future when xstats work is done? >>> >> >> Even queue stats moved to xstats, a few PMDs still need this configuration and API. >> And this patch already cleans the queue stats mapping noise from testpmd. >> >> What is the benefit/motivation to deprecate the queue stats mapping API? > > Mostly because so few drivers implement it, that any application using it > is going to be non-portable. > Hi, Stephen, For PMDs with few hardware queue statistics resources, such as ixgbe, all queue stats are recorded in statistics register 0 by default. If users want to get detailed queue stats, users have to call the queue stats mapping API. From this point of view, it is necessary for these PMDs. >
next prev parent reply other threads:[~2020-11-23 7:22 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-20 8:26 [dpdk-dev] [RFC V2 0/2] fix queue stats mapping Min Hu (Connor) 2020-10-20 8:26 ` [dpdk-dev] [RFC V2 1/2] app/testpmd: fix queue stats mapping configuration Min Hu (Connor) 2020-10-30 20:54 ` Ferruh Yigit 2020-11-03 6:30 ` Min Hu (Connor) 2020-11-12 2:28 ` Min Hu (Connor) 2020-11-12 9:52 ` Ferruh Yigit 2020-11-18 3:39 ` Min Hu (Connor) 2020-11-20 11:50 ` [dpdk-dev] [RFC V4] " Min Hu (Connor) 2020-11-20 17:26 ` Ferruh Yigit 2020-11-20 23:21 ` Stephen Hemminger 2020-11-20 23:33 ` Ferruh Yigit 2020-11-21 4:29 ` Stephen Hemminger 2020-11-23 7:22 ` Min Hu (Connor) [this message] 2020-11-23 9:51 ` Ferruh Yigit 2020-11-30 8:29 ` Min Hu (Connor) 2020-12-02 10:44 ` Ferruh Yigit 2020-12-02 12:48 ` [dpdk-dev] [PATCH V1] " Min Hu (Connor) 2020-12-08 15:48 ` Ferruh Yigit 2020-12-07 1:28 ` [dpdk-dev] [RFC V4] " Min Hu (Connor) 2020-10-20 8:26 ` [dpdk-dev] [RFC V2 2/2] app/testpmd: fix starting failed with queue-stats-mapping Min Hu (Connor)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=16360f53-28b3-d702-72c0-5523198f583f@huawei.com \ --to=humin29@huawei.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=lihuisong@huawei.com \ --cc=stephen@networkplumber.org \ --cc=thomas.monjalon@6wind.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git