DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v1] config/arm: split aarch32 march
@ 2021-11-05 11:56 Juraj Linkeš
  2021-11-08  5:33 ` Ruifeng Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Juraj Linkeš @ 2021-11-05 11:56 UTC (permalink / raw)
  To: thomas, david.marchand, bruce.richardson, Honnappa.Nagarahalli,
	Ruifeng.Wang, fengchengwen, ferruh.yigit, jerinjacobk, jerinj,
	pbhagavatula
  Cc: dev, Juraj Linkeš

Aarch32 config got overlooked when splitting march in a previous parch.

Fixes: 95e0f23022a3 ("config/arm: split -march into arch and features")
Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 config/arm/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/config/arm/meson.build b/config/arm/meson.build
index d22b41e096..213324d262 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -43,7 +43,8 @@ implementer_generic = {
             'compiler_options': ['-moutline-atomics']
         },
         'generic_aarch32': {
-            'machine_args': ['-march=armv8-a', '-mfpu=neon'],
+            'march': 'armv8-a',
+            'compiler_options': ['-mfpu=neon'],
             'flags': [
                 ['RTE_ARCH_ARM_NEON_MEMCPY', false],
                 ['RTE_ARCH_STRICT_ALIGN', true],
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1] config/arm: split aarch32 march
  2021-11-05 11:56 [dpdk-dev] [PATCH v1] config/arm: split aarch32 march Juraj Linkeš
@ 2021-11-08  5:33 ` Ruifeng Wang
  2021-11-08  8:18   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Ruifeng Wang @ 2021-11-08  5:33 UTC (permalink / raw)
  To: Juraj Linkeš,
	thomas, david.marchand, bruce.richardson, Honnappa Nagarahalli,
	fengchengwen, ferruh.yigit, jerinjacobk, jerinj, pbhagavatula
  Cc: dev, nd

> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: Friday, November 5, 2021 7:57 PM
> To: thomas@monjalon.net; david.marchand@redhat.com;
> bruce.richardson@intel.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; fengchengwen@huawei.com;
> ferruh.yigit@intel.com; jerinjacobk@gmail.com; jerinj@marvell.com;
> pbhagavatula@marvell.com
> Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v1] config/arm: split aarch32 march
> 
> Aarch32 config got overlooked when splitting march in a previous parch.
> 
> Fixes: 95e0f23022a3 ("config/arm: split -march into arch and features")
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH v1] config/arm: split aarch32 march
  2021-11-08  5:33 ` Ruifeng Wang
@ 2021-11-08  8:18   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-11-08  8:18 UTC (permalink / raw)
  To: Juraj Linkeš
  Cc: david.marchand, bruce.richardson, Honnappa Nagarahalli,
	fengchengwen, ferruh.yigit, jerinjacobk, jerinj, pbhagavatula,
	dev, nd, Ruifeng Wang

It is not strictly -march only (-mfpu as well).

08/11/2021 06:33, Ruifeng Wang:
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > 
> > Aarch32 config got overlooked when splitting march in a previous parch.

s/parch/patch/

> > Fixes: 95e0f23022a3 ("config/arm: split -march into arch and features")

blank line missing here

> > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > ---
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

Applied with rewording, thanks.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-11-08  8:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 11:56 [dpdk-dev] [PATCH v1] config/arm: split aarch32 march Juraj Linkeš
2021-11-08  5:33 ` Ruifeng Wang
2021-11-08  8:18   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).