From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 95CE32C19 for ; Fri, 4 Aug 2017 12:44:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 406AA20915; Fri, 4 Aug 2017 06:44:36 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 04 Aug 2017 06:44:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=w+zz/jM3xTCBqyd QjZcT4QcSgzXQMkhhPytS9ehdYUA=; b=WuQGhPlWvghUiUgakHEm/fUe5Z3B7Vd 0jaW2sUnMS4Tn8enGmp03FmhAJ4KZ9BPGGsOJZA6CSifO2Hh3tueNepytLq2HABd 15p3yackKe3aj24TqjDx8BYgIKjMNl4OLsCXq/tFcM2u9A2DfFGh9iexoQ76ctSh QBN8z8i4pel4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=w+zz/jM3xTCBqydQjZcT4QcSgzXQMkhhPytS9ehdYUA=; b=JMqm4edi QiCPh7L2mlQ6JyovajHFTUhdkSJ2cCOC6bef2SOYfzPNnfxIvdtzrJsnzY+wwQmk BGgGeydI7KOl/IDmaL+sGrDrwSKeaBsI3UfkjQt/aiIX3qH74KTaURm7OfpVWbpd YsSRwqdW4CAlXHO95HxauFTV2CVygbILb41WXJAFO4YrGHlDWrJ6SkXj+J3B43Ec eZ5r5Ze21ELA3PuMPm523UB/SMp2HvCJcetX1HISg7mss88Z1S0K7zNeonOngfZb BLisiNKq6nZgtu3cVTyb7xrviYYEv07S2FeucK252i4BW3eggt7WFHiROPfFiQUL Bx7taFIItb5lBA== X-ME-Sender: X-Sasl-enc: 5qcDQimBiYbt6I8KYPxFKWVFhkChSWaHR8zJHVKWymE9 1501843475 Received: from xps.localnet (159.16.90.92.rev.sfr.net [92.90.16.159]) by mail.messagingengine.com (Postfix) with ESMTPA id 0A75C7FA69; Fri, 4 Aug 2017 06:44:35 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org Date: Fri, 04 Aug 2017 12:44:32 +0200 Message-ID: <1636294.pvSmynGaLT@xps> In-Reply-To: <20170804103521.GA5144@jerin> References: <20170804102035.4051-1-thomas@monjalon.net> <20170804103521.GA5144@jerin> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eventdev: fix missing includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 10:44:36 -0000 04/08/2017 12:35, Jerin Jacob: > -----Original Message----- > > Date: Fri, 4 Aug 2017 12:20:35 +0200 > > From: Thomas Monjalon > > To: jerin.jacob@caviumnetworks.com > > Cc: dev@dpdk.org > > Subject: [PATCH] eventdev: fix missing includes > > X-Mailer: git-send-email 2.13.2 > >=20 > > The PCI helper file depends on some EAL definitions. > > Spotted with devtools/check-includes.sh: > > error: implicit declaration of function =E2=80=98rte_eal_process_type= =E2=80=99 > > error: =E2=80=98RTE_PROC_PRIMARY=E2=80=99 undeclared > > error: implicit declaration of function =E2=80=98rte_socket_id=E2=80=99 > >=20 > > There was also this error because the inline keyword was missing: > > error: =E2=80=98rte_event_pmd_pci_probe=E2=80=99 defined but not used > >=20 > > Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions opt= ional") > >=20 > > Signed-off-by: Thomas Monjalon > > --- > > lib/Makefile | 2 +- > > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++- > > 2 files changed, 4 insertions(+), 2 deletions(-) > >=20 > > diff --git a/lib/Makefile b/lib/Makefile > > index 86caba17b..22962910d 100644 > > --- a/lib/Makefile > > +++ b/lib/Makefile > > @@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) +=3D librte_ip_frag > > DEPDIRS-librte_ip_frag :=3D librte_eal librte_mempool librte_mbuf libr= te_ether > > DEPDIRS-librte_ip_frag +=3D librte_hash > > DIRS-$(CONFIG_RTE_LIBRTE_GRO) +=3D librte_gro > > -DEPDIRS-librte_gro :=3D librte_eal librte_mbuf librte_ether librte_net > > +DEPDIRS-librte_gro :=3D librte_eal librte_mbuf >=20 > Looks like unrelated change. Right? Yes you're right. I wanted to remove this wrong part of the patch and forgot. Will send a v2, thanks