From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
by dpdk.org (Postfix) with ESMTP id CD8F4532D
for <dev@dpdk.org>; Fri, 12 Feb 2016 14:59:04 +0100 (CET)
Received: by mail-wm0-f45.google.com with SMTP id 128so63323982wmz.1
for <dev@dpdk.org>; Fri, 12 Feb 2016 05:59:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:organization:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding
:content-type; bh=FwnygTd6Cg0l0LH3bj69OxenVnc+Xcu3ALU1KlKYwWU=;
b=mIvXUE16J4yDmTHvsMwHvHYjSiTUi2GaGVeFEoGEdIqg2Ro7TFKW3+Sd/Vn6pO9L1M
4PkWO+1RP34k+mVqognuncWh7qOumTlIQr9f/PCDMln1BVd0mGgZH82ypmukoEff6zI0
mQhAm+J4iS8wKXfNjN7x+DFoI6HqdgtCyEjJ84PQOlbP5ziHsI/+3SjwHKNiHRKO3cyO
olTzI53asYlhn7ZvexJid2Id4UpOoeTnZDX+UZfuPVNJ/53VIl1B38Wj0bUPkIlULpdw
YT2MgVBw6DYXVYHsrewQ2HkZiZTK32dgLWYTjqiVGSrkDlrPLC12EB4UbISKAFr+JCjx
X9CQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding:content-type;
bh=FwnygTd6Cg0l0LH3bj69OxenVnc+Xcu3ALU1KlKYwWU=;
b=YlpvctYWUSSp9/RzHN8TlRHLVY6777lMfeDjJMXu2FbyWR0QG7Uv9J/IxE19ZhCHI/
RGSUlQGjJliJePvsy/AYphUkp2WeKgg8junpiYHTkH1iL4Kw4xE1E6jUWmJRpRICNpaq
CceO2wWdX1iI9wCGPdfixFwfOoovt7biG/GaeidEnNxv3kTibSROrZRE8CkI37Pmc73a
XP2MPkE36Jbv2f54pRi8lwK5YmajSpELKA9KBWGT/EUc/uMmPU9mQvy/Anhk/4jzJSNC
jzuy/ESB+Jscmjgere2tU05GEtyDK3WohNosjTjxIJI+1qDBozuVG1VzJR2SRp+RDsit
7/SA==
X-Gm-Message-State: AG10YOSw8xGBzcVnqSGqcCwxe8pBepwMOxIgHFOwFC9hqldXJnR4omHR5wflivXRgDrpRnI0
X-Received: by 10.28.51.9 with SMTP id z9mr4282800wmz.59.1455285544645;
Fri, 12 Feb 2016 05:59:04 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
by smtp.gmail.com with ESMTPSA id e9sm12198025wja.25.2016.02.12.05.59.03
(version=TLSv1/SSLv3 cipher=OTHER);
Fri, 12 Feb 2016 05:59:03 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>, Keith Wiles <keith.wiles@intel.com>
Date: Fri, 12 Feb 2016 14:57:34 +0100
Message-ID: <1637610.sEJPJ7NIGK@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <56BDC0C1.9010506@redhat.com>
References: <1455039006-86816-1-git-send-email-keith.wiles@intel.com>
<1455139134-9826-1-git-send-email-keith.wiles@intel.com>
<56BDC0C1.9010506@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] mempool: reduce rte_mempool structure size
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Feb 2016 13:59:05 -0000
2016-02-12 13:23, Panu Matilainen:
> On 02/10/2016 11:18 PM, Keith Wiles wrote:
> > static inline void *rte_mempool_get_priv(struct rte_mempool *mp)
> > {
> > +#ifdef RTE_NEXT_ABI
> > + return (char *)mp +
> > + MEMPOOL_HEADER_SIZE(mp, mp->pg_num, mp->cache_size);
> > +#else
> > return (char *)mp + MEMPOOL_HEADER_SIZE(mp, mp->pg_num);
> > +#endif /* RTE_NEXT_ABI */
> > }
>
> This is not RTE_NEXT_ABI material IMO, the added ifdef clutter is just
> too much.
The changes are restricted to the mempool files.
I think it is not so much. However I wonder how much the feature is important
to justify the use of NEXT_ABI.
> I'd suggest adding a deprecation notice for the change now and after
> 16.04 is released, just resend the patch without messing with RTE_NEXT_ABI.
When adding a deprecation notice, it is really better to provide a reference
to the code change.
So if you give up with NEXT_ABI, please add a link to this code change in
the new commit message. Thanks