From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E0A9A1B675 for ; Sun, 25 Nov 2018 13:10:09 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7578B213CA; Sun, 25 Nov 2018 07:10:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 25 Nov 2018 07:10:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=no15yLgWUCz0XcKayAfJbJYQvp30pOJhub3cRDAT4vI=; b=Ix3W0qFNhp4z L9dxnS6fIu3AA3nDXPccxczWpqOVewO9gWd6vQMal1xTM/FwNjDjjH2uVYndK7WF KQIS/BIR9lWXWjcvVzlkoigfsjWC7URCH/ADE/rdT8M3tLJEX75DMejGDaCFAVJu sfJkvhmoy1vnULB4i1GLhO8z/bjG+oY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=no15yLgWUCz0XcKayAfJbJYQvp30pOJhub3cRDAT4 vI=; b=EG6Xlua4AUOYm1+wpdINUGJxQeSoFRDs0PsNmeVu4G2pBeyhr/90OL3Yt GicfUzKihQGK2aSckEGRfH1/NNWykHO7K8LnWkSRAdbur5XQWuq6ivgZVAOmHJrO eYVOmNpgXoqnAn78ljiFDVrgtQb12Js5jTQYZ68/KYCn+Yy1siL3KGk0w/a88ing koCDvBdYzM/hbHEP7F/fUfG2gv2XkeLH4k9FwI9dE9WDKJHUZgCoYXmRpIQoBSk0 AvCSnzqc9t+AjvXYKeMBd2dgpdwtPEXyrN3w7h+Vb/lNkxGtOrDgq1OXyyhPxVsD FH81Au+8LEnZ7FV9yWD0/nsvGOrQg== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 67AAE102DD; Sun, 25 Nov 2018 07:10:08 -0500 (EST) From: Thomas Monjalon To: Darek Stojaczyk Cc: dev@dpdk.org, qi.z.zhang@intel.com Date: Sun, 25 Nov 2018 13:10:07 +0100 Message-ID: <1637860.pyqJGB34pm@xps> In-Reply-To: <20181121190507.61845-1-dariusz.stojaczyk@intel.com> References: <20181121190507.61845-1-dariusz.stojaczyk@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] dev: don't try to rollback a device attach that failed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2018 12:10:10 -0000 21/11/2018 20:05, Darek Stojaczyk: > If a device fails to attach before it's plugged, > the subsequent rollback will still try to detach it, > causing a segfault. Unplugging a device that wasn't > plugged isn't really supported, so this patch adds > an extra error check to prevent that from happening. > > While here, fix this also for normal (non-rollback) > detach, which could also theoretically segfault on > non-plugged device. > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > Cc: qi.z.zhang@intel.com > > Signed-off-by: Darek Stojaczyk Applied, thanks