From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9A00A0353; Mon, 11 Nov 2019 08:07:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19F48DE3; Mon, 11 Nov 2019 08:07:14 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A68A6237 for ; Mon, 11 Nov 2019 08:07:12 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0442421321; Mon, 11 Nov 2019 02:07:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 11 Nov 2019 02:07:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vF5hCVW93zHGAVYPDe+Dd47oyz3uW78WxkWZ79ZMpoc=; b=iayr/a+Fc1Yx 82n+pEQa2dpp+Fv1K2rb+Fb9LgYx37D21Z3qYW5JXD3WVlA65YPSuMyyN6J4vwaP kay7MLf0RceSQqx1JpwrxxCJfRuFFP1gDYVrQzfB5h+SE1H8RRpVbFE5psl/FQ5f fEgm+W4DPKWbhr0Ck54+jnTobajJ+SQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vF5hCVW93zHGAVYPDe+Dd47oyz3uW78WxkWZ79ZMp oc=; b=Ie3WgI7EgRFWbH+vA4VMAHLJBlroCbfpkKsFo9WnCgEzgIuApQ+QtcM96 FGXSEQg8JWjPdJIIZ3HidC3qwZAvcTkiLw1i8guy9mxPInsql+KcvA03N1UqgTP/ 4KfaxEZmSQayGKtgEWc9u7Yu8DiMwFz7zCBZe3hU+/shilBSBAqcSgnlJcOWHUoG pEuffi6xYfb9KnYEkTJ/r4ZXQc2v1l1eofKky8QdFHrYvo+VsEnx/LldxLFkG7mV zxv4W+5OiEXxzF8bqN3Kni01/WWK6wGqoH0oZQxT7uelUG7LMQ09zSevWb/fn7Ar m6fvBj2gSmbxB65nNSdGstnvCOQuA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedruddviedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepfeejrddujeefrdegjedrudefieenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (unknown [37.173.47.136]) by mail.messagingengine.com (Postfix) with ESMTPA id 50924306005C; Mon, 11 Nov 2019 02:07:05 -0500 (EST) From: Thomas Monjalon To: Harman Kalra Cc: dev@dpdk.org, John McNamara , Marko Kovacevic , Bruce Richardson Date: Mon, 11 Nov 2019 08:07:00 +0100 Message-ID: <1638210.PZqRnmcaYt@xps> In-Reply-To: <1566222457-17342-1-git-send-email-hkalra@marvell.com> References: <1566222457-17342-1-git-send-email-hkalra@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mk: add support for UBSAN X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Sorry for the very late review. I hope someone else would try it. I tried this: devtools/test-build.sh -v x86_64-native-linux-clang+shared+UBSAN+SANITIZE_ALL and it triggers some link errors: /usr/bin/ld: rte_kvargs.c:(.text+0xc65): undefined reference to `__ubsan_handle_pointer_overflow' 19/08/2019 15:48, Harman Kalra: > UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior > detector. UBSan modifies the program at compile-time to catch > various kinds of undefined behavior during program execution. > > This patch implements support for UBSan to the DPDK. > > See: doc/guides/prog_guide/ubsan.rst for more information. > > Signed-off-by: Harman Kalra > --- > +ifeq ($(CONFIG_RTE_UBSAN),y) > +ifeq ($(UBSAN_ENABLE),y) This can be replaced with an oneline: ifeq ($(CONFIG_RTE_UBSAN)$(UBSAN_ENABLE),yy)