From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7633A0C4C; Wed, 1 Dec 2021 09:48:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76B3040E78; Wed, 1 Dec 2021 09:48:40 +0100 (CET) Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by mails.dpdk.org (Postfix) with ESMTP id 98B5A4068C for ; Wed, 1 Dec 2021 09:48:38 +0100 (CET) IronPort-SDR: 31WLyW6lUJkCMJaSWlWwpX8WV5IspKn6uf5saQQbCxqU4KrBBOM5Ow0yoWIWncqeMcFBZeP+Nw Dmmjql7+p43fUtcNbDelqzJJdkvc4Mo5bBCePQdDccBiI2tfMakX1zMoQ8gzc+uJFZ68pyAlr0 Pl5tvgJukVYjk89kr5LhMdeI2pS8cubLyD3p/j2T/yMZSrKBrL3+lr/Yv4N0QN0hI8QPr29dCy 99kO8L88Mti5tCGCBHeWfB31Jkym7Qd1G2R+BBovE+kRAbv5p2DkCNzwRO7MDREUM/AJt0HFci ezfS3H569bePuOZxLAzYppwj X-IronPort-AV: E=Sophos;i="5.87,278,1631606400"; d="scan'208";a="69131203" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 01 Dec 2021 00:48:36 -0800 IronPort-SDR: x43lNxXtLyUnDB53v76Q7RLnzQOhRnykRQZwAUf3oysgJejjxnrAF32fheMTlCtT5hsgFjsE7M tb/bXaRY1QcTsKgEVtg0Z8A/N61MyKBK1nITeJPUBcmCOFsGTL/7EYwwQRR5iQi/fvBA4ghO+f /s9UqbbgcUdHXjHFLCTOeRzQov6XaEjXLK2m0MtovsFttZ/J6G/GUu5c0naw0Xj0qQtnNL8RUV Jr7RYX/yvBOj/Bx+9oaVPXn9mBPkOQZRUm/U4bbh0KoNtGIRG+12KA1uOyUdykRf+ir56y/hkP k/4= From: "Awan, Arsalan" To: "Namburu, Chandu-babu" , "dev@dpdk.org" CC: "Somalapuram, Amaranath" , "Sebastian, Selwin" , "Giriyapura, Maheshwaramurthy" Subject: Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 Thread-Topic: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000 Thread-Index: AQHX1iiECaNqQqg8g0i/N/Z2zni9Z6v//FMAgARpSiqAD5Skc4AABNyAgAALsYGAAat4AIAHvVn6 Date: Wed, 1 Dec 2021 08:48:31 +0000 Message-ID: <1638348510880.95547@mentor.com> References: <20211110114519.8216-1-Arsalan_Awan@mentor.com>, , <1636971324930.27524@mentor.com> <1637827914612.88281@mentor.com>, <1637831201071.84716@mentor.com>, In-Reply-To: Accept-Language: en-US, en-IE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [192.94.31.225] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Chandu,=0A= =0A= I have provided my comments on your patch acknowledging your solution as a = better approach than this one.=0A= =0A= Thanks and regards,=0A= Arsalan=0A= ________________________________________=0A= From: Namburu, Chandu-babu =0A= Sent: Friday, November 26, 2021 3:35 PM=0A= To: Awan, Arsalan; dev@dpdk.org=0A= Cc: Somalapuram, Amaranath; Sebastian, Selwin; Giriyapura, Maheshwaramurthy= =0A= Subject: RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000=0A= =0A= [Public]=0A= =0A= Hi Arsalan,=0A= =0A= I have submitted new patch to community review and looped you in. Please sh= are your comments.=0A= =0A= https://patches.dpdk.org/project/dpdk/list/?series=3D20788=0A= =0A= Regards,=0A= Chandu=0A= =0A= -----Original Message-----=0A= From: Awan, Arsalan =0A= Sent: Thursday, November 25, 2021 2:37 PM=0A= To: Namburu, Chandu-babu ; dev@dpdk.org=0A= Cc: Somalapuram, Amaranath ; Sebastian, Selw= in ; Giriyapura, Maheshwaramurthy =0A= Subject: Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000=0A= =0A= Thanks, Chandu!=0A= =0A= This will help a lot!=0A= =0A= Regards,=0A= Arsalan=0A= ________________________________________=0A= From: Namburu, Chandu-babu =0A= Sent: Thursday, November 25, 2021 1:23 PM=0A= To: Awan, Arsalan; dev@dpdk.org=0A= Cc: Somalapuram, Amaranath; Sebastian, Selwin; Giriyapura, Maheshwaramurthy= =0A= Subject: RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000=0A= =0A= [Public]=0A= =0A= Hi Arsalan,=0A= =0A= We have identified fix for this issue and will submit the patch for communi= ty review asap.=0A= =0A= Thanks,=0A= Chandu=0A= =0A= -----Original Message-----=0A= From: Awan, Arsalan =0A= Sent: Thursday, November 25, 2021 1:42 PM=0A= To: Namburu, Chandu-babu ; dev@dpdk.org=0A= Cc: Somalapuram, Amaranath ; Sebastian, Selw= in ; Giriyapura, Maheshwaramurthy =0A= Subject: Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000=0A= =0A= Hi Chandu,=0A= =0A= Do we have an update on this?=0A= =0A= Can we go ahead with this patch for now as it does not break anything else,= but fixes the problem.=0A= =0A= DPDK will be working fine as is on the e3000.=0A= =0A= This patch only adjusts the code for the v1000 and it works fine and there = isn't a difference in the approach of fixing the problem compared to that b= eing done currently to distinguish between the two platforms i.e. e3000 & v= 1000.=0A= =0A= Hoping to hear from you soon.=0A= =0A= Thanks,=0A= Arsalan=0A= ________________________________________=0A= From: Awan, Arsalan=0A= Sent: Monday, November 15, 2021 3:15 PM=0A= To: Namburu, Chandu-babu; dev@dpdk.org=0A= Cc: Somalapuram, Amaranath; Sebastian, Selwin; Giriyapura, Maheshwaramurthy= =0A= Subject: Re: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000=0A= =0A= Thanks, Chandu!=0A= =0A= Appreciate you guys looking into this!=0A= =0A= Looking forward to hear from you soon.=0A= =0A= Thanks and regards,=0A= Arsalan=0A= ________________________________________=0A= From: Namburu, Chandu-babu =0A= Sent: Friday, November 12, 2021 7:48 PM=0A= To: Awan, Arsalan; dev@dpdk.org=0A= Cc: Somalapuram, Amaranath; Sebastian, Selwin; Giriyapura, Maheshwaramurthy= =0A= Subject: RE: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000=0A= =0A= [AMD Official Use Only]=0A= =0A= Hi Arsalan Awan,=0A= =0A= Thank you for sharing the patch. DPDK not working on V1000 is regression du= e to "bus/pci: optimize bus scan" patch. As RV Root Complex device does not= have any Linux kernel driver assigned, this device is removed from PCI sca= n list and not found using pcie_search_device() routine.=0A= =0A= Patch submitted is potential fix for the issue, but we are checking if this= is the best way to fix regression. Will update you soon on the fix shared.= =0A= =0A= Regards,=0A= Chandu=0A= =0A= -----Original Message-----=0A= From: Arsalan H. Awan =0A= Sent: Wednesday, November 10, 2021 5:15 PM=0A= To: dev@dpdk.org=0A= Cc: Namburu, Chandu-babu ; Somalapuram, Amaranath ; Sebastian, Selwin ; Giriy= apura, Maheshwaramurthy ; Arsalan H. A= wan =0A= Subject: [PATCH] net/axgbe: fix PCI ID to distinguish v1000 vs e3000=0A= =0A= The RV PCI Root Complex Device is not visible to DPDK on the PCI bus via pc= i_search_device on some OSs including Ubuntu and Yocto. This makes it impos= sible to determine which machine DPDK/axgbe is running on. As a result, DPD= K/axgbe does not work on v1000.=0A= =0A= Let's use the Raven Internal PCIe GPP Bridge ID that DPDK can see on the PC= I bus that exists on the v1000 to differentiate between RV AXGBE and SNOWY = AXGBE, and set the registers accordingly. This fixes DPDK not working on v1= 000 platform.=0A= =0A= Signed-off-by: Arsalan H. Awan =0A= ---=0A= drivers/net/axgbe/axgbe_ethdev.c | 6 +++---=0A= 1 file changed, 3 insertions(+), 3 deletions(-)=0A= =0A= diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_eth= dev.c=0A= index 7d40c18a86..7b1b46990f 100644=0A= --- a/drivers/net/axgbe/axgbe_ethdev.c=0A= +++ b/drivers/net/axgbe/axgbe_ethdev.c=0A= @@ -170,7 +170,7 @@ static const struct axgbe_xstats axgbe_xstats_strings[]= =3D {=0A= =0A= /* The set of PCI devices this driver supports */=0A= #define AMD_PCI_VENDOR_ID 0x1022=0A= -#define AMD_PCI_RV_ROOT_COMPLEX_ID 0x15d0=0A= +#define AMD_PCI_RV_INTERNAL_PCIE_GPP_BRIDGE_ID 0x15db=0A= #define AMD_PCI_AXGBE_DEVICE_V2A 0x1458 #define AMD_PCI_AXGBE_DEVICE_V2B = 0x1459=0A= =0A= @@ -2178,9 +2178,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)=0A= pdata->pci_dev =3D pci_dev;=0A= =0A= /*=0A= - * Use root complex device ID to differentiate RV AXGBE vs SNOWY AX= GBE=0A= + * Use Raven Internal PCIe GPP Bridge device ID to differentiate=0A= +RV AXGBE vs SNOWY AXGBE=0A= */=0A= - if (pci_search_device(AMD_PCI_RV_ROOT_COMPLEX_ID)) {=0A= + if (pci_search_device(AMD_PCI_RV_INTERNAL_PCIE_GPP_BRIDGE_ID)) {=0A= pdata->xpcs_window_def_reg =3D PCS_V2_RV_WINDOW_DEF;=0A= pdata->xpcs_window_sel_reg =3D PCS_V2_RV_WINDOW_SELECT;=0A= } else {=0A= --=0A= 2.17.1=0A= =0A=