[dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file

[dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file

[levendsayar]

From: Levend Sayar <levendsayar@gmail.com>

Signed-off-by: Levend Sayar <levendsayar@gmail.com>
---
 lib/librte_eal/include/rte_service_component.h | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/include/rte_service_component.h b/lib/librte_eal/include/rte_service_component.h
index b75aba11b..c1eefae41 100644
--- a/lib/librte_eal/include/rte_service_component.h
+++ b/lib/librte_eal/include/rte_service_component.h
@@ -9,6 +9,11 @@
  * Include this file if you are writing a component that requires CPU cycles to
  * operate, and you wish to run the component using service cores
  */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #include <rte_compat.h>
 #include <rte_service.h>
 
@@ -130,4 +135,8 @@ int32_t rte_service_init(void);
  */
 void rte_service_finalize(void);
 
-#endif /* _SERVICE_PRIVATE_H_ */
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* _RTE_SERVICE_PRIVATE_H_ */
-- 
2.27.0

Re: [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file

[Thomas Monjalon]

07/07/2020 14:25, levendsayar@gmail.com:
> From: Levend Sayar <levendsayar@gmail.com>

Would be good to have a short explanation, even if obvious.

> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
> ---
>  lib/librte_eal/include/rte_service_component.h | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Is it the only file missing such C++ guard?



> --- a/lib/librte_eal/include/rte_service_component.h
> +++ b/lib/librte_eal/include/rte_service_component.h
> @@ -9,6 +9,11 @@
>   * Include this file if you are writing a component that requires CPU cycles to
>   * operate, and you wish to run the component using service cores
>   */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
>  #include <rte_compat.h>
>  #include <rte_service.h>
>  
> @@ -130,4 +135,8 @@ int32_t rte_service_init(void);
>   */
>  void rte_service_finalize(void);
>  
> -#endif /* _SERVICE_PRIVATE_H_ */
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* _RTE_SERVICE_PRIVATE_H_ */
> 

Re: [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file

[Van Haaren, Harry]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, July 7, 2020 3:19 PM
> To: levendsayar@gmail.com
> Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>;
> david.marchand@redhat.com
> Subject: Re: [PATCH] build: C++ linkage support is added to
> rte_service_component.h file
> 
> 07/07/2020 14:25, levendsayar@gmail.com:
> > From: Levend Sayar <levendsayar@gmail.com>
> 
> Would be good to have a short explanation, even if obvious.

+1

> > Signed-off-by: Levend Sayar <levendsayar@gmail.com>

With a short description in the commit message, you can include ack in v2
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

<snip patch>

Re: [dpdk-dev] [PATCH] build: C++ linkage support is added to rte_service_component.h file

[Levend Sayar]

Sorry.
I thought that it does not need to have any explanation since it is obvious
as you said.
But will add an explanation right now and push again.

Thanks for your attention.

Best,
Levend

On Tue, Jul 7, 2020 at 6:01 PM Van Haaren, Harry <harry.van.haaren@intel.com>
wrote:

> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Tuesday, July 7, 2020 3:19 PM
> > To: levendsayar@gmail.com
> > Cc: dev@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>;
> > david.marchand@redhat.com
> > Subject: Re: [PATCH] build: C++ linkage support is added to
> > rte_service_component.h file
> >
> > 07/07/2020 14:25, levendsayar@gmail.com:
> > > From: Levend Sayar <levendsayar@gmail.com>
> >
> > Would be good to have a short explanation, even if obvious.
>
> +1
>
> > > Signed-off-by: Levend Sayar <levendsayar@gmail.com>
>
> With a short description in the commit message, you can include ack in v2
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
>
> <snip patch>
>

[dpdk-dev] [PATCH v3] service: support C++ linkage

[levendsayar]

From: Levend Sayar <levendsayar@gmail.com>

"extern C" define is added to rte_service_component.h file
to be able to use in C++ context

Signed-off-by: Levend Sayar <levendsayar@gmail.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
---
 lib/librte_eal/include/rte_service_component.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/librte_eal/include/rte_service_component.h b/lib/librte_eal/include/rte_service_component.h
index b75aba11b..9e66ee7e2 100644
--- a/lib/librte_eal/include/rte_service_component.h
+++ b/lib/librte_eal/include/rte_service_component.h
@@ -9,6 +9,11 @@
  * Include this file if you are writing a component that requires CPU cycles to
  * operate, and you wish to run the component using service cores
  */
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 #include <rte_compat.h>
 #include <rte_service.h>
 
@@ -130,4 +135,8 @@ int32_t rte_service_init(void);
  */
 void rte_service_finalize(void);
 
+#ifdef __cplusplus
+}
+#endif
+
 #endif /* _SERVICE_PRIVATE_H_ */
-- 
2.27.0

Re: [dpdk-dev] [PATCH v3] service: support C++ linkage

[Thomas Monjalon]

09/07/2020 14:32, levendsayar@gmail.com:
> From: Levend Sayar <levendsayar@gmail.com>
> 
> "extern C" define is added to rte_service_component.h file
> to be able to use in C++ context

It is a bug.
The title should be "service: fix C++ linkage"
And these tags must be added:
Fixes: 21698354c832 ("service: introduce service cores concept")
Cc: stable@dpdk.org

If you agree, I can do the change while merging.

Re: [dpdk-dev] [PATCH v3] service: support C++ linkage

[Levend Sayar]

Sure I agree Thomas.

Thanks in advance.

Best,
Levend

On Thu, Jul 9, 2020 at 4:21 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> 09/07/2020 14:32, levendsayar@gmail.com:
> > From: Levend Sayar <levendsayar@gmail.com>
> >
> > "extern C" define is added to rte_service_component.h file
> > to be able to use in C++ context
>
> It is a bug.
> The title should be "service: fix C++ linkage"
> And these tags must be added:
> Fixes: 21698354c832 ("service: introduce service cores concept")
> Cc: stable@dpdk.org
>
> If you agree, I can do the change while merging.
>
>
>

Re: [dpdk-dev] [PATCH v3] service: support C++ linkage

[Thomas Monjalon]

09/07/2020 15:56, Levend Sayar:
> On Thu, Jul 9, 2020 at 4:21 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > 09/07/2020 14:32, levendsayar@gmail.com:
> > > From: Levend Sayar <levendsayar@gmail.com>
> > >
> > > "extern C" define is added to rte_service_component.h file
> > > to be able to use in C++ context
> >
> > It is a bug.
> > The title should be "service: fix C++ linkage"
> > And these tags must be added:
> > Fixes: 21698354c832 ("service: introduce service cores concept")
> > Cc: stable@dpdk.org
> >
> > If you agree, I can do the change while merging.
> 
> Sure I agree Thomas.
> 
> Thanks in advance.

Applied, thanks