From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7970A0A0C; Thu, 15 Apr 2021 10:27:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B84491620F9; Thu, 15 Apr 2021 10:27:53 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by mails.dpdk.org (Postfix) with ESMTP id B9B4B161D55 for ; Thu, 15 Apr 2021 10:27:52 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 43EEC5805B5; Thu, 15 Apr 2021 04:27:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 15 Apr 2021 04:27:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= wlvyAPK8NZsDc+HB4rcKQKWan4QVmrOd6tk2CbIpruM=; b=pt/BjW+xILZDHVZO 4BYbsNUbEyQsLODGv91gQGFvM3W8nvnfBlXurlvA9l9ZRvaA52aIb0++pznmQ3rq QaCFIjQBDR0xgl+nxJnMahJ5G+4x9dhc6KJDxJfPsa8n7OeeIcDM6KAoTEUefuck d1mbyyKvM7u8eZgwB7nsQkmHOg6kX/aist3ew04MI5HJLbP6zT6lE+Y1cgF1uh56 IESvnGfr7lhKFZ2z2zM+1c9CDjEOroykkKDR4XjaSkynLxhkwGl0PXAwGtPUrzC4 7v8dYHYZbqX2o5TgvVq19L47QZnQe1S4g6MzHuDB/hLs1qaQxFM34ReK3X/cdkP8 PLXDBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=wlvyAPK8NZsDc+HB4rcKQKWan4QVmrOd6tk2CbIpr uM=; b=HzVICWQ0Y2OPJeeZABQSHCMBMUs2J4UXU/spvxF7oiY0pe5pdiXAw3itg pqXmP3l3WYiXFUdT6qfxTy698fI6/N03rjGlFrcbLtrlWdS3SJ5Byedz6UR3olOG /SVfhf5jVDlpXy8kqylU3Fi8Uj1SE1fqZNupTiZWQYCCqlcjdi5vVgc1sRDjoYQt qP2TRLELfgEjWzpwI+HURDC8MSVFm1ji+Lt9xLaYV+JO33Etj7d0XMnat2lnJAJ7 6NFoB7hDxvxFZTEf6YwtYCVlP6qb2fIq39DiFmYO+JbXtsQfPtQhhzvzeH0ThXS4 9eqvgHgrl5km/w8rj+yQuZXUtIWBA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelfedgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 732F924005D; Thu, 15 Apr 2021 04:27:49 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Bruce Richardson Cc: Akhil Goyal , Jerin Jacob Kollanukkaran , dev , Ray Kinsella , Abhinandan Gujjar , Hemant Agrawal , Nipun Gupta , Sachin Saxena , Anoob Joseph , Matan Azrad , Fan Zhang , Gagandeep Singh , Erik Gabriel Carrillo , "Jayatheerthan, Jay" , Pavan Nikhilesh Bhagavatula , Van Haaren Harry , Shijith Thotton , Dodji Seketeli Date: Thu, 15 Apr 2021 10:27:48 +0200 Message-ID: <1639324.BLG93L5jLh@thomas> In-Reply-To: <20210415082517.GA1815@bricha3-MOBL.ger.corp.intel.com> References: <20210414122036.1262579-2-gakhil@marvell.com> <20210415082517.GA1815@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v10 1/4] devtools: add exception for reserved fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/04/2021 10:25, Bruce Richardson: > On Thu, Apr 15, 2021 at 09:26:38AM +0200, David Marchand wrote: > > On Thu, Apr 15, 2021 at 7:33 AM Akhil Goyal wrote: > > > > > +; Ignore changes in reserved fields > > > > > +[suppress_variable] > > > > > + name_regexp = reserved > > > > > > > > Mm, this rule is a bit scary, as it matches anything with "reserved" in it. > > > > > > Why do you feel it is scary? Reserved is something which may change at any time > > > Just like experimental. Hence creating a generic exception rule for it make sense > > > And it is done intentionally in this patch. > > > > The reserved regexp on the name of a variable / struct field is too lax. > > Anything could be named with reserved in it. > > If we have clear patterns, they must be preferred, like (untested) > > name_regexp = ^reserved_(64|ptr)s$ > > > +1 to have a clear name. I would suggest using a "__reserved" prefix, since > no real field name should ever start with that prefix. +1 for the double underscore Changing it now does not break API as it is not supposed to be used.