From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAB18A04B5; Tue, 27 Oct 2020 19:31:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 48C962BD3; Tue, 27 Oct 2020 19:31:06 +0100 (CET) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id CCE852B9D for ; Tue, 27 Oct 2020 19:31:03 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 42C62580112; Tue, 27 Oct 2020 14:31:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 27 Oct 2020 14:31:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= EhFffDld7fhv/ApYhv0auh09iq9iXX2LHw71s4CVv2M=; b=F+TAN9ZUgMXugSjp qLel+yhO4WNuu8GPCQALrQ/5tM2bSQUdw5enJYbFZI79LIDmL37RoG9WHOetL9yX I+Ses3Z4QI6Luon9RJAB0eWGXgboVjbFnj9ED6lRw8MQLG0LtM9aqKDS0Q20Ao7w 0UsCKsfqnisfi9HyC/tC6Z4jIl1YABstYjyN3G8eO1v32E1VhTeczGVr1oeHPDQv UkNmfwkdPFhtXSHl41K+reCosj1A7WzGaR6sdcXTIsm6RWj9zxlX9y2GkZGVsTDx jgWWk/Kxf6wfVgzwYCcxGiEI0S7m5hMQjAYduPVg0q+QfcIGtmLx/IHGSWdWoFED 8heb3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EhFffDld7fhv/ApYhv0auh09iq9iXX2LHw71s4CVv 2M=; b=IM2hSjrZx5G//UCRgQMXX1LtqvxiAF8+6jqUez8Cq+/FVtAkgut4aGW6U Lwe4xfPBbPWWDUxd/W0mLxReh5PRG7s8JQy94PnbhjganZSOZZrIhydppldhMAtX tRK881+fNoTkO9U7oBpMx7LYp7HLV5cN7pHiVWvodQBqmQK5sWsW6g5p28xnd3s4 2WR0GaULEOBKYNdlFFS7IaO/MPmLhqgz2P58Ymx9I89NJESOhUKfOY8y21bZ/ggj Sc4k7BxE8eVwM0c0+2N1mmyLGy6ZZNiUd1akrTjpqPn9xdKuZGWi2lB+EQOOYGRj 5aCS7eELCrzwzpZMNlMJuszYsfGlg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeelgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8848E3280060; Tue, 27 Oct 2020 14:30:56 -0400 (EDT) From: Thomas Monjalon To: "Ma, Liang J" , "Ananyev, Konstantin" Cc: "dev@dpdk.org" , "Burakov, Anatoly" , "viktorin@rehivetech.com" , "Zhang, Qi Z" , "ruifeng.wang@arm.com" , "Xing, Beilei" , "Guo, Jia" , "Yang, Qiming" , "Wang, Haiyue" , "Richardson, Bruce" , "Hunt, David" , "jerinjacobk@gmail.com" , "nhorman@tuxdriver.com" , "McDaniel, Timothy" , "Eads, Gage" , "drc@linux.vnet.ibm.com" , Andrew Rybchenko , "Yigit, Ferruh" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "viacheslavo@nvidia.com" , "matan@nvidia.com" , "ajit.khaparde@broadcom.com" , "rahul.lakkireddy@chelsio.com" , "johndale@cisco.com" , "xavier.huwei@huawei.com" , "shahafs@nvidia.com" , "sthemmin@microsoft.com" , "g.singh@nxp.com" , "rmody@marvell.com" , "maxime.coquelin@redhat.com" , "david.marchand@redhat.com" Date: Tue, 27 Oct 2020 19:30:55 +0100 Message-ID: <1639360.KZQzHLtdKU@thomas> In-Reply-To: References: <1603494392-7181-5-git-send-email-liang.j.ma@intel.com> <3195982.LjJ4KgG7bb@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 04/10] ethdev: add simple power management API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2020 18:43, Ananyev, Konstantin: > > 27/10/2020 12:15, Liang, Ma: > > > > > --- a/lib/librte_ethdev/rte_ethdev.h > > > > > +++ b/lib/librte_ethdev/rte_ethdev.h > > > > > +/** > > > > > + * Retrieve the wake up address for the receive queue. > > > > > > > > I guess how this function should be used, > > > > but a bit more explanations would not hurt here. > > > agree > > > > > + * > > > > > + * @param port_id > > > > > + * The port identifier of the Ethernet device. > > > > > + * @param queue_id > > > > > + * The Rx queue on the Ethernet device for which information will be > > > > > + * retrieved. > > > > > + * @param wake_addr > > > > > + * The pointer to the address which will be monitored. > > > > > > > > This function does not make the address monitored, right? > > > This function only get the target wakeup address. that does not monitor this address. > > > > > > > > > + * @param expected > > > > > + * The pointer to value to be expected when descriptor is set. > > > > > > > > Not sure we should restrict it to a "descriptor". > > > actully that is not limited to a descriptor, any writeback content should work. > > > > > > > > Expecting a value or some bits looks too much restrictive. > > > > I understand it probably fits well for Intel NICs, > > > > but in the general case, we can imagine that any change > > > > in a byte array could be a wake up signal. > > > > > > this parameter doesn not limited user how to use it. > > > In fact, current design can support any bits change within 64 bits content. > > > > How the driver can specify that any value change should be monitored? > > I understand that it is only a value/mask pair, > > it does not give room for "any value". > > As I can read the code, value=0, mask=0 will provide you with 'any value'. > Though it would mean that rte_power_monitor() will *always* go into sleep, > so not sure what will be there any practical usage for such case. I think what is missing is to allow waking up when the value of a byte array is changing, without specifiying any value.