From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3736DA0C40; Sat, 12 Jun 2021 10:34:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B8B7A4003F; Sat, 12 Jun 2021 10:34:57 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 6FEB14003E for ; Sat, 12 Jun 2021 10:34:56 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 14E425C010A; Sat, 12 Jun 2021 04:34:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 12 Jun 2021 04:34:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= RDtzIyBVq0+wBIZZUcwIWf9yK5bnjQfprynm277qcvk=; b=me8kW2T3xq3Vo3el AN82AlNNRjxKVv23YMu1Ehsvl8/QxlziPLpxRfGjXIErDF7JMZKJh95xh5VDuizD 9Rmw9M1211jGRyRo9acL0BLD7AeFzuqGOxIAiAePRnWfUtQrl5jJmNUdsow+DUIQ zB0QmvlE1H2ERVGAKASnRmguZJNIlom3AqklAy1TyG7FLVYtmwffafsabNnqdEnW Cdl8HSn62mq1GXLZZV3h9X7kLftMpGnmWtcYyavCCpAM2nqYDPGH74lTv4QG7KBT AORHQdbtltGfLNFUdZYhTfHFWuKqd0DFDs8u/gTTmcG+P5BX1193PGs38G/geye9 jmsdrQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=RDtzIyBVq0+wBIZZUcwIWf9yK5bnjQfprynm277qc vk=; b=A51S5ykT0XG2gldWAIlISVAYuRfTS89fivbNn/PBh6lJGYxUN3tmMATxV nSkVq/zgGE8TK9Nby4EwcVVJ3kFlS9fjGYZTviunjtSx+6apiYcPTTNBT/VHTRpW FHDsPHsKuMB7ybecWjZiHtfONAkaxFLmQsjODT2iU07b76ZmfRTzSA3XXVYbcI6T lb4q1/qlPhfJDFycdjTcxhhkPM+sSce5p+OQsVa1ewx0N/u8o3X9mkG/VhLMtmgp ddiOQ5XB6R4bbKmJIT6piANxcY5qjlwR+YF7wR3b2mgDvH/bMpdQx9l3CKxh9Rii CJ60Dk5M0BtGBCrScymXgv5PbqcFA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvtddgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Jun 2021 04:34:54 -0400 (EDT) From: Thomas Monjalon To: Xueming Li Cc: dev@dpdk.org, Jerin Jacob , Sunil Kumar Kori , Kiran Kumar K , Nithin Dabilpuram , david.marchand@redhat.com Date: Sat, 12 Jun 2021 10:34:52 +0200 Message-ID: <16401109.pIj2lYa0bN@thomas> In-Reply-To: <20210611224907.1904-1-xuemingl@nvidia.com> References: <20210611224907.1904-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: save error in string copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/06/2021 00:49, Xueming Li: > From: Thomas Monjalon > > Sets rte_errrno if the destination buffer is too small. Would be good to mention the function name, and the reason for the change. > > Signed-off-by: Thomas Monjalon You did half of the patch, so you should add your Signed-off. > --- > lib/eal/common/eal_common_string_fns.c | 4 +++- > lib/eal/common/eal_common_trace.c | 1 - > lib/eal/include/rte_string_fns.h | 5 ++--- > lib/graph/node.c | 12 +++--------- > 4 files changed, 8 insertions(+), 14 deletions(-) Did you check all occurences of rte_strcpy?