From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D1D801B2E2 for ; Mon, 6 Nov 2017 17:03:34 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7625620C44; Mon, 6 Nov 2017 11:03:34 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 06 Nov 2017 11:03:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=AU+NnTUSRGTjZTEmpvTNImLY7R 8Qcehi8GwwDc/YHMs=; b=HueYUir7wj184E03eVwRjcN4OtURz7zWi2NztYIEH4 Pamdzfk+KSAzBXUxtvpXyKIiQP6Hy9jX53UTwGzCOnt9OcpW1jeWdnZFioN2lyDZ BAagMtFUwaYQ0SMLSaeJSgSGNoqkL5vmQhhwS05TrGwJXD1+7csdcUIo3fIV3ZnB w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=AU+NnT USRGTjZTEmpvTNImLY7R8Qcehi8GwwDc/YHMs=; b=TQtoUIRhMPqpbiHsfJh/YZ 3FDk4kkuXj+4f38klDWgsGmz8rskmutVu3txRStNHaNyo9P/oII03rHk5X8Hm0az csS6CvpMQop/iiKwlN8abCpYWC81Uw6Xk2QjIWxpL8Xux8Xxv7UcNKmAjcT+vO60 O5fPTOBVVg026yein1p4qziDNd1kLTXrfRZquXIi+oFra4CaKHHm/pYXxUwpE9yM MRKcSw1SuTVljZ7jc0TdQIkq7Nfjg0V/7+fvT9FO2pRF8MM6pc71HwHY2RjPp/It S3qsvmPjAgalT4jDkPWUWtkgN5M08fN4o1xV3CnhH/t4I1I/mmbvEueqy2CnsaSw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 24BB77FAED; Mon, 6 Nov 2017 11:03:34 -0500 (EST) From: Thomas Monjalon To: Olivier MATZ Cc: Santosh Shukla , sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, dev@dpdk.org Date: Mon, 06 Nov 2017 17:03:33 +0100 Message-ID: <1640645.LeVPPqOgGX@xps> In-Reply-To: <20171106155646.bvjt2pri2n3gejp6@platinum> References: <20170814151537.29454-1-santosh.shukla@caviumnetworks.com> <20171106014141.13266-13-thomas@monjalon.net> <20171106155646.bvjt2pri2n3gejp6@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 12/15] mbuf: rename data address helpers to IOVA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2017 16:03:35 -0000 06/11/2017 16:56, Olivier MATZ: > On Mon, Nov 06, 2017 at 02:41:38AM +0100, Thomas Monjalon wrote: > > The following inline functions and macros have been renamed to be > > consistent with the IOVA wording: > > > > rte_mbuf_data_dma_addr -> rte_mbuf_data_iova > > rte_mbuf_data_dma_addr_default -> rte_mbuf_data_iova_default > > rte_pktmbuf_mtophys -> rte_pktmbuf_iova > > rte_pktmbuf_mtophys_offset -> rte_pktmbuf_iova_offset > > > > The deprecated functions and macros are kept to avoid breaking the API. > > > > Signed-off-by: Thomas Monjalon > > Same here, there are some remaining references after I apply the patches > (maybe we are not on the same base commit id). > > $ git grep 'mbuf.*phys' > ... > lib/librte_mbuf/rte_mbuf.c: fprintf(f, "dump mbuf at %p, phys=%"PRIx64", buf_len=%u\n", > ... > test/test/test_cryptodev.h:pktmbuf_mtophys_offset(struct rte_mbuf *mbuf, int offset) { > test/test/test_cryptodev.h: printf("pktmbuf_mtophys_offset: offset out of buffer\n"); > test/test/test_cryptodev_blockcipher.c: pktmbuf_mtophys_offset(iobuf, > test/test/test_cryptodev_blockcipher.c: pktmbuf_mtophys_offset(sym_op->m_src, You are right. I will fix those occurences. Thanks for the review.