From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 2AE3B2C19 for ; Thu, 26 May 2016 08:31:57 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id n129so86409750wmn.1 for ; Wed, 25 May 2016 23:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fv0FAfaoRuRedelUFT87Ase38QtN1bA5yWH+KfM+QUg=; b=hu0K38Iktpm8hD/zn+VIh+Ec+aQx+blPQ+aMLH3Nq1ccFobwpuKuRKEuzRj/ty+SQU vfMK6RS6+MnLOxKwjzBtdcZhBVRYfJ6CrZefkv1zMdjSeJbxQHIB1kdVzu9N11Mj5KAM 0iRXXQmWOQoEwCE/YW4DwfiVf5U3WlJCW/H5Bt12Rx7wjns/Le411ncfh8dC7sjY7Vpz GN/miSAb1OxlevvYcMVtZBJ3QeXzlBjYatbdewzw9O12iRM2bWJhviW33bo3BKgYkpZt csy9MDLtfViF08TGCuM32RU8hD1Fj7F4R/MzOMoT7OyQnxTSoaPvaSDMsX8VTaIC2gz6 g9oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Fv0FAfaoRuRedelUFT87Ase38QtN1bA5yWH+KfM+QUg=; b=B7jT1TlPtb6iiV2Co5K0iHICEMkDvKn850/F101ckk8jvgSgI62jvDJz6Xu/hxcjoc tI9osHgLWuiE+jkw7QYnFugBXacuxC1KhR0BjqZA2Hc/0t1UnH1anz4yjhfnck0XCHCr U+obcHek68Mw/t3zk/gbY0kNNTEasmaUHRVftXZyfx6LywRd86MPCGbgRijRpYCVJGmo mtvV8JSPXoeLg5xtk8ENGNSAmqTBBGS+S8rV1AgIwHrgGXmax4+N2eJpaAwNdOITsDkn DkjLdZ3oA+kVQqYt3Daujdh7nQ2j2htGdYDyw1Cfzuqq+j6S8LwkaNWQmr8iHoBaMYi+ lhLw== X-Gm-Message-State: ALyK8tJ+HV+XZttoPa8HN34ZIxU9BnPiniL1AeyMy74Ohh+YZrGkhV7Ii5IqHMxNtvm8DrkI X-Received: by 10.28.127.6 with SMTP id a6mr1798123wmd.95.1464244316947; Wed, 25 May 2016 23:31:56 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id on2sm12556834wjc.32.2016.05.25.23.31.55 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2016 23:31:56 -0700 (PDT) From: Thomas Monjalon To: "Wang, Zhihong" Cc: dev@dpdk.org, "Ananyev, Konstantin" , "Richardson, Bruce" , "De Lara Guarch, Pablo" Date: Thu, 26 May 2016 08:31:55 +0200 Message-ID: <1640688.ZKKLjeEMeZ@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <8F6C2BD409508844A0EFC19955BE094110743728@SHSMSX103.ccr.corp.intel.com> References: <1462488421-118990-1-git-send-email-zhihong.wang@intel.com> <1511439.3kRGpiG3WX@xps13> <8F6C2BD409508844A0EFC19955BE094110743728@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/6] testpmd: configurable tx_first burst number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2016 06:31:57 -0000 2016-05-26 02:53, Wang, Zhihong: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-05-05 18:46, Zhihong Wang: > > > This patch enables configurable tx_first burst number. > > > > > > Use "start tx_first (burst_num)" to specify how many bursts of packets to > > > be sent before forwarding start, or "start tx_first" like before for the > > > default 1 burst send. > > > > The idea here is to fill the loopback latency gap with bursts. > > Would it be possible to make it automatic by detecting the first > > received packets to stop Tx generator? > > The idea is great! The implementation might not be graceful though > -- current tx_first mode first calls txonly engine before calling the > actual engine, say iofwd, so iofwd is not established before tx_first > is done, therefore no detection. And what about rewriting tx_first? No strong opinion. I let you and Pablo decide. > It's possible to do this, but we need to implement another forward > engine like "io_retry_fill_first" alone, it complicates testpmd just for > this loop back test. > > Looks to me it's better to use combination of existing fwd engines to > do this, it's also more flexible with burst number parameters.