From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F051841D9F; Tue, 28 Feb 2023 19:54:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4D4D40EE6; Tue, 28 Feb 2023 19:54:58 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2078.outbound.protection.outlook.com [40.107.101.78]) by mails.dpdk.org (Postfix) with ESMTP id D77F54021F for ; Tue, 28 Feb 2023 19:54:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6DXsn8qus+rPLI0egYlYyEkSO70AJdJ2XNasYXTsxViA7VaNgY9cx3tC571W3la8t9k5EIJ9r2djqsNVFasRkVmYY4qSN7zz3JkoJX2XqxuDZYdWWAWGIe62Yqa1pcOKoXGRvi5Qwf+c4DhGKkTBG853enUNxo3zorEQ/sgZTCFj5PmhQXMRNMcvIXDw509KbriHFhAWRwjfAWroSlIyy/NApKH+s6dTfXwOQzWfIoCHmexrlMmVaoD2Y3vzrTWVT0Ffaxil5rrqKMH4FgyF36Bgopday4kQ0HQHWAXwtqH7UG6+2ssVEKO0WPVv40G8ApSXe9ckjH93lEokrKZuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dUDGZDwNp/JFSqTjWaHZwpAY+Yf0720z3h+QQ9t8SEo=; b=RKnnAu+LaEIKvEirCHMNjYXGU6cfAW2L8k7C95UMNiN21gVUY6dweh97/u/+z/f+T4DO7nW7u4QWldzdJALS9UbI3lvAR2dTS4h0rYPVUFGSJtAiKFtq0uKvxwWJ3nksnoCcsN8HjCNEE0wWc5TECW/bwOhWZVyFHzCxOCTm2vJmW3k38zPwHWmC4ZXkcb2q/KOpYXBH+RJWo2vYvvJDmt3RfgOKWgDkzPk4MJuc0ErH3qFj8bgmfbHVVhsycGuf59QiZ04RXOha+ISilt0fSbh17d4Fcpqmh8KR/UmJC1QPGggZt+znmB1JJ6Y0wijTbXDGFXDVuHaz5gSoXv5FvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dUDGZDwNp/JFSqTjWaHZwpAY+Yf0720z3h+QQ9t8SEo=; b=nyjQ73BECJ/uaVoFLF2TiK00MhcHb8+yZ3P0LNcPyHnxOPmBNKzfbw9s5stpl/+MgUkAwWWuWB4bO7a42CHaNa/TPiz7+qs8cZ+KtWfajh3TEKNGKmHYH9Oq3NSxpQBtKtbO8AJP1t+eA2ifVW3S6/hfTeTFC3JCCnhs/IY8FDU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by CH0PR12MB5252.namprd12.prod.outlook.com (2603:10b6:610:d3::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.30; Tue, 28 Feb 2023 18:54:55 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::80ae:e5ed:4fa7:2ad7%9]) with mapi id 15.20.6134.030; Tue, 28 Feb 2023 18:54:55 +0000 Message-ID: <1640a214-93e3-7bb9-5d55-4d78a84a31fb@amd.com> Date: Tue, 28 Feb 2023 18:54:49 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v3 0/9] Testpmd code cleanup Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: Aman Singh , Yuying Zhang , Robin Jarry References: <20230124104742.1265439-1-david.marchand@redhat.com> <20230220183502.3348368-1-david.marchand@redhat.com> From: Ferruh Yigit In-Reply-To: <20230220183502.3348368-1-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0623.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::18) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|CH0PR12MB5252:EE_ X-MS-Office365-Filtering-Correlation-Id: af0a761f-d674-4ffb-43f9-08db19bd4850 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qE6DXIlj1z3PFFZTEncl4rUmpZIs6yG8E3xWTRWENn8KFfMKWY3X/x7WQ1FtBe5u3atu0vSMZRK5zsuVIA0cMiACVeJajlIV4LWWDc1rvJaeNZvrOjnAnAjYWpqrq8iMOGFnkpJTy51PfSF1eRa69d178QO46hAySrsgpZaZJuVW8BjJpNWcZcRjvR5/uIBPdcDavT8HkBZ1DoHZ4NYaKvOxF76EgNopMzD+j0RNgCTaY/HLww+5iDoGQrXSKmMJcLUVKDY7rteBNiYzHK+ledEPbTsHBXEx5Xh23npBPUMXQXrrsJOQdaBrjimQha+oYZmz7Ogr2SUiq62zqoWqhnN7koIExMJAC/+6ffcQwGLjT0Fo1OTaUuANj6vlv+ekD3XkjAmj06/0o7cwGt9y2U3vkEkGlNFUCX8XktaZd6JeDz/I1FU9ZLeecF5Oi49Vdk/H6TfPl2+z5f2l/mNCQpxInDRHYA6d/UtMHUs3ZS3SCvcMHLEhcP1hfFJAcUXepO1K3gIhe3acQmw1StoEblp4g06FkVmPLuD7k8JFKE/jcbMGcu/WF09o8SuyvRJIbLQ0RRHsT5jOcVfjRUORUAtQ8PDqW4ysK7F1LcSrMhYRrYf1xyNPmPeGWZJPlYW6/foySCn+LbAZfv7BuIWzgZthnx3N3PQ3AemI83+uU55KnX4S+0dZuamd8dSif1pR17Vef5QAhSZMC3HP7A41Bw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(376002)(136003)(346002)(366004)(396003)(451199018)(31686004)(36756003)(86362001)(31696002)(66476007)(66946007)(8676002)(66556008)(5660300002)(4326008)(41300700001)(8936002)(2906002)(44832011)(4744005)(38100700002)(6666004)(6486002)(966005)(478600001)(54906003)(316002)(26005)(83380400001)(2616005)(186003)(6512007)(53546011)(6506007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THFMNjlpTFIvNEI2VkZGN3RLVmowaWN1Qkd4dlFqZllEY2VGVDZySGgrc0cw?= =?utf-8?B?TzV1UlI1SG8rbExaeWIrTWZHV2RWU1ByYTN5ZXZzcW42RysrSlRrWnZxTlJz?= =?utf-8?B?dXZyVU05TGwvRWlWNTlVbjBaMk1SODUwUGxnWnlTUnpYZDJrTDkrdEUyaG4y?= =?utf-8?B?bllScE9SYkdZZUZISExCNzQyWjNyWTNzRHZmZktqSVJqYUNuTXVVeTlPd2FT?= =?utf-8?B?enB1V1VKZkJ6bW5YRnZISWo5cEZIMGVER0ZxWWVScUFOOTBUeXRWQk1vcEdC?= =?utf-8?B?OEgzQ0lOZXBWMXFjZnZ0RXdoSjc1dzI5VnpKaDdqUkxUWk5Hc1pQbEM4ZjEw?= =?utf-8?B?MXBmVlRmc0Z2b2gzRFhsU0lwWUQ4cUtCT00xVUtDdnV3MGVYaFNlMGlzQ2Qw?= =?utf-8?B?a2sxK2dNQ3h5YjFveExTQ0hHQWloendlMGkzQUtYTkpnTU1MQ01kbTF2d1hO?= =?utf-8?B?S2hobkFUNTRhN3cydk51dXdkaWxxbGJXL0R0L25uMmZZMlpsNW5ZN2lIaUty?= =?utf-8?B?Y0xnNzlqQzY3Q3ZCUnBwYitXYUdDd2FpYWtrZmJpY1hwelVaZnkxY3dkTWI0?= =?utf-8?B?QmRPaDhDNXV1WEFwb01LZSttS2R1dG1aV1N3OUVNS2ZiNGFFa3MwQSt4R0dH?= =?utf-8?B?WU4vbVVOTERNYmt1Sk02UnJzcGV3Z0cvaTNEU2ZtNU8rdlZKclZib0Fja3Zw?= =?utf-8?B?dklQMTQ1akcxRWhpcHVFUHZ5c3czTmEwaklncGpKVllHVU4xTldJKzcxd0dP?= =?utf-8?B?R3l6VjZQSDhLaVhrNTdZSUdNenFOVGIrVkdLNVBMRjh6aTJSbEQzdTRSdm4x?= =?utf-8?B?T2VHWitjeFhnS2hVR25YSVAvdm81ZnBUYXVPbUdEYys5eDRud0N3bWg3cXVG?= =?utf-8?B?clF6L1BMRDZzUGROdVF2VkZzTFlPT2pQeThTNy95RVJyUko4UHVCc0tBYU1H?= =?utf-8?B?WXh5TEg0aG9rL3Z4dlJMNDlUc0lnd3V1SzNtZ2EvZXRsZEJSQ1dVSEhhUThS?= =?utf-8?B?eTJlSis0MG9RU2h5YXRDSkRMRlo3VmVyNUZTZHJvSVQ3SDdydGhxT1JLVXky?= =?utf-8?B?NGh2MUluQ1BXWjNxbjVSOTY1WTE4Y3pCTVIzeFp1MkU3MTNiMmtUSTdLMzZL?= =?utf-8?B?WHRXNlRkbjF1eFRTR21wY1VhOG9VcWtJRWVwNjh6S0U1NHpYcncrSWV1bm5v?= =?utf-8?B?Z1ZVdThXdStreHp0bmJ2SGVCbDJXM0plVE9jdEQ5SWVnYmdOUGhpLzMzSjhV?= =?utf-8?B?WUpjb0NXUGlCTi9qYWNYSDFRa1VlN2RDUE9aUGlXSmVvYktxa0RrVllFSVoz?= =?utf-8?B?aFJ6ZWZkU1hqOUxXbzBkSUFWaFI3VDdXYXNoeUhDUW1IZGo1NEJKSjNtMk8w?= =?utf-8?B?bDltcXhnOW5NTnd4TFEyYWFWT2xlTVdQL2wrRnBWR2xpamhBbENMZWxCUUpp?= =?utf-8?B?T2NOVnV5QUxBRHhISlRIc3RtMmVHM1ZZbVFSMGJSZUhoc0ovek56ZGlZcWYz?= =?utf-8?B?d0J4dWdreVJXbEI5OEdBcUw1VlFzeDFSTG1zeVpRM09vdjdWZ0NGRlJ3TmNQ?= =?utf-8?B?VHNVVGdzWDJBbkhvMDVkQmx0ZFFnS1Bmb2FWQ3l6NUFCSU0ySjZrajZWZHVt?= =?utf-8?B?aWZzZlZteldUM1VXWmVkcDFUd3Y0aHZ5U3dxQ1pjcUpmb050NmRuVVhVTm4x?= =?utf-8?B?TG11TDZmOWdGQ0J4L1B3VFVmdmxheS9EaEtBWXNINnVoQ0xVQUwyYTlpKzdj?= =?utf-8?B?cG9zNkZDbzhCa3BmUzhpSU1BVnozdDNDNGxlcmhIbnBKRVo2cCtuSVBTTXdS?= =?utf-8?B?QTlMVkx4ZFd5b3prRnJWajJ2a0czSHFQbSs4dDczMW5PVm55SHJxdm5vNWJo?= =?utf-8?B?Nk1jZU9vTFlWMW1tRVI2SVJIY2p2ZHZ6dlJzQWIwMnRudUJtYVhteFNyd3BQ?= =?utf-8?B?MnZYQlhjbnpDdlJ4SXN4RjY4d2IrcUJ2dURDVXJDSFJLNHo1QVh5TWcwVVZK?= =?utf-8?B?MkgwN20wUk9pNDErTEZETTZlbk5xbjcwNXo4OFIxc0IvN1gvaXg4R3p6cWZV?= =?utf-8?B?dVdPRkRna0o5NHFxZllWM0xTZG1iUmYxM0I2d1JxWlpwREVwY2d6YlZ1amRK?= =?utf-8?Q?7R4GiKgmex+irRTiPSbbWsBiv?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: af0a761f-d674-4ffb-43f9-08db19bd4850 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2023 18:54:55.7977 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DfISEWSWIi4QDexcNr2SDk+lbNLGnbR4MTMUB/kyq60U4QefSEGfm24k69iHXBBp X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5252 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/20/2023 6:34 PM, David Marchand wrote: > Here is a series to reduce code duplication in testpmd. > > This work started from looking at Robin series on reporting lcore busy > cycles in telemetry, which is then added in testpmd [1]. > While looking at the forward engines code, I saw way too much > duplicated code. > > Warning: this is only compile tested. > > 1: https://patchwork.dpdk.org/project/dpdk/patch/20230119150656.418404-5-rjarry@redhat.com/ Series applied to dpdk-next-net/main, thanks.