* [PATCH] net/bonding: fix RSS not work for bonding
@ 2022-01-12 7:22 Yu Wenjun
0 siblings, 0 replies; 5+ messages in thread
From: Yu Wenjun @ 2022-01-12 7:22 UTC (permalink / raw)
To: ferruh.yigit, humin29, tangchengchang; +Cc: dev, stable, Yu Wenjun
RSS don't work when bond_ethdev_configure called before rte_eth_bond_slave_add in DPDK21.11.
e.g.:
dont't work(examples/bond/main.c):
rte_eth_bond_create()
rte_eth_dev_configure()
rte_eth_bond_slave_add()
rte_eth_dev_start()
work(testpmd):
rte_eth_bond_create()
rte_eth_bond_slave_add()
rte_eth_dev_configure()
rte_eth_dev_start()
Signed-off-by: Yu Wenjun <yuwenjun@cmss.chinamobile.com>
Acked-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 84f4900ee5..31bcee15cf 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3504,6 +3504,11 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) {
struct rte_eth_rss_conf *rss_conf =
&dev->data->dev_conf.rx_adv_conf.rss_conf;
+
+ if (internals->rss_key_len == 0) {
+ internals->rss_key_len = sizeof(default_rss_key);
+ }
+
if (rss_conf->rss_key != NULL) {
if (internals->rss_key_len > rss_conf->rss_key_len) {
RTE_BOND_LOG(ERR, "Invalid rss key length(%u)",
--
2.32.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/bonding: fix RSS not work for bonding
2022-01-18 2:59 Yu Wenjun
@ 2022-01-18 3:25 ` Min Hu (Connor)
0 siblings, 0 replies; 5+ messages in thread
From: Min Hu (Connor) @ 2022-01-18 3:25 UTC (permalink / raw)
To: Yu Wenjun, ferruh.yigit, tangchengchang; +Cc: dev, stable
Hi,
When you send the new version patch, you should add tile like:
[PATCH v2], [PATCH v3]...
Also, you missed other tips in the doc. I think you should read it
carefully.
Please refer to:
https://doc.dpdk.org/guides/contributing/patches.html
Thanks.
在 2022/1/18 10:59, Yu Wenjun 写道:
> RSS don't work when bond_ethdev_configure called before
> rte_eth_bond_slave_add in DPDK21.11.
>
> e.g.:
>
> dont't work(examples/bond/main.c):
> rte_eth_bond_create()
> rte_eth_dev_configure()
> rte_eth_bond_slave_add()
> rte_eth_dev_start()
>
> work(testpmd):
> rte_eth_bond_create()
> rte_eth_bond_slave_add()
> rte_eth_dev_configure()
> rte_eth_dev_start()
>
> Signed-off-by: Yu Wenjun <yuwenjun@cmss.chinamobile.com>
> Acked-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 84f4900ee5..31bcee15cf 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -3504,6 +3504,11 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
> if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) {
> struct rte_eth_rss_conf *rss_conf =
> &dev->data->dev_conf.rx_adv_conf.rss_conf;
> +
> + if (internals->rss_key_len == 0) {
> + internals->rss_key_len = sizeof(default_rss_key);
> + }
> +
> if (rss_conf->rss_key != NULL) {
> if (internals->rss_key_len > rss_conf->rss_key_len) {
> RTE_BOND_LOG(ERR, "Invalid rss key length(%u)",
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net/bonding: fix RSS not work for bonding
@ 2022-01-18 2:59 Yu Wenjun
2022-01-18 3:25 ` Min Hu (Connor)
0 siblings, 1 reply; 5+ messages in thread
From: Yu Wenjun @ 2022-01-18 2:59 UTC (permalink / raw)
To: ferruh.yigit, humin29, tangchengchang; +Cc: dev, stable, Yu Wenjun
RSS don't work when bond_ethdev_configure called before
rte_eth_bond_slave_add in DPDK21.11.
e.g.:
dont't work(examples/bond/main.c):
rte_eth_bond_create()
rte_eth_dev_configure()
rte_eth_bond_slave_add()
rte_eth_dev_start()
work(testpmd):
rte_eth_bond_create()
rte_eth_bond_slave_add()
rte_eth_dev_configure()
rte_eth_dev_start()
Signed-off-by: Yu Wenjun <yuwenjun@cmss.chinamobile.com>
Acked-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 84f4900ee5..31bcee15cf 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3504,6 +3504,11 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) {
struct rte_eth_rss_conf *rss_conf =
&dev->data->dev_conf.rx_adv_conf.rss_conf;
+
+ if (internals->rss_key_len == 0) {
+ internals->rss_key_len = sizeof(default_rss_key);
+ }
+
if (rss_conf->rss_key != NULL) {
if (internals->rss_key_len > rss_conf->rss_key_len) {
RTE_BOND_LOG(ERR, "Invalid rss key length(%u)",
--
2.32.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/bonding: fix RSS not work for bonding
2022-01-18 1:00 Yu Wenjun
@ 2022-01-18 2:20 ` Min Hu (Connor)
0 siblings, 0 replies; 5+ messages in thread
From: Min Hu (Connor) @ 2022-01-18 2:20 UTC (permalink / raw)
To: Yu Wenjun, ferruh.yigit, tangchengchang; +Cc: dev, stable
Hi,
Maybe your comment is too long, have you done some check
using ./devtools/*.sh ?
在 2022/1/18 9:00, Yu Wenjun 写道:
> RSS don't work when bond_ethdev_configure called before rte_eth_bond_slave_add in DPDK21.11.
>
> e.g.:
>
> dont't work(examples/bond/main.c):
> rte_eth_bond_create()
> rte_eth_dev_configure()
> rte_eth_bond_slave_add()
> rte_eth_dev_start()
>
> work(testpmd):
> rte_eth_bond_create()
> rte_eth_bond_slave_add()
> rte_eth_dev_configure()
> rte_eth_dev_start()
>
> Signed-off-by: Yu Wenjun <yuwenjun@cmss.chinamobile.com>
> Acked-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
> index 84f4900ee5..31bcee15cf 100644
> --- a/drivers/net/bonding/rte_eth_bond_pmd.c
> +++ b/drivers/net/bonding/rte_eth_bond_pmd.c
> @@ -3504,6 +3504,11 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
> if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) {
> struct rte_eth_rss_conf *rss_conf =
> &dev->data->dev_conf.rx_adv_conf.rss_conf;
> +
> + if (internals->rss_key_len == 0) {
> + internals->rss_key_len = sizeof(default_rss_key);
> + }
> +
> if (rss_conf->rss_key != NULL) {
> if (internals->rss_key_len > rss_conf->rss_key_len) {
> RTE_BOND_LOG(ERR, "Invalid rss key length(%u)",
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net/bonding: fix RSS not work for bonding
@ 2022-01-18 1:00 Yu Wenjun
2022-01-18 2:20 ` Min Hu (Connor)
0 siblings, 1 reply; 5+ messages in thread
From: Yu Wenjun @ 2022-01-18 1:00 UTC (permalink / raw)
To: ferruh.yigit, humin29, tangchengchang; +Cc: dev, stable, Yu Wenjun
RSS don't work when bond_ethdev_configure called before rte_eth_bond_slave_add in DPDK21.11.
e.g.:
dont't work(examples/bond/main.c):
rte_eth_bond_create()
rte_eth_dev_configure()
rte_eth_bond_slave_add()
rte_eth_dev_start()
work(testpmd):
rte_eth_bond_create()
rte_eth_bond_slave_add()
rte_eth_dev_configure()
rte_eth_dev_start()
Signed-off-by: Yu Wenjun <yuwenjun@cmss.chinamobile.com>
Acked-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 84f4900ee5..31bcee15cf 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3504,6 +3504,11 @@ bond_ethdev_configure(struct rte_eth_dev *dev)
if (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_RSS) {
struct rte_eth_rss_conf *rss_conf =
&dev->data->dev_conf.rx_adv_conf.rss_conf;
+
+ if (internals->rss_key_len == 0) {
+ internals->rss_key_len = sizeof(default_rss_key);
+ }
+
if (rss_conf->rss_key != NULL) {
if (internals->rss_key_len > rss_conf->rss_key_len) {
RTE_BOND_LOG(ERR, "Invalid rss key length(%u)",
--
2.32.0.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-18 8:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-12 7:22 [PATCH] net/bonding: fix RSS not work for bonding Yu Wenjun
2022-01-18 1:00 Yu Wenjun
2022-01-18 2:20 ` Min Hu (Connor)
2022-01-18 2:59 Yu Wenjun
2022-01-18 3:25 ` Min Hu (Connor)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).