From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id F06BC1B8B5 for ; Wed, 17 Apr 2019 21:54:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 80D3D21C08; Wed, 17 Apr 2019 15:54:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Apr 2019 15:54:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kysazD+8+VvjFCOW/IM0kPDCAFucVl5+dy/0aGSqCkE=; b=Dgy20FQ/Z+a5 V1B3ZmC+OmfTQl+TJKr0cVuhFf6vsOfAWFz6g48xFEPnMGILi/R3SLuNHJwUtoNx Lz6uD9rFjh6QLaBFAV6BpMnjIBmqtylo/WSankO0sS9W5IyJZeAjMYKMUeXZy4w5 kl/YfI+WyfAmCxK4pF62LNOaPEyiGUA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=kysazD+8+VvjFCOW/IM0kPDCAFucVl5+dy/0aGSqC kE=; b=QByAJq6aSWCM6doPQ+3xyk0D+BklGrTFp9o3wM8NI34KSCR/7lDjniM3Y At7EsXzb1aJrBzIicawCxjJN8xT5l/jbjv+whjtFd6LSts9bffldl4Cii3cdExQp 245hxur7GrO2XLMuTFzoR+XcuUxWkjTLwyJyR7E6GITE3zmkOThxGWqx46rwj7JS b8tfMukk0DYZa2OhgLCy4mdaPAwhl1Lrg/feq92AbN6fpYOBWf44WH3RpDkUR6L8 2tqEBO+oomt5GxUftthDBvHZvoigPVG+Zkb0MX8oBAy2nbXFDtQX7eaF2xPbqmwh FE5mkNb8wzMkOX17gVUcHC3lm3wfQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeefgddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 665FB103CB; Wed, 17 Apr 2019 15:54:06 -0400 (EDT) From: Thomas Monjalon To: Erik Gabriel Carrillo Cc: dev@dpdk.org, rsanford@akamai.com Date: Wed, 17 Apr 2019 21:54:04 +0200 Message-ID: <1642111.88Saxy7NWj@xps> In-Reply-To: <1555364488-28207-1-git-send-email-erik.g.carrillo@intel.com> References: <1551892822-23967-1-git-send-email-erik.g.carrillo@intel.com> <1555364488-28207-1-git-send-email-erik.g.carrillo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 0/2] Timer library changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 19:54:08 -0000 15/04/2019 23:41, Erik Gabriel Carrillo: > This patch series modifies the timer library in such a way that > structures that used to be statically allocated in a process's data > segment are now allocated in shared memory. As these structures contain > lists of timers, new APIs are introduced that allow a caller to specify > the particular structure instance into which a timer should be inserted > or from which a timer should be removed. This enables primary and > secondary processes to modify the same timer list, which enables some > multi-process use cases that were not previously possible; e.g. a > secondary process can start a timer whose expiration is detected in a > primary process running a new flavor of timer_manage(). > > The original library API is mostly unchanged, though implementations are > updated to call into newly added functions with a default structure > instance ID that provides the original behavior. New functions are > introduced to enable applications to allocate structure instances to > house timer lists, and to reference them with an identifier when > starting and stopping timers, and finally, to manage the timer lists > referenced with an identifier. > > My initial performance testing with the "timer_perf_autotest" test shows > no performance regression or improvement, and inspection of the > generated optimized code shows that the extra function call gets inlined > in the functions that now have an extra function call. > > Erik Gabriel Carrillo (2): > timer: allow timer management in shared memory > timer: add function to stop all timers in a list Applied with meson fix, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 81991A00E6 for ; Wed, 17 Apr 2019 21:54:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B5171B8B8; Wed, 17 Apr 2019 21:54:10 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id F06BC1B8B5 for ; Wed, 17 Apr 2019 21:54:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 80D3D21C08; Wed, 17 Apr 2019 15:54:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 17 Apr 2019 15:54:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=kysazD+8+VvjFCOW/IM0kPDCAFucVl5+dy/0aGSqCkE=; b=Dgy20FQ/Z+a5 V1B3ZmC+OmfTQl+TJKr0cVuhFf6vsOfAWFz6g48xFEPnMGILi/R3SLuNHJwUtoNx Lz6uD9rFjh6QLaBFAV6BpMnjIBmqtylo/WSankO0sS9W5IyJZeAjMYKMUeXZy4w5 kl/YfI+WyfAmCxK4pF62LNOaPEyiGUA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=kysazD+8+VvjFCOW/IM0kPDCAFucVl5+dy/0aGSqC kE=; b=QByAJq6aSWCM6doPQ+3xyk0D+BklGrTFp9o3wM8NI34KSCR/7lDjniM3Y At7EsXzb1aJrBzIicawCxjJN8xT5l/jbjv+whjtFd6LSts9bffldl4Cii3cdExQp 245hxur7GrO2XLMuTFzoR+XcuUxWkjTLwyJyR7E6GITE3zmkOThxGWqx46rwj7JS b8tfMukk0DYZa2OhgLCy4mdaPAwhl1Lrg/feq92AbN6fpYOBWf44WH3RpDkUR6L8 2tqEBO+oomt5GxUftthDBvHZvoigPVG+Zkb0MX8oBAy2nbXFDtQX7eaF2xPbqmwh FE5mkNb8wzMkOX17gVUcHC3lm3wfQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeefgddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 665FB103CB; Wed, 17 Apr 2019 15:54:06 -0400 (EDT) From: Thomas Monjalon To: Erik Gabriel Carrillo Cc: dev@dpdk.org, rsanford@akamai.com Date: Wed, 17 Apr 2019 21:54:04 +0200 Message-ID: <1642111.88Saxy7NWj@xps> In-Reply-To: <1555364488-28207-1-git-send-email-erik.g.carrillo@intel.com> References: <1551892822-23967-1-git-send-email-erik.g.carrillo@intel.com> <1555364488-28207-1-git-send-email-erik.g.carrillo@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 0/2] Timer library changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417195404.8tb_iePAuAqIuZOQLuwFISpdBpWPgX7JiNPMJ_r2maE@z> 15/04/2019 23:41, Erik Gabriel Carrillo: > This patch series modifies the timer library in such a way that > structures that used to be statically allocated in a process's data > segment are now allocated in shared memory. As these structures contain > lists of timers, new APIs are introduced that allow a caller to specify > the particular structure instance into which a timer should be inserted > or from which a timer should be removed. This enables primary and > secondary processes to modify the same timer list, which enables some > multi-process use cases that were not previously possible; e.g. a > secondary process can start a timer whose expiration is detected in a > primary process running a new flavor of timer_manage(). > > The original library API is mostly unchanged, though implementations are > updated to call into newly added functions with a default structure > instance ID that provides the original behavior. New functions are > introduced to enable applications to allocate structure instances to > house timer lists, and to reference them with an identifier when > starting and stopping timers, and finally, to manage the timer lists > referenced with an identifier. > > My initial performance testing with the "timer_perf_autotest" test shows > no performance regression or improvement, and inspection of the > generated optimized code shows that the extra function call gets inlined > in the functions that now have an extra function call. > > Erik Gabriel Carrillo (2): > timer: allow timer management in shared memory > timer: add function to stop all timers in a list Applied with meson fix, thanks