From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id E70C420F for ; Tue, 10 Jan 2017 09:46:38 +0100 (CET) Received: by mail-wm0-f48.google.com with SMTP id k184so151525007wme.1 for ; Tue, 10 Jan 2017 00:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=f0uBg/5KPoRiDYj5l62flxI4v4bmc4tA2QVGlrKCkI4=; b=sw8YdzsMyAhhO8F0vl7TE700knCNdktwHjSxY/waok18+Gb74JBT8LYqcMW7BVL5/B 0IFMlNMynW9eYxuEkjAN2S7yNjXf3uaEt4BS3ZMV8nlwK3SVrFdWckqGC8WN3c6ABJyi F7LWGOfTMKopIW/9iDtvLjKq/cBhnsXqctcAlwhlE9p2Hh/+QLPWyMhXvUtNKJH4BZZZ Ue+1UQ9xprp3pozKA2fHqiJCwC+1+VaJJQSXwiRCQjEcHQV6o0uJKnIeTxtCuqnUXjlO zPG9UeDEpOx7j/OFlflRI1cV5P7yAlFlVONnTkyls7eSCec8bt8slcF4W+tCrssDeO7q a4fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=f0uBg/5KPoRiDYj5l62flxI4v4bmc4tA2QVGlrKCkI4=; b=r31XgZLJ4vvk8l2W81s+/sWO/hjxNRgtTgL/RfGHIpNCA9qIyzcgSLjZMqfbsPry0u FMdbWh7E+/z+QWGhHHgEFrkICIZivW9ZAUkSRJk0BvXb8w2RhUmiDPe3hDboCsqwLBJ9 Woaw/8Vc8uPw2c83FrTZbBsQm17JPGOX+EVo0VGnrtaGFVSuas/D2h49X8IX0eR0L2xt gRDIfJbWVV27+HKWH+oobgj13ZlfRnu+cUzwY7uH3lvZS2/MyhLMWfah0BZNhNI/VLPc zUjxaqlQrf09yF0n5uvO+SaB55HYMVH9Q/fN7mmlI7DWquvIqcrgpYn+9/5IoG02P1rs 2l1g== X-Gm-Message-State: AIkVDXJhmLvVWDd1/5KfES9Ahyn+EqQVFHyU2axhCxOtIVdo4P6ozrOTiOqwvX7dmEonxuiN X-Received: by 10.223.176.175 with SMTP id i44mr1091633wra.3.1484037998688; Tue, 10 Jan 2017 00:46:38 -0800 (PST) Received: from xps13.localnet (111.202.154.77.rev.sfr.net. [77.154.202.111]) by smtp.gmail.com with ESMTPSA id m145sm2524250wma.3.2017.01.10.00.46.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jan 2017 00:46:38 -0800 (PST) From: Thomas Monjalon To: "Tan, Jianfeng" Cc: dev@dpdk.org, Jason Wang , yuanhan.liu@linux.intel.com, ferruh.yigit@intel.com, cunming.liang@intel.com Date: Tue, 10 Jan 2017 09:46:30 +0100 Message-ID: <1642339.XEY7yvBjzp@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <4fa4d06c-d359-df12-a073-7c2c2540b634@intel.com> References: <1480689075-66977-1-git-send-email-jianfeng.tan@intel.com> <46af618f-c01b-3571-78fc-12d10859a4a1@redhat.com> <4fa4d06c-d359-df12-a073-7c2c2540b634@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH v2 5/7] net/virtio_user: add vhost kernel support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 08:46:39 -0000 2017-01-10 14:11, Tan, Jianfeng: > On 1/9/2017 12:39 PM, Jason Wang wrote: > > On 2016=E5=B9=B412=E6=9C=8823=E6=97=A5 15:14, Jianfeng Tan wrote: > [...] > >> +/* TUNSETIFF ifr flags */ > >> +#define IFF_TAP 0x0002 > >> +#define IFF_NO_PI 0x1000 > >> +#define IFF_ONE_QUEUE 0x2000 > >> +#define IFF_VNET_HDR 0x4000 > >> +#define IFF_MULTI_QUEUE 0x0100 > >> +#define IFF_ATTACH_QUEUE 0x0200 > >> +#define IFF_DETACH_QUEUE 0x0400 > > > > Do we really want to duplicate those things which has been exposed = by=20 > > uapi here? >=20 > You mean those defined in ? Redefine those common=20 > macros, or include standard header file, with respective pros and con= s.=20 > DPDK prefers the redefinition way as far as I understand, doesn't it?= What is the benefit of copying defines instead of including?