From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 160353B5 for ; Mon, 30 Jan 2017 10:54:10 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id b65so24801561wmf.0 for ; Mon, 30 Jan 2017 01:54:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=zb2UTM3ZsDze+8ljYcl85LddJEZGck0fdJ75LBg/eSs=; b=qO64GxJ10dP1l8bZJ4rAE4FUXiLgIp1X0nLmuFzHAVLBqWBeH5PSZLWI6IUTBnEivM WHan5IsfTaASgXrLEGIBM8aYQnYruI253md9/L7DQAAZgzBU0MlAZGx5Zdv+ENmk9wS7 hZ2W2fjhtUHdSaZ4MiUOpgAzgTCeDmvj94zPOfqaJxIChQGR3bLfUnQHb7Apni6Z8IOA vqu1IL9OF9u/iraOdPXHUQVsnyunpab3RbMM7AVIWjtLWNOwLMgFIIgrFm/4+ycxxZ7o kL7zAoNo57jyD+rRMPst4a269DsQkD/pFPv36v9q7iCK+hZrtMREkSta9WjUA2fXuxpq VYBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=zb2UTM3ZsDze+8ljYcl85LddJEZGck0fdJ75LBg/eSs=; b=CxPoASzB6tSN4K6esWwitY3I8mrkRLuJOI3QznzF3UIzP79Td6WX5dtjsRAYrF5lfK hLLfgvr0/SOwsIi0oRhMqe5ZGijVKMnypOajNijauwaszIKzdX1a662EWTYhsPxpE7Jt uAh6K6X/9WjpEnUB9IWQYZsxjaIqmRYBxz9N64A3mdcMLiIceO8Qg4QBqreJJq5LclpZ CCNKN/Dy83iMkgcUy2ulpRhiDac44FhGhTO/ON6kUaE38lya8qiV/L5VIPIhdkHIUJOr DU/XLv3xcZw/RqVuUtMNVdhrr28rF00mouIuCC9lU4rz5zmWFHLOncxg7bL2HznRfr8M 6OBg== X-Gm-Message-State: AIkVDXIskfNVWW6KdGfuF2S3Gd8TXXCBNtDlqnNEKjNlwzB/6v9wFSWCnNd0KWXSciahBDTU X-Received: by 10.28.238.140 with SMTP id j12mr12422966wmi.35.1485770049749; Mon, 30 Jan 2017 01:54:09 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a35sm22003889wra.21.2017.01.30.01.54.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 01:54:09 -0800 (PST) From: Thomas Monjalon To: =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , olivier.matz@6wind.com Cc: dev@dpdk.org Date: Mon, 30 Jan 2017 10:54:08 +0100 Message-ID: <1643890.a9zoQB8M0i@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH 03/13] rte_ether: set PKT_RX_VLAN_STRIPPED in rte_vlan_strip() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 09:54:10 -0000 It is fixing the introduction of the new flag PKT_RX_VLAN_STRIPPED. Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") This patch is applying the flag to the software emulation case (currently only for virtio). So the comment of this flag should be changed: /** * A vlan has been stripped by the hardware and its tci is saved in * mbuf->vlan_tci. This can only happen if vlan stripping is enabled * in the RX configuration of the PMD. */ #define PKT_RX_VLAN_STRIPPED (1ULL << 6) = =20 > Signed-off-by: Micha=C5=82 Miros=C5=82aw [...] > --- a/lib/librte_net/rte_ether.h > +++ b/lib/librte_net/rte_ether.h > @@ -357,7 +357,7 @@ static inline int rte_vlan_strip(struct rte_mbuf = *m) > =09=09return -1; > =20 > =09struct vlan_hdr *vh =3D (struct vlan_hdr *)(eh + 1); > -=09m->ol_flags |=3D PKT_RX_VLAN_PKT; > +=09m->ol_flags |=3D PKT_RX_VLAN_PKT | PKT_RX_VLAN_STRIPPED; > =09m->vlan_tci =3D rte_be_to_cpu_16(vh->vlan_tci); > =20 > =09/* Copy ether header over rather than moving whole packet */ I think this flag should also be removed in the function rte_vlan_inser= t().