From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Tasnim Bashar <tbashar@mellanox.com>
Cc: dev@dpdk.org, david.marchand@redhat.com,
bruce.richardson@intel.com,
Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
Omar Cardona <ocardona@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
Ranjit Menon <ranjit.menon@intel.com>
Subject: Re: [dpdk-dev] [PATCH 4/4] devtools: add Windows cross-build test with MinGW
Date: Mon, 15 Jun 2020 09:51:48 +0200 [thread overview]
Message-ID: <1644346.HDDl6ptmbL@thomas> (raw)
In-Reply-To: <20200615040533.6c213a5f@sovereign>
15/06/2020 03:05, Dmitry Kozlyuk:
> > It looks to be a false positive, but we need to find a way to remove
> > the warning with a code change.
> >
> > This workaround in lib/librte_eal/common/eal_common_options.c
> > makes 200% sure the default_set is initialized:
> >
> > - if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t),
> > - &default_set))
> > - CPU_ZERO(&default_set);
> > -
> > + CPU_ZERO(&default_set);
> > + pthread_getaffinity_np(pthread_self(),
> > + sizeof default_set, &default_set);
> >
>
> Doesn't look like a false-positive to me. That's where it's been spotted
> and explained before:
>
> https://mails.dpdk.org/archives/dev/2020-May/168634.html
>
> And this series eliminates it along with other improvements:
>
> http://patchwork.dpdk.org/patch/70727/
I see.
So the fix must be explained (and probably a separate patch).
next prev parent reply other threads:[~2020-06-15 7:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 22:57 [dpdk-dev] [PATCH 0/4] add PPC and Windows to meson test Thomas Monjalon
2020-06-14 22:57 ` [dpdk-dev] [PATCH 1/4] devtools: shrink cross-compilation test definition Thomas Monjalon
2020-06-14 22:57 ` [dpdk-dev] [PATCH 2/4] devtools: allow non-standard toolchain in meson test Thomas Monjalon
2020-06-14 22:57 ` [dpdk-dev] [PATCH 3/4] devtools: add ppc64 in meson build test Thomas Monjalon
2020-06-15 21:43 ` David Christensen
2020-06-15 22:13 ` Thomas Monjalon
2020-06-16 20:35 ` David Christensen
2020-06-16 21:26 ` Thomas Monjalon
2020-06-17 21:02 ` David Christensen
2020-06-14 22:57 ` [dpdk-dev] [PATCH 4/4] devtools: add Windows cross-build test with MinGW Thomas Monjalon
2020-06-14 23:09 ` Thomas Monjalon
2020-06-15 1:05 ` Dmitry Kozlyuk
2020-06-15 7:51 ` Thomas Monjalon [this message]
2020-06-15 22:22 ` [dpdk-dev] [PATCH v2 0/4] add PPC and Windows cross-compilation to meson test Thomas Monjalon
2020-06-15 22:22 ` [dpdk-dev] [PATCH v2 1/4] devtools: shrink cross-compilation test definition Thomas Monjalon
2020-06-17 21:05 ` David Christensen
2020-06-15 22:22 ` [dpdk-dev] [PATCH v2 2/4] devtools: allow non-standard toolchain in meson test Thomas Monjalon
2020-06-17 21:06 ` David Christensen
2020-06-15 22:22 ` [dpdk-dev] [PATCH v2 3/4] devtools: add ppc64 in meson build test Thomas Monjalon
2020-06-17 21:07 ` David Christensen
2020-06-15 22:22 ` [dpdk-dev] [PATCH v2 4/4] devtools: add Windows cross-build test with MinGW Thomas Monjalon
2020-06-29 23:15 ` [dpdk-dev] [PATCH v2 0/4] add PPC and Windows cross-compilation to meson test Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644346.HDDl6ptmbL@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=ocardona@microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=tbashar@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).