From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD
Date: Wed, 05 Jun 2019 11:52:03 +0200 [thread overview]
Message-ID: <1644587.V9St9GoDxq@xps> (raw)
In-Reply-To: <CAJFAV8zRP-MwW93agFih4OoVeHDyVL8wDm2xizaTD0Xvm_nZCQ@mail.gmail.com>
05/06/2019 11:36, David Marchand:
> On Wed, Jun 5, 2019 at 11:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > 05/06/2019 11:06, David Marchand:
> > > Caught on FreeBSD 12:
> > >
> > > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete
> > type
> > > struct in_addr ip_src,ip_dst; /* source and dest address */
> > > ^~~~~~
> > >
> > > POSIX defines netinet/in.h as the right header for in_addr.
> > > Linux seems fine without it but let's include it explicitly.
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> >
> > Please could you add a "Fixes:" tag with Cc stable?
> >
>
> We did not build the examples before.
> Not sure what to tag as the "culprit".
> The one that adds FreeBSD support ?
I was thinking about the patch using in_addr so we can have a meaningful backport.
next prev parent reply other threads:[~2019-06-05 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 9:06 David Marchand
2019-06-05 9:25 ` Thomas Monjalon
2019-06-05 9:36 ` David Marchand
2019-06-05 9:52 ` Thomas Monjalon [this message]
2019-06-05 10:32 ` David Marchand
2019-06-05 11:30 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-06-05 12:50 ` Bruce Richardson
2019-06-05 13:14 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1644587.V9St9GoDxq@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).