From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 13D7DA0096 for ; Wed, 5 Jun 2019 11:52:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1F36C1BB22; Wed, 5 Jun 2019 11:52:09 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 55A641BB22 for ; Wed, 5 Jun 2019 11:52:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 33B8F5D2; Wed, 5 Jun 2019 05:52:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 05 Jun 2019 05:52:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=/ubeItIGpL2iGJ1E3LwHLl4bqPHVCyZwYo1pG9/5mAk=; b=fiMDF94HDK21 b+e/YyMJUvKkpPyh2y1R90vWuOJ+vETb/mxVA5y4ZlyveSXMue5weumn/nxEngRO y0AVC64TLeYqKfs6zDQVYoPj1fUcLyrVDrZaG36GWGpgYBlrTkXAo5m5RIr6TeXx /3t5EECq3z/iuwI/SO5/IAd4hkhNEMA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/ubeItIGpL2iGJ1E3LwHLl4bqPHVCyZwYo1pG9/5m Ak=; b=B1sXKTu2CQ1TE0WM0AbOfzpkGUhmxn81npr4tJdnXi3xqBoTOFVMxt7XX E1X03h66PY32WEWJTt46RJbRWhNwTE8dObqlOEahozNTIur+vzo62zo/Ut+o4vzq 3lfQDWTSBVJu4lkDKShz814ouQvrv2h4Q2p48EyRbLS5CTsOvlM1k4NidNDdQJnd 7fnzdNu3B5ysPzmOeEQRlyLFT2uRxgBgTyZ/MhB3DQ2UYKTnTHwbEdYbi3yOBRUr ltv8nd5v+pekRTzSAMzg1MEoOlUr6NofYPQtpK6jE6LbnXDJxC7MGlLyVZsR9tpB nmWP3dovwnF3tgNI5/EuoeGTXgMCQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudegvddgvdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 87F56380087; Wed, 5 Jun 2019 05:52:04 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev , Bruce Richardson , Anatoly Burakov Date: Wed, 05 Jun 2019 11:52:03 +0200 Message-ID: <1644587.V9St9GoDxq@xps> In-Reply-To: References: <1559725576-6427-1-git-send-email-david.marchand@redhat.com> <2833528.hd4umUYrtg@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] examples/multi_process: fix compilation error on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/06/2019 11:36, David Marchand: > On Wed, Jun 5, 2019 at 11:26 AM Thomas Monjalon wrote: > > > 05/06/2019 11:06, David Marchand: > > > Caught on FreeBSD 12: > > > > > > /usr/include/netinet/ip.h:71:17: error: field 'ip_src' has incomplete > > type > > > struct in_addr ip_src,ip_dst; /* source and dest address */ > > > ^~~~~~ > > > > > > POSIX defines netinet/in.h as the right header for in_addr. > > > Linux seems fine without it but let's include it explicitly. > > > > > > Signed-off-by: David Marchand > > > > Please could you add a "Fixes:" tag with Cc stable? > > > > We did not build the examples before. > Not sure what to tag as the "culprit". > The one that adds FreeBSD support ? I was thinking about the patch using in_addr so we can have a meaningful backport.