From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id C32772C1A for ; Tue, 5 Apr 2016 17:49:35 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id u206so10098023wme.1 for ; Tue, 05 Apr 2016 08:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Ct6/v01cuvSJkVlX4Q8a7/7c+G5erAXHq/E0HSvlaiA=; b=vZUdMPFkBunZi/YlIRo5WZkOWYxHuk533lARcE9AC+obeDkuHuJO3GQnscbxUIQWJa yXeYweIeIWWSPD3oO/LAERTk8mPO6awsU8vQJ/JxCP+DLFpvXs5OridDZJeTP5k6E5lO vEZndTVLqADRZHvynxgAp03A4DUeurt6xQfQEQTRd3aGjBkxsqfIM6D8VS8u0MRj81fT zDX/nNUW10sOseAh14h4TKMnMDh17ePDMmhhJ9s8ZF93NCa/0C+VF+v/DANSIZSZi+aH zTd+4/cXyvCwiwxgrs8FrERAJ5rNqGe8bkgbHbDH3G7QDHLjdox70FaZTrUX2hoEEftd Nz8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=Ct6/v01cuvSJkVlX4Q8a7/7c+G5erAXHq/E0HSvlaiA=; b=khecedS1RJYewvhrY6RaYh6mnV+YU1voAO49Ci/iuJj7Hx3AGZh57Nyom797OqKmq5 frAXuall/1EHNY2VRoBnMko11U9C5meR+2EabKusmtE1WIMZMHSPx/IdH4DEqRMdhBZ8 NDxrGnR3F8w3cMLc3kj2kr3Rwy3HXKCLIuG7WuqZql57pJG4EFQuAr4lA60n5QmI2okS nIdSoYeL3VIOVV0JVe20gCU33dJJKpvFnHHbk4i+51043SSn92rnwpwt6mUTrggpjy3w gs6/bILHh65HgRQD7xB3p2dAVLvSc7HRr+qv5Z/VQeR68N0ZJWpjK0wfJqIRCYtQPa1I NMhg== X-Gm-Message-State: AD7BkJJPi0/fYlBnGyD4DZY28rMivBGtfl6LU3qK5sVup+53ir9apQ4iVBxhcMlwmszV5MWE X-Received: by 10.28.132.212 with SMTP id g203mr18823733wmd.30.1459871375694; Tue, 05 Apr 2016 08:49:35 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id t3sm35332016wjz.11.2016.04.05.08.49.34 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Apr 2016 08:49:34 -0700 (PDT) From: Thomas Monjalon To: Bernard Iremonger Cc: dev@dpdk.org, wenzhuo.lu@intel.com Date: Tue, 05 Apr 2016 17:47:57 +0200 Message-ID: <1644934.6ArMgPXceK@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1459868146-26547-1-git-send-email-bernard.iremonger@intel.com> References: <1459853800-31760-1-git-send-email-bernard.iremonger@intel.com> <1459868146-26547-1-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix occasional timeouts when starting VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2016 15:49:35 -0000 2016-04-05 15:55, Bernard Iremonger: > - poll_ms = 10; > + poll_ms = RTE_IXGBE_REGISTER_POLL_WAIT_15_MS; [...] > #define RTE_IXGBE_REGISTER_POLL_WAIT_10_MS 10 > +#define RTE_IXGBE_REGISTER_POLL_WAIT_15_MS 15 > #define RTE_IXGBE_WAIT_100_US 100 I don't understand why these constants are needed. There is no semantic, just an arbitrary number.