From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 007345B2E;
Mon, 14 Jan 2019 12:19:10 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 717FD2A55D;
Mon, 14 Jan 2019 06:19:10 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Mon, 14 Jan 2019 06:19:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=5GG7kNO03ROxpq4zOZRotg6Q9yLSiTpCHQ0Rio0vGTo=; b=iPZr2FgW3a1a
R5fYWH5L7MAUrhKIZaU4AZgvgmpIlJMlxjoyv2fkozudNeJYnZWNfoOafWTctx1l
ZG2AdNStE2uoE4wzKi3UKP98OKcI2ja6FD722QUUGLWnT+W2BWsHJCUWRfSJY1PL
sR9waQh6oyUligyy/ij3ybm5CelSduY=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=5GG7kNO03ROxpq4zOZRotg6Q9yLSiTpCHQ0Rio0vG
To=; b=AfGtZ+5Lt0i7l1IaTOWhxQdWCeQH7BFWWNYjiRgHxR3AtWE3puQJWDWxO
j5xo+F6x7jR0KX4DGGMGyXDQwc3SuogFDV8HlMbV3ttle7peBmPowI92AL166gkG
s/72jkVojWOkl+18xcC/JQPvQrOvy2+HAPHFAbAAn5tjUhZkYU8cYs6wL33T6Yr9
NsTC1/rM1HQZQ/fYKG90Gbtx6fA5dLrdxQMynlJ1+QT6/6Pipp08G6AbIeKsMFdM
DX1tKGHl6UBAYyu3ia2xUncx/egC6L8+5E7WtjNF8WpUFNCPZoLDHZwKWCawbv9n
TWBdnfH0TVN7poqRqIxDq/QscYCqw==
X-ME-Sender: <xms:LXA8XB7Je50VPXkF_m82ytqLv0FFvh1NKnyG8e9UEEgMkRw2OA1VEg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrgedugddvjecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt
tdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufffkfgjfh
gggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceo
thhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfe
drudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
nhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:LXA8XNioHxtASXRID-yfwuNq0dZsoCz6Mp9lrjJFiE-JA5UpVwmkBw>
<xmx:LXA8XMsA5zXvvo_KMjkPjUGhqL-LUwZj5rdtkxjD9mqXTNhZ_QO5Dg>
<xmx:LXA8XJgZtrDeWFKbGbJcvRrHxExLBYpEgjUIXGIWqrK6s3X77yzlUw>
<xmx:LnA8XAbzAVo2ZnsmjPe_dkVxfen00bqGZipbbYAH8DGgA9SZKrxA8g>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 01C47E4043;
Mon, 14 Jan 2019 06:19:08 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org, Luca Boccassi <bluca@debian.org>, dev@dpdk.org
Date: Mon, 14 Jan 2019 12:19:08 +0100
Message-ID: <16471174.gmsOdrL8Yx@xps>
In-Reply-To: <1547125801.16085.2.camel@debian.org>
References: <20190110103726.23231-1-bruce.richardson@intel.com>
<1547125801.16085.2.camel@debian.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test-meson-build: fix check
for whether meson has run
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jan 2019 11:19:11 -0000
10/01/2019 14:10, Luca Boccassi:
> On Thu, 2019-01-10 at 10:37 +0000, Bruce Richardson wrote:
> > The current check to see whether we need to call meson or just ninja
> > simply checked if the build directory existed. However, if meson was
> > run
> > but failed, the build directory would still exist. We can fix this by
> > instead checking for the build.ninja file inside the directory. Once
> > that
> > is present, we can use ninja safely and let it worry about rerunning
> > meson if necessary.
> >
> > Fixes: a55277a788df ("devtools: add test script for meson builds")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks