DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline
@ 2018-07-20 13:09 Kevin Laatz
  2018-08-01 15:56 ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Laatz @ 2018-07-20 13:09 UTC (permalink / raw)
  To: dev; +Cc: cristian.dumitrescu, Kevin Laatz

Add a note to the 'link' command in the IP Pipeline documentation
specifying the PCI device name format required to run the application.

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
 doc/guides/sample_app_ug/ip_pipeline.rst | 1 +
 1 file changed, 1 insertion(+)

diff --git a/doc/guides/sample_app_ug/ip_pipeline.rst b/doc/guides/sample_app_ug/ip_pipeline.rst
index 660798d..dc6a3b9 100644
--- a/doc/guides/sample_app_ug/ip_pipeline.rst
+++ b/doc/guides/sample_app_ug/ip_pipeline.rst
@@ -222,6 +222,7 @@ Link
     txq <n_queues> <queue_size> promiscuous on | off
     [rss <qid_0> ... <qid_n>]
 
+   Note: The PCI device name must be specified in the Domain:Bus:Device.Function format.
 
 Mempool
 ~~~~~~~
-- 
2.9.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline
  2018-07-20 13:09 [dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline Kevin Laatz
@ 2018-08-01 15:56 ` Thomas Monjalon
  2018-08-01 17:47   ` Dumitrescu, Cristian
  0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2018-08-01 15:56 UTC (permalink / raw)
  To: cristian.dumitrescu; +Cc: dev, Kevin Laatz

Cristian, review please?

20/07/2018 15:09, Kevin Laatz:
> Add a note to the 'link' command in the IP Pipeline documentation
> specifying the PCI device name format required to run the application.
> 
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
>  doc/guides/sample_app_ug/ip_pipeline.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/sample_app_ug/ip_pipeline.rst b/doc/guides/sample_app_ug/ip_pipeline.rst
> index 660798d..dc6a3b9 100644
> --- a/doc/guides/sample_app_ug/ip_pipeline.rst
> +++ b/doc/guides/sample_app_ug/ip_pipeline.rst
> @@ -222,6 +222,7 @@ Link
>      txq <n_queues> <queue_size> promiscuous on | off
>      [rss <qid_0> ... <qid_n>]
>  
> +   Note: The PCI device name must be specified in the Domain:Bus:Device.Function format.
>  
>  Mempool
>  ~~~~~~~
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline
  2018-08-01 15:56 ` Thomas Monjalon
@ 2018-08-01 17:47   ` Dumitrescu, Cristian
  2018-08-05 18:28     ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Dumitrescu, Cristian @ 2018-08-01 17:47 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: dev, Laatz, Kevin



> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Wednesday, August 1, 2018 4:56 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Laatz, Kevin <kevin.laatz@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: include note for pci address naming in
> ip pipeline
> 
> Cristian, review please?
> 
> 20/07/2018 15:09, Kevin Laatz:
> > Add a note to the 'link' command in the IP Pipeline documentation
> > specifying the PCI device name format required to run the application.
> >
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> > ---
> >  doc/guides/sample_app_ug/ip_pipeline.rst | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/doc/guides/sample_app_ug/ip_pipeline.rst
> b/doc/guides/sample_app_ug/ip_pipeline.rst
> > index 660798d..dc6a3b9 100644
> > --- a/doc/guides/sample_app_ug/ip_pipeline.rst
> > +++ b/doc/guides/sample_app_ug/ip_pipeline.rst
> > @@ -222,6 +222,7 @@ Link
> >      txq <n_queues> <queue_size> promiscuous on | off
> >      [rss <qid_0> ... <qid_n>]
> >
> > +   Note: The PCI device name must be specified in the
> Domain:Bus:Device.Function format.
> >
> >  Mempool
> >  ~~~~~~~
> >
> 
> 
> 
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline
  2018-08-01 17:47   ` Dumitrescu, Cristian
@ 2018-08-05 18:28     ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-08-05 18:28 UTC (permalink / raw)
  To: Laatz, Kevin; +Cc: dev, Dumitrescu, Cristian

01/08/2018 19:47, Dumitrescu, Cristian:
> > 20/07/2018 15:09, Kevin Laatz:
> > > Add a note to the 'link' command in the IP Pipeline documentation
> > > specifying the PCI device name format required to run the application.
> > >
> > > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-08-05 18:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-20 13:09 [dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline Kevin Laatz
2018-08-01 15:56 ` Thomas Monjalon
2018-08-01 17:47   ` Dumitrescu, Cristian
2018-08-05 18:28     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).