From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD3E7A0579; Fri, 9 Apr 2021 13:59:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96BAD4014D; Fri, 9 Apr 2021 13:59:49 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id BEE2D4013F for ; Fri, 9 Apr 2021 13:59:47 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 25B415C00E7; Fri, 9 Apr 2021 07:59:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 09 Apr 2021 07:59:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= xf2dN9r8HGTiR/Fq+rNbgSm83GQPlDmk8MhIXzoYzpw=; b=ZSFUFMcCnT2E5cbW Pilx4H/aBI4Xn/Ec0aLGH/WfxBRBxbPIis2vfrEFDe9IcRBWRnykBvmv/i+2B96T Hg4czbM9CGzCEDLbLNvfVwSEMFUkDxGR/g6fjspwYHPTb9ogZeFfjAiMyJlnzGPY abNhsFnKOlcUHJbeAEDV2EyUGKHybohqCUbtDxn3eZXmli++9VCrJ7inmfwXH0JU 5mcQ3+dU58Wa++Cd6g9Skdg8tMkekKScSlxrHKMiYzyO7YmfuEXgBKU2k1hbTJ+D R2FxuHKHUpQUWLpHfLTwp2pe5Z6NqZ7IGZOIfheyFd9GT2zzWs3utAkXZQItd3MF LgUncA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=xf2dN9r8HGTiR/Fq+rNbgSm83GQPlDmk8MhIXzoYz pw=; b=va4xSHBeTme2D9+poaGo/ZFmKL8xyuGyKxytIN1qCpdNOSqjARjaA/Pay wPBDY/CZSr3ItjQFFByY0Meq24Ykr7W5VBKWt8W8UT9m2gDxK0Y5Gk8k/yYoLNOE R8kmmtFqvC+7x/he2dsak8/+paHACpFPAKH+ckxyWQJBwUVcjBDaZUPW/Gaw7vm1 jTF36xBxvrAtRHKJIqV60u1imjP1TmHtUNMCC02Gwq23X1eaBPWBPt0Pw8QpeE+f 4wpKIpaF3quqsrLhZu3uOpn64ZOXvJWraje9ZJGNQ/7+VpJ2OF3Iuh3zbP+4Nqkx bGQ0Q2KjgmjdS0MZY+afsReRWeEFA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekuddggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 41923108005C; Fri, 9 Apr 2021 07:59:45 -0400 (EDT) From: Thomas Monjalon To: David Marchand Cc: dev@dpdk.org, arybchenko@solarflare.com, l.wojciechow@partner.samsung.com, Ilya Maximets Date: Fri, 09 Apr 2021 13:59:42 +0200 Message-ID: <1648905.BUbMVhLv2g@thomas> In-Reply-To: <20210409110453.20078-3-david.marchand@redhat.com> References: <20200626114751.22523-1-david.marchand@redhat.com> <20210409110453.20078-1-david.marchand@redhat.com> <20210409110453.20078-3-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/3] log: track log level changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/04/2021 13:04, David Marchand: > Add a log message when registering log types and changing log levels. > > __rte_log_register previous handled both legacy and dynamic logtypes. > To simplify the code, __rte_log_register is reworked to only handle > dynamic logtypes and takes a log level. > > Example: > $ DPDK_TEST=logs_autotest ./build/app/test/dpdk-test --no-huge -m 512 \ > --log-level=lib.eal:debug > ... > RTE>>logs_autotest > == dynamic log types > EAL: logtype1 logtype level changed from disabled to info > EAL: logtype2 logtype level changed from disabled to info > EAL: logtype1 logtype level changed from info to error > EAL: logtype3 logtype level changed from error to emerg > EAL: logtype2 logtype level changed from info to emerg > EAL: logtype3 logtype level changed from emerg to debug > EAL: logtype1 logtype level changed from error to debug > EAL: logtype2 logtype level changed from emerg to debug This needs to be updated: logtype -> log > error message > critical message > critical message > error message > == static log types > TESTAPP1: error message > TESTAPP1: critical message > TESTAPP2: critical message > TESTAPP1: error message > Test OK > > Suggested-by: Ilya Maximets > Signed-off-by: David Marchand > Acked-by: Andrew Rybchenko > Acked-by: Lukasz Wojciechowski Acked-by: Thomas Monjalon