From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B8C5A0562; Wed, 1 Apr 2020 00:35:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5A3B1C1B7; Wed, 1 Apr 2020 00:35:50 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id F0C641C1AA for ; Wed, 1 Apr 2020 00:35:49 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 4407E580670; Tue, 31 Mar 2020 18:35:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 31 Mar 2020 18:35:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=jYBORR/QYq0RPBdSvNt23fE0IBDdO5vC2z0hZa+g/mw=; b=KAMoQWiNM19d VZKGgEi5ctZGLsRCpg8Vz6Qq2BWt3D5VG6f829sWSCm8B2cF6IqQFZu8MZhhVxd2 +j5Bo5xhPPBtoGReCzyaU6ACKp8Pi4bsoYUktV4JejcRltAN4yTVgF46GCZVYkkC LIW+L8efoDkSd/EF0P8Efp/oBIJTF/k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=jYBORR/QYq0RPBdSvNt23fE0IBDdO5vC2z0hZa+g/ mw=; b=MZeJ4xrLAjb9q8tTYEZiLFGZFtErOAK1ZFEGGz4CYZOcKnXhA+Zqi5HNZ Bq9f2QEI4cPioEBEjGgtago5kdXcoRxuUPCPzwNCOgYOdXudqfi9MSN2naRsxxfh P7AW0MakKIMVZ/0lfudAwMqAYe+DcrO+VGS8lPOiF2VWQMTD27C5zVQjfsKPPi7F xVfVIS7C+fCjTimNQrVfjbLrvxQ9mwlb5Ojg5OFZpr4fZ2Alkb9IPrRAhvmrH2ow XoISz57m6UYXp4nmFqov3dTe/lo9A/Je3h7MGbp4qg0RapAbJS5+fUqqdjMBq9m+ GYBzOMlwMZcEzESn6ztDZXaMxno6w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtddtgddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 22C723280069; Tue, 31 Mar 2020 18:35:46 -0400 (EDT) From: Thomas Monjalon To: Joyce Kong Cc: stephen@networkplumber.org, david.marchand@redhat.com, mb@smartsharesystems.com, jerinj@marvell.com, bruce.richardson@intel.com, ravi1.kumar@amd.com, rmody@marvell.com, shshaikh@marvell.com, xuanziyang2@huawei.com, cloud.wangxiaoyun@huawei.com, zhouguoyang@huawei.com, honnappa.nagarahalli@arm.com, phil.yang@arm.com, gavin.hu@arm.com, nd@arm.com, dev@dpdk.org Date: Wed, 01 Apr 2020 00:35:44 +0200 Message-ID: <1650352.esFFXGZ24q@xps> In-Reply-To: <20200309095410.28983-2-joyce.kong@arm.com> References: <20200309095410.28983-1-joyce.kong@arm.com> <20200309095410.28983-2-joyce.kong@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, 09/03/2020 10:54, Joyce Kong: > Bitwise operation APIs are defined and used in a lot of PMDs, > which caused a huge code duplication. Statistics of the series: 653 insertions(+), 326 deletions(-) I would not say it is a huge duplication. > To reduce duplication, > this patch consolidates them into a common API family. [...] > +PMD Bitops > +M: Joyce Kong > +F: lib/librte_eal/common/include/rte_pmd_bitops.h Why is it called PMD bitops and not simply bitops?