From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 342A2A00BE; Mon, 25 Apr 2022 07:39:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19C99427FC; Mon, 25 Apr 2022 07:39:29 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 7713B42802 for ; Mon, 25 Apr 2022 07:39:27 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23OLR4D4023382 for ; Sun, 24 Apr 2022 22:39:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=7pbaEzk96jwtIbr8G4HTKHA6aSzeW6RFhZbp6jqjoFg=; b=ZsqyCLYDT5coOZQBsr8F0VCDyW7u7nCn4tn0koAi9EIMxVO3DxOlY9oNPagQYz/9FlQM A7jq1Vw+U0ngED5Pv5ax8Z2TKVQEFNkta3Y3heYPeUZcIvpAfMM6WESe9vQkjgTYsWos rqsPHY2RlNREdYlC/4dEFr21EAghiWuDYUmpZJlXgBYXmUOAd1DXK611kBzf6mJXDTqa MKn+sH5IlwF9u0zu4q33pXmftMd7lWnKhTbxJVihNeqacYAc0yefOxMg8ARQssJdzQfy Pl5SwVSx5u1FVtTw2J6jaX1IJMwJg5IwZDkRloXY7qz2PCCmKp4TvcLhSbr7cV+AY7OL Gw== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3fmetqmhxs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Sun, 24 Apr 2022 22:39:26 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sun, 24 Apr 2022 22:39:25 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Sun, 24 Apr 2022 22:39:25 -0700 Received: from HY-LT1002.marvell.com (unknown [10.193.69.240]) by maili.marvell.com (Postfix) with ESMTP id BDD983F7073; Sun, 24 Apr 2022 22:39:22 -0700 (PDT) From: Anoob Joseph To: Akhil Goyal , Jerin Jacob CC: Anoob Joseph , Archana Muniganti , Tejasree Kondoj , Subject: [PATCH 3/5] crypto/cnxk: remove redundant return Date: Mon, 25 Apr 2022 11:08:23 +0530 Message-ID: <1650865105-66-4-git-send-email-anoobj@marvell.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1650865105-66-1-git-send-email-anoobj@marvell.com> References: <1650865105-66-1-git-send-email-anoobj@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: ThZ1nW2Rd82_VfffSo4mbcmY27IWjUta X-Proofpoint-GUID: ThZ1nW2Rd82_VfffSo4mbcmY27IWjUta X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-25_01,2022-04-22_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The function doesn't return error. Remove return. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_se.h | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index e988d57..ce7ca2e 100644 --- a/drivers/crypto/cnxk/cnxk_se.h +++ b/drivers/crypto/cnxk/cnxk_se.h @@ -2047,7 +2047,7 @@ prepare_iov_from_pkt(struct rte_mbuf *pkt, struct roc_se_iov_ptr *iovec, return 0; } -static __rte_always_inline uint32_t +static __rte_always_inline void prepare_iov_from_pkt_inplace(struct rte_mbuf *pkt, struct roc_se_fc_params *param, uint32_t *flags) { @@ -2070,7 +2070,7 @@ prepare_iov_from_pkt_inplace(struct rte_mbuf *pkt, param->bufs[0].vaddr = seg_data; param->bufs[0].size = seg_size; - return 0; + return; } iovec = param->src_iov; iovec->bufs[index].vaddr = seg_data; @@ -2094,7 +2094,7 @@ prepare_iov_from_pkt_inplace(struct rte_mbuf *pkt, } iovec->buf_cnt = index; - return 0; + return; } static __rte_always_inline int @@ -2254,12 +2254,7 @@ fill_fc_params(struct rte_crypto_op *cop, struct cnxk_se_sess *sess, */ fc_params.dst_iov = fc_params.src_iov = (void *)src; - if (unlikely(prepare_iov_from_pkt_inplace(m_src, &fc_params, - &flags))) { - plt_dp_err("Prepare inplace src iov failed"); - ret = -EINVAL; - goto err_exit; - } + prepare_iov_from_pkt_inplace(m_src, &fc_params, &flags); } else { /* Out of place processing */ -- 2.7.4