From: Thomas Monjalon <thomas@monjalon.net>
To: Bing Zhao <bingz@nvidia.com>
Cc: viacheslavo@nvidia.com, matan@nvidia.com, dev@dpdk.org,
rasland@nvidia.com, alialnu@nvidia.com, stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: fix the building with flexible array
Date: Mon, 31 Oct 2022 21:13:16 +0100 [thread overview]
Message-ID: <16508820.Ash8RoxBsO@thomas> (raw)
In-Reply-To: <20221031182456.432384-1-bingz@nvidia.com>
31/10/2022 19:24, Bing Zhao:
> With some higher GCC/CLANG version, it is not recommended to use a
> structure with a tailing flexible array inside another structure.
> Accessing this array may be considered as a risk to corrupt the
> following field even if it is by intention.
>
> The error below was observed:
>
> drivers/net/mlx5/linux/mlx5_ethdev_os.c: In function 'mlx5_get_flag_dropless_rq':
> drivers/net/mlx5/linux/mlx5_ethdev_os.c:1679:42: error: invalid use of structure with flexible array member [-Werror=pedantic]
> 1679 | struct ethtool_sset_info hdr;
> | ^~~
>
> Changing it to memory dynamic allocation method will help to get
> rid of this complain.
>
> Fixes: e848218741ea ("net/mlx5: check delay drop settings in kernel driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks.
For an unknown reason, our GitHub CI started to fail on Sunday
with Fedora 35. Looks like an update was done in Fedora 35.
Now it is fixed!
prev parent reply other threads:[~2022-10-31 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 18:24 Bing Zhao
2022-10-31 20:13 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16508820.Ash8RoxBsO@thomas \
--to=thomas@monjalon.net \
--cc=alialnu@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).