From: Thomas Monjalon <thomas@monjalon.net>
To: ray.kinsella@intel.com, nhorman@tuxdriver.com,
Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
harry.van.haaren@intel.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH v4] eal/cpuflags: add x86 based cpu flags
Date: Sat, 25 Apr 2020 18:04:14 +0200 [thread overview]
Message-ID: <1651663.4herOUoSWf@thomas> (raw)
In-Reply-To: <20200416110040.42819-1-kevin.laatz@intel.com>
16/04/2020 13:00, Kevin Laatz:
> This patch adds CPU flags which will enable the detection of ISA
> features available on more recent x86 based CPUs.
[...]
> --- a/devtools/libabigail.abignore
> +++ b/devtools/libabigail.abignore
> +; Ignore this enum update as it should not be allocated by the application
> +[suppress_type]
> + type_kind = enum
> + name = rte_cpu_flag_t
> + changed_enumerators = RTE_CPUFLAG_NUMFLAGS
The justification is not correct.
The application is allowed to use RTE_CPUFLAG_NUMFLAGS in array allocation.
But no API is returning a CPU flag, so the new flags will remain unknown
to the application.
However, there is a behaviour change:
The functions rte_cpu_get_flag_name() and rte_cpu_get_flag_enabled()
will now accept new values, which were previously considered as an error.
Is it an ABI breakage? I would say no.
PS: Who is REALLY maintaining the ABI?
We really miss someone who carefully check all these things,
and take care of the doc and tooling.
next prev parent reply other threads:[~2020-04-25 16:04 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 11:49 [dpdk-dev] [PATCH 00/17] Add CPU flags Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 01/17] eal/cpuflags: add avx512 doubleword and quadword Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 02/17] eal/cpuflags: add avx512 integer fused multiply-add Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 03/17] eal/cpuflags: add avx512 conflict detection Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 04/17] eal/cpuflags: add avx512 byte and word Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 05/17] eal/cpuflags: add avx512 vector length Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 06/17] eal/cpuflags: add avx512 vector bit manipulation Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 07/17] eal/cpuflags: add avx512 vector bit manipulation 2 Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 08/17] eal/cpuflags: add galois field new instructions Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 09/17] eal/cpuflags: add vector AES Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 10/17] eal/cpuflags: add vector carry-less multiply Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 11/17] eal/cpuflags: add avx512 vector neural network instructions Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 12/17] eal/cpuflags: add avx512 bit algorithms Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 13/17] eal/cpuflags: add avx512 vector popcount Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 14/17] eal/cpuflags: add cache line demote Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 15/17] eal/cpuflags: add direct store instructions Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 16/17] eal/cpuflags: add direct store instructions 64B Kevin Laatz
2020-03-24 11:49 ` [dpdk-dev] [PATCH 17/17] eal/cpuflags: add avx512 two register intersection Kevin Laatz
2020-03-25 8:36 ` [dpdk-dev] [PATCH 00/17] Add CPU flags David Marchand
2020-03-25 11:10 ` [dpdk-dev] [PATCH v2] eal/cpuflags: add x86 based cpu flags Kevin Laatz
2020-03-27 12:24 ` David Marchand
2020-03-27 13:18 ` Van Haaren, Harry
2020-03-27 15:04 ` David Marchand
2020-03-27 13:44 ` Neil Horman
2020-03-27 14:15 ` Thomas Monjalon
2020-03-27 14:32 ` Van Haaren, Harry
2020-03-27 14:36 ` Ray Kinsella
2020-03-27 15:19 ` Thomas Monjalon
2020-03-30 12:15 ` [dpdk-dev] [PATCH v3] " Kevin Laatz
2020-04-16 10:08 ` Van Haaren, Harry
2020-04-16 11:00 ` [dpdk-dev] [PATCH v4] " Kevin Laatz
2020-04-25 16:04 ` Thomas Monjalon [this message]
2020-04-27 9:22 ` Kinsella, Ray
2020-04-27 9:27 ` Ray Kinsella
2020-04-27 9:31 ` Laatz, Kevin
2020-04-27 9:35 ` Ray Kinsella
2020-04-27 10:08 ` Laatz, Kevin
2020-04-27 12:31 ` Thomas Monjalon
2020-04-27 13:58 ` Ray Kinsella
2020-04-29 11:22 ` Neil Horman
2020-04-30 7:59 ` Ray Kinsella
2020-04-28 12:40 ` [dpdk-dev] [PATCH v5] " Kevin Laatz
2020-04-28 16:39 ` Ray Kinsella
2020-04-28 18:11 ` Laatz, Kevin
2020-04-28 19:55 ` Thomas Monjalon
2020-04-28 19:58 ` Stephen Hemminger
2020-04-29 11:39 ` David Marchand
2020-04-30 10:02 ` Ray Kinsella
2020-05-07 13:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1651663.4herOUoSWf@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=kevin.laatz@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=ray.kinsella@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).