From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DADAAA052E; Mon, 9 Mar 2020 18:57:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D568C1C0AA; Mon, 9 Mar 2020 18:57:52 +0100 (CET) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by dpdk.org (Postfix) with ESMTP id 9BE311C06B; Mon, 9 Mar 2020 18:57:50 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id BE31943F; Mon, 9 Mar 2020 13:57:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Mon, 09 Mar 2020 13:57:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SXDYUG/76bT093Vx4Kvx6FtHzvm5U9dseXl+9kJ1H3o=; b=JoQWzWacDOcr /fzULXkTOU/Q6cumhY65MoAjxB/VoqLHPGpAsXgkNWbmZXhk1cvPPeKzV21/Lhgj UlHxBFpRA5EkUZRz8cA7Ku5MZEjl53DMLpBZNP1anSp0kiz5iCJUmrMkhmQv6RFQ l2AeNugI/iXM386riR21Tkpou/Kv5AQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=SXDYUG/76bT093Vx4Kvx6FtHzvm5U9dseXl+9kJ1H 3o=; b=HHi70Im0zgQHvmndDfnpITtTokffst2kSNnv9EEx7hxJXCqoq9Hmy6TsZ 7cZNH7cfP8QLDGI8ULRfFbyW7h64ptwN41gkt/XS+LOHsKJox6MDgQhw7xbSiizA ZlKZZXDe2oV6eUKyY5cIDA7WrgmKzTDOBzGgVqfqfPItwrbm1n/H8yp0hm8yAJL5 rP9XxfmEKI5z4hwB3361Id5fHoIlNmI8nsJtXTqnXfThU7/HNp2MSM7RaNbUepa4 yaHxdWM6CJfMq1j13Q4/93zZmGoUE8Qj2MRwyI4u7Zzs0l5PzE89s/iBW+wqJiOH vuCDW1saX/2RZIfqmIkxPaAzax+9w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedruddukedguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ffohhmrghinhepughpughkrdhorhhgpdhtrhgrvhhishdqtghirdgtohhmnecukfhppeej jedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C56A03061363; Mon, 9 Mar 2020 13:57:46 -0400 (EDT) From: Thomas Monjalon To: David Marchand , Ye Xiaolong Cc: Haiyue Wang , dev , Qi Zhang , Qiming Yang , Beilei Xing , Wei Zhao , Aaron Conole , ci@dpdk.org, Ferruh Yigit Date: Mon, 09 Mar 2020 18:57:45 +0100 Message-ID: <1652587.VLH7GnMWUR@xps> In-Reply-To: <20200309162057.GD112283@intel.com> References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200309162057.GD112283@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 09/03/2020 17:20, Ye Xiaolong: > Hi, David > > On 03/09, David Marchand wrote: > >On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang wrote: > >> > >> A DCF (Device Config Function) based approach is proposed where a device > >> bound to the device's VF0 can act as a sole controlling entity to exercise > >> advance functionality (such as switch, ACL) for rest of the VFs. > >> > >> The DCF works as a standalone PMD to support this function, which shares the > >> ice PMD flow control core function and the iavf virtchnl mailbox core module. > >> > >> This patchset is based on: > >> [1] https://patchwork.dpdk.org/cover/66417/ update ice base code > > > >The problem is that the CI(s) won't handle this. > >Example for the robot: https://travis-ci.com/ovsrobot/dpdk/builds/152461907 > > > >Maybe we could add something as an annotation to the cover letter or > >the first patch of a series so that the CI(s) can detect and try to be > >intelligent? > > Agree, It'd be helpful if the cover letter of the first patch contains some > base tree info including the base commit and dependency patchset info (if any), > so the CI can determine the correct base on top of which the developer's > patchset applies to avoid any apply issue and potential false positive. > > And I know there is one option '--base'' of `git format-patch` which is > dedicated for this kind of usage, it can help create the base tree info block > which can be easily consumed by the CI. Here is the simple intro of it. > > Imagine that on top of the public commit P (already in upstream), the developer > applied well-known (on-flight, in the mailing list but not merged yet) patches > X, Y and Z from somebody else or himself, and then built his three-patch series > A, B, C, the commit history would be like: > > ................................................ > ---P---X---Y---Z---A---B---C > ................................................ > > With `git format-patch --base=P -3 C`, > > where P could be the exact commit sha, or variants e.g. HEAD~6, we can also use > --base=auto for convenience, the base tree information block will be shown at > the end of the first message the command outputs (either the first patch, or > the cover letter), like this: > > ------------ > base-commit: P > prerequisite-patch-id: X > prerequisite-patch-id: Y > prerequisite-patch-id: Z > ------------ > > Here P is the commit sha, and X,Y,Z are the patch ids of the dependency patches. > > > With this info in place, I think CI should be able to setup the exact base for > the coming patchset, the missing part I can see is the mapping of > (in-flight patch <-> patch id), since we have all the in-flight patches in > patchwork, creating and maintaining such mapping in DB is doable, what do you > think? I think it would simpler to list dependencies as patchwork ids. Example: Depends-on: series-42, patch-12345