DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Ashwin Sekhar Thalakalath Kottilveetil" <asekhar@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	"Satha Koteswara Rao Kottidi" <skoteshwar@marvell.com>,
	Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
	Satheesh Paul <psatheesh@marvell.com>,
	"Anoob Joseph" <anoobj@marvell.com>,
	Akhil Goyal <gakhil@marvell.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3] devtools: add acronyms in dictionary for commit checks
Date: Mon, 20 Sep 2021 10:05:48 +0100
Message-ID: <16525987-11fe-7939-e4fb-dbb19bc29c8b@intel.com> (raw)
In-Reply-To: <1890938.tUBTFp5uOv@thomas>

On 9/17/2021 5:15 PM, Thomas Monjalon wrote:
> 17/09/2021 16:53, Ashwin Sekhar Thalakalath Kottilveetil:
>> From: Thomas Monjalon <thomas@monjalon.net>
>>> 17/09/2021 15:54, Ashwin Sekhar Thalakalath Kottilveetil:
>>>> From: Thomas Monjalon <thomas@monjalon.net>
>>>>> 17/09/2021 12:58, Ashwin Sekhar T K:
>>>>>> Update word list with Marvell specific acronyms.
> [...]
>>> Please add details in the commit log so we understand they are Marvell
>>> acronyms.
>> Commit log already mentions these are Marvell specific acronyms. I did not
>> add explanation for each of them as this would make the message too long.
> 
> Oh yes, I missed it, sorry.
> 
>>> One more question: why is useful to add? Some people forget uppercases?
>>
>> Upper case is desired but not really mandatory. This was a suggestion put
>> forth to me In one of the reviews.
>> https://patches.dpdk.org/project/dpdk/patch/20210830135231.2610152-1-asekhar@marvell.com/
>>
>> I can abandon this change if you feel it is not appropriate to put many
>> device specific acronyms in the top level word list.
> 
> No strong opinion, but I think the patch is OK.
> David, Ferruh, opinions?
> 

Yes this is suggested to be sure acronyms are uppercase in the patch title.

But if an issue can be described in generic concepts, I am for using them to
instead of using device specific acronyms, to make commit logs less cryptic.
Like 'NIC' should be used instead of 'NIX'.

Similarly we can try to use long version of CQ/SQ/RQ, although we may need to
use them because of limited title length time to time.

Rest seems device specific abbreviations we may not escape to use them, so they
are OK to me.


  reply	other threads:[~2021-09-20  9:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-17 10:03 [dpdk-dev] [PATCH v1] " Ashwin Sekhar T K
2021-09-17 10:06 ` [dpdk-dev] [PATCH v2] " Ashwin Sekhar T K
2021-09-17 10:58 ` [dpdk-dev] [PATCH v3] " Ashwin Sekhar T K
2021-09-17 11:03   ` Jerin Jacob
2021-11-25 11:30     ` Thomas Monjalon
2021-09-17 12:55   ` Thomas Monjalon
2021-09-17 13:54     ` [dpdk-dev] [EXT] " Ashwin Sekhar Thalakalath Kottilveetil
2021-09-17 14:05       ` Thomas Monjalon
2021-09-17 14:53         ` Ashwin Sekhar Thalakalath Kottilveetil
2021-09-17 16:15           ` Thomas Monjalon
2021-09-20  9:05             ` Ferruh Yigit [this message]
2021-09-20  9:19               ` Ashwin Sekhar Thalakalath Kottilveetil
2021-09-20 10:31                 ` Ferruh Yigit
2021-09-20  9:07   ` [dpdk-dev] " Ferruh Yigit
2021-09-20  9:10     ` Jerin Jacob
2021-09-20 10:32       ` Ferruh Yigit
2021-11-03 16:44         ` Ferruh Yigit
2021-09-20  9:21     ` [dpdk-dev] [EXT] " Ashwin Sekhar Thalakalath Kottilveetil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16525987-11fe-7939-e4fb-dbb19bc29c8b@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=anoobj@marvell.com \
    --cc=asekhar@marvell.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=psatheesh@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git