From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 859753239 for ; Wed, 25 May 2016 20:58:38 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id a136so140891203wme.0 for ; Wed, 25 May 2016 11:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=D6Ib3ucTS/2YdGVOWD1OF/DwKcrkqvN38LzONPBG8HY=; b=0Mb8/vhmkFslQZVKnUh9qmr+0e2aqprLrSdxUXcxXSNa6JdIH89yYtg0m3GL/Qgc8B HIioAPtusilfx7sAJphqQPLe2ndDeZol9leQr9QG7VKMYnWWEVYEeRJdu4K2xZP228Yt ULHge05eKzyaRC5psmPPyUDCgF/BWQ2x2ZGaPhm70ttg81lvFGOWsc1B1yFUwnDJrDrZ GuICNapztntmLTI/Jxd7/YrbMvuIJd4Ex5OnphW7QkbbDVilQCty0rd9s6zwrKNCpQZJ 3+jL3NmziynKZHeL/0wCIioXqO2qqb8WgwPgeVlYnrUgSuMzu373mjeFD6VK3MAdY0P0 G15A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=D6Ib3ucTS/2YdGVOWD1OF/DwKcrkqvN38LzONPBG8HY=; b=IT4EJnEUz2AtnbpOYMwQyD59Gzag06NuoU1t5iGU34cum3QsojUaCyVtyPZX7c6Vch drA+RPEzsvM5iCt6VDFU3Q2EA5wOjtqAfbUgOyxu9rVNlyD+OGSB6BcR0qp6YC5awxFL 3cbOD0+bx1NhhuL+TJuri+WsuGfIKt8d/FEaKhgToXFOZAJy0Y4AH+ImauW2S8USbUC/ /x+UGd2EB/n5hC6zDFBSc+bXQLHLl6PCeA+GHHHq3YcEePKNJ8hVNdE0GS6uXMYAy1vL wuqLKf/XUBpV6EzvuhALdi3Fza3BA64gClDl+JD6rQuJ2QGiJZDTk94IjNCTrMbNd7Jw oQtA== X-Gm-Message-State: ALyK8tJNmskHCNQVpqk/BFHabeOh87PxZM6YT7lpz1yfLKk+JoUYJWOTEYIHTBiJ27V1fliw X-Received: by 10.194.173.42 with SMTP id bh10mr6098774wjc.150.1464202718336; Wed, 25 May 2016 11:58:38 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id kz1sm10279648wjc.46.2016.05.25.11.58.19 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2016 11:58:35 -0700 (PDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, Bruce Richardson , Stephen Hemminger , Panu Matilainen Date: Wed, 25 May 2016 20:58:18 +0200 Message-ID: <1653357.fSAMoabLvC@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160525174721.GE14322@hmsreliant.think-freely.org> References: <1463431287-4551-1-git-send-email-nhorman@tuxdriver.com> <1484190.9fzbW2DJJe@xps13> <20160525174721.GE14322@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv4 5/5] pmdinfo.py: Add tool to query binaries for hw and other support information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 18:58:38 -0000 2016-05-25 13:47, Neil Horman: > On Wed, May 25, 2016 at 07:22:39PM +0200, Thomas Monjalon wrote: > > 2016-05-24 15:41, Neil Horman: > > > Note that, in the case of dynamically linked applications, pmdinfo.py will scan > > > for implicitly linked PMDs by searching the specified binaries .dynamic section > > > for DT_NEEDED entries that contain the substring librte_pmd. > > > > I don't know any DPDK app dynamically linked with a PMD (with DT_NEEDED). > I know lots of them, they're all in the dpdk. everything under app that uses a > virutal device links at link time to librte_pmd_bonding and librte_pmd_pipe (and > a few others), because they have additional apis that they need to resolve at > load time. Oh yes! you are right. > > However it is a good idea to handle this case. > > But relying on the name assumption "librte_pmd" is really weak. > > > > > + $(Q)$(call rte_symlink, $(DESTDIR)$(datadir)/tools/pmdinfo.py, \ > > > + $(DESTDIR)$(bindir)/pmdinfo) > > > > I think we must prefix the tool name with dpdk. > > What about dpdk-objinfo or dpdk-pmdinfo? > > > > > +from elftools.elf.elffile import ELFFile > > > +from elftools.elf.dynamic import DynamicSection, DynamicSegment > > > +from elftools.elf.enums import ENUM_D_TAG > > > +from elftools.elf.segments import InterpSegment > > > +from elftools.elf.sections import SymbolTableSection > > > > Should it be possible to implement pmdinfogen with this > > Python library? > > > Sure, but that really doesn't buy us anything, as its already implemented in C. > In fact, I would assert its harmful, because it implies that the build > environment needs to have python installed, as well as the pyelftools library, > which we don't need if we build from C. Right