From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A543BA48C for ; Fri, 19 Jan 2018 19:10:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DBE4B20D2C; Fri, 19 Jan 2018 13:10:50 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 19 Jan 2018 13:10:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=wLmkrCwSJxgo6osORCejmTxKj7 m/v2wMbWUZe5UZWuY=; b=G39pNZFzciKdc22bbK/K8h+tVfGgpub61PbuGtdUF2 imGLmaOYGT4YwQZku4juYBFOrt8QyLZh7e6n16XjE8uDbX/gAf17HHitfa8MDFCG uNf3BM+1LncAIYItHSE/Sy0La35XPT+wZqdE7sjdOJT7V9zuzcMIOUpNx+Eufxth E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wLmkrC wSJxgo6osORCejmTxKj7m/v2wMbWUZe5UZWuY=; b=Vt+xOXM5evtF6U+ew/J7Z6 c5MWj8nQ7yc97eF8wcBJBzXgR1VM3Iq2r/BRe3rz1I2mulaPjngBs6VSDikfE3wG dr9mgTlgfJtjMEb5cQc1iE+Vbnnb9HkWVwVAKE5BM/uPEDpMuxRFn6Ji/X4J7VNp NMFSw2TSuM1YcUquSk+Ah2k/sOcAavnE+DOCFw4CTuWUzYyrssJOZVnH0k/KvP9T R18R2H2cOE0g0S3zYnErK5tqPr5UKSZMXkF9pb9tElyaI/GdZCy7FYcDL26Lb+iN Dk0vtWL3HwKYQFMivztJoIJXTRST3lpmrJmxKspnORmz9CMkEFm9UV1sXrUnG1Kw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 710047E5CA; Fri, 19 Jan 2018 13:10:50 -0500 (EST) From: Thomas Monjalon To: Neil Horman Cc: Matan Azrad , "Ananyev, Konstantin" , Gaetan Rivet , "Wu, Jingjing" , dev@dpdk.org, "Richardson, Bruce" Date: Fri, 19 Jan 2018 19:10:15 +0100 Message-ID: <1653510.Ws8EKuMe4m@xps> In-Reply-To: <20180119173717.GD9519@hmswarspite.think-freely.org> References: <2601191342CEEE43887BDE71AB9772588627DE30@irsmsx105.ger.corp.intel.com> <3919053.IPF3Pcupc4@xps> <20180119173717.GD9519@hmswarspite.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jan 2018 18:10:51 -0000 19/01/2018 18:37, Neil Horman: > On Fri, Jan 19, 2018 at 06:09:47PM +0100, Thomas Monjalon wrote: > > 19/01/2018 15:32, Neil Horman: > > > On Fri, Jan 19, 2018 at 03:07:28PM +0100, Thomas Monjalon wrote: > > > > 19/01/2018 14:57, Neil Horman: > > > > > > > I specifically pointed that out above. There is no reason an owernship record > > > > > > > couldn't be added to the rte_eth_dev structure. > > > > > > > > > > > > Sorry, don't understand why. > > > > > > > > > > > Because, thats the resource your trying to protect, and the object you want to > > > > > identify ownership of, no? > > > > > > > > No > > > > The rte_eth_dev structure is the port representation in the process. > > > > The rte_eth_dev_data structure is the port represenation across multi-process. > > > > The ownership must be in rte_eth_dev_data to cover multi-process protection. > > > > > > > Ok. You get the idea though right? That the port representation, > > > for some definition thereof, should embody the ownership state. > > > Neil > > > > Not sure to understand your question. > > > There is no real question here, only confirming that we are saying the same > thing. I misspoke when I indicated ownership information should be embodied in > rte_eth_dev rather than its shared data. But regardless, the concept is the > same Yes we agree. And I think it is what Matan did. The owner is in struct rte_eth_dev_data: @@ -1789,6 +1798,7 @@ struct rte_eth_dev_data { int numa_node; /**< NUMA node connection */ struct rte_vlan_filter_conf vlan_filter_conf; /**< VLAN filter configuration. */ + struct rte_eth_dev_owner owner; /**< The port owner. */ };