From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 96265374F for ; Sat, 5 Aug 2017 01:18:58 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4326920E71; Fri, 4 Aug 2017 19:18:58 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 04 Aug 2017 19:18:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=2e5jpalYsmiAWYn 4+OWHSeWavtwzIS/4gsVucFXfVj8=; b=PsBsS8PqQB1e2ptCdn4AlITTnsYy3vB ZQFBErUknDw2rHQoaCH9pGK9LjLQDhvl0W0xdvupBWEwJPbV1E+MqUDCsCt1N96m EFPQVoQMBvCi5tY3z+SRwdDu/2sg/Wy6IuqjWIqZ5tXzL3yUV11AjxTUIkxAMF// 3vCbwieRDqmA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=2e5jpalYsmiAWYn4+OWHSeWavtwzIS/4gsVucFXfVj8=; b=OAuOho6t oRtFMH0Tp2g5y3TWKAX18Tk54N23XrTlsxE245ddeSVk9oTt+vJ84+XzsQkDBZ6f Rnrk19kPX4fitJxeYVmFMDkhf1EIGCLmy5rj8SLs3mU/0bxkK1M82yNZ1TZiuFyR GtWdDYJmcc0YE+wtbwZeRBvoJWveQxM0Xcsw+gWHJ0wOfGabYuP7MR1xKxpeHIDs R5J5dQsprd7iZFgKMYtdGwu1S3hYEzc3K1ZSGf8F/O+zrg2n9udbEma/Su57TJ0+ uabk7WxnJzPRnkcv3VgMAc5w0biS698TjvY0kahx+81LlTvhBYKfgRsOWPju3ocG iGezGeYuVI2IkA== X-ME-Sender: X-Sasl-enc: DwkXDHxPGGr6EGUvoi2pZd75AXDnkvn2mZK0evgQ9sgl 1501888737 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E2026248DD; Fri, 4 Aug 2017 19:18:57 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: "Mcnamara, John" , "jerin.jacob@caviumnetworks.com" Date: Sat, 05 Aug 2017 01:18:57 +0200 Message-ID: <1653708.1k2yq08C3Z@xps> In-Reply-To: References: <20170804102035.4051-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eventdev: fix missing includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 23:18:58 -0000 > > The PCI helper file depends on some EAL definitions. > > Spotted with devtools/check-includes.sh: > > error: implicit declaration of function =E2=80=98rte_eal_process_type= =E2=80=99 > > error: =E2=80=98RTE_PROC_PRIMARY=E2=80=99 undeclared > > error: implicit declaration of function =E2=80=98rte_socket_id=E2=80=99 > >=20 > > There was also this error because the inline keyword was missing: > > error: =E2=80=98rte_event_pmd_pci_probe=E2=80=99 defined but not used > >=20 > > Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions > > optional") > >=20 > > Signed-off-by: Thomas Monjalon >=20 >=20 > > Spotted with devtools/check-includes.sh: >=20 > That is a good reminder for people to add this to their patch workflow or= to some automated tests. >=20 > Acked-by: John McNamara Applied