From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6B3E4240D; Wed, 18 Jan 2023 12:07:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8B4342D3D; Wed, 18 Jan 2023 12:07:30 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id BB2824003F for ; Wed, 18 Jan 2023 12:07:29 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id D900D32004CE; Wed, 18 Jan 2023 06:07:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 18 Jan 2023 06:07:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674040047; x= 1674126447; bh=CxrDMdbvfQoGaAro6IGtS1TQ9Bd5YhTKEKE8Ver/dt4=; b=g 0Chpfac878wOoc0ShPg8X35+1XL5R/o5tQN4qxYuiQgl8Fq1tpaBEINsyLA0Z2Y2 zlvEG/ARB/IXKe3ghHa+vvDdCU3Tll09DMnpcbgBmHlkaJd2Nu+GjeVxIryOE6R9 c+6stds8yTPDnOtVkd/zjeY2mLba5RS4H5jZ5bhk5MwzN+ABcUk1CmoAKLEF6YYX FuZ6VV7Pmqb74SbryL4PJzTWEv1Mhirvkx1nvygip+rcoX9cEmAbeLcrpy/W6MPK Ki9lPz9mPdAkOr0aZ5nPsx3FJWxCQZPkzhhWIQkiHLs093yGUGDuP5p6bHWH8PUZ ZmbWyvdMq2Q4PbbmLmEeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674040047; x= 1674126447; bh=CxrDMdbvfQoGaAro6IGtS1TQ9Bd5YhTKEKE8Ver/dt4=; b=S SYGzTt8/AeLHrq3FhcVWGCfyIPdP9XYY9mtdofXgClOYIENLtbytRO9D3K3bx+14 sZ3bWalApjK91z+1M8P31nb6vYUwJ8WwrAv++vV8V+eCDa5whUqhNFdCP0MYDe7o XGy4nhvAAuMn6TeqZ5pFH9fMahqFJFZr1W2u6ues/ODHwn20PeqaxcFsxRTMXeCU VrQgc6FntYMAAvjLiumwBpky1jxqLDt2eHsOBoq5ISjVIKo8ORzrT6PYTzfFKkHL BblbjbxGlNVnb8kmaY2tToKTPKKgzH6Jwoz7lSubMq+ROv3Z+WMrDOo0/ky1KZY9 tYGncjH2F1sRpfvV2cofA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddtkedgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Jan 2023 06:07:26 -0500 (EST) From: Thomas Monjalon To: Jiawei Wang Cc: viacheslavo@nvidia.com, orika@nvidia.com, Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, rasland@nvidia.com, Ivan Malov , jerinj@marvell.com Subject: Re: [RFC 1/5] ethdev: add port affinity match item Date: Wed, 18 Jan 2023 12:07:24 +0100 Message-ID: <16543991.hlxOUv9cDv@thomas> In-Reply-To: <20221221102934.13822-2-jiaweiw@nvidia.com> References: <20221221102934.13822-1-jiaweiw@nvidia.com> <20221221102934.13822-2-jiaweiw@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/12/2022 11:29, Jiawei Wang: > + /** > + * Matches on the physical port affinity of the received packet. > + * > + * See struct rte_flow_item_port_affinity. > + */ > + RTE_FLOW_ITEM_TYPE_PORT_AFFINITY, > }; I'm not sure about the word "affinity". I think you want to match on a physical port. It could be a global physical port id or an index in the group of physical ports connected to a single DPDK port. In first case, the name of the item could be RTE_FLOW_ITEM_TYPE_PHY_PORT, in the second case, the name could be RTE_FLOW_ITEM_TYPE_MHPSDP_PHY_PORT, "MHPSDP" meaning "Multiple Hardware Ports - Single DPDK Port". We could replace "PHY" with "HW" as well. Note that we cannot use the new item RTE_FLOW_ITEM_TYPE_REPRESENTED_PORT because we are in a case where multiple hardware ports are merged in a single software represented port. [...] > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice > + * > + * RTE_FLOW_ITEM_TYPE_PORT_AFFINITY > + * > + * For the multiple hardware ports connect to a single DPDK port (mhpsdp), > + * use this item to match the hardware port affinity of the packets. > + */ > +struct rte_flow_item_port_affinity { > + uint8_t affinity; /**< port affinity value. */ > +}; We need to define how the port numbering is done. Is it driver-dependent? Does it start at 0? etc...