From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 791E51BBE for ; Wed, 8 Mar 2017 12:40:22 +0100 (CET) Received: by mail-wr0-f173.google.com with SMTP id u108so21303007wrb.3 for ; Wed, 08 Mar 2017 03:40:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=THH3uNC+On7UleGCsOS+rxKSw1+C70N11E4JaYgsvlk=; b=GiaeO24Yfha63i+MEvxyUIiXOICXK2cb4V2ZicmXJSCEEVlBjsHkYs2G+tmV4jP56y 8QpLS6mU8O4/33oij/PPM8AHT6vDM7ab4bYBGDAW9/F8Cw1+aRr4t7Vmsf2GbEQGiFSU Qxr3p8tOMG/JuO/N3j/KQl+pETz6eLjoSLjrmB1VgxGUCXOok4TzhbAjIh2NbqoymsNo BgtdTxJKhgC7YrvN/fEyysk+A119Feta19+zmZT81imFYeQt+jMBPFa+0Tv9CT0HoXVZ h5WljKKmprThl8vUVr0FxFr0Q5vG2z1gC2vF7EFdEzc3lr8K9glz6XhDUGgtPBR/BeZL Z1og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=THH3uNC+On7UleGCsOS+rxKSw1+C70N11E4JaYgsvlk=; b=R4Ah1fwNWWXjyBWch6vm2Aq7fm9CE2nuEHyYci2V4Tcr8SklHFP62i1nThl3YqxTCS 9NnWA7Hx4sSKuKN/z3tEogAzK9y1y3wJ2+h5Z+lkaG+JqTV6OepwAQdxuQot/ali4h82 nP+rrdhBKE/WBccO3SEbHrCx6QLwmcGp6TQDikMV8EE27Em6JpyMqwjcO0WXmhmj/gVC YWOa//zWK2E0xlR03pYxLTe+qibBDg/l/JHTmojRrgxqryXiomg11tq23K/dOZ/LVw6F 7ZNdujtltwxGLIXnAC2tixR56Afd1i9PcS1evWOB1cL4YMXkuUjUj/1UElbSFY3pBg6Z sTtA== X-Gm-Message-State: AMke39m+HJ6NOhEEWOHboNe1OlnCSDtrvq7+MpigKj52skqJBEuMbcsZWagwLkmUWXGpr3E/ X-Received: by 10.223.166.5 with SMTP id k5mr4679118wrc.134.1488973222191; Wed, 08 Mar 2017 03:40:22 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w30sm3835203wrb.5.2017.03.08.03.40.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Mar 2017 03:40:21 -0800 (PST) From: Thomas Monjalon To: Ami Sabo , yuanhan.liu@linux.intel.com Cc: dev@dpdk.org Date: Wed, 08 Mar 2017 12:40:20 +0100 Message-ID: <1655428.Al161abRzh@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1488445242-8824-1-git-send-email-amis@radware.com> References: <1488102926-24158-2-git-send-email-amis@radware.com> <1488445242-8824-1-git-send-email-amis@radware.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 0/2] Fix virtio-user multi-process crash. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 11:40:22 -0000 2017-03-02 11:00, Ami Sabo: > The patchset fixes secondary process crash issue when it tries > to access virtio-user pmd (e.g. via rte_eth_rx_burst). > > The crash happens because in virtio_user probing, > eth_dev_attach_secondary is not being called, as it does from > rte_eth_dev_pci_probe. Therefore, the device is not properly > initialized. > > The patchset contains 2 patches: > 1. Export rte_eth_dev_attach_secondary, so non-pci drivers will be > allowed to call it. > 2. Fix the actual bug by calling the function during virtio_user probe. I do not understand why nobody complains for other virtual devices. We should have the same issue with pcap, tap, ring, af_packet, etc. Probably that other drivers are broken in secondary processes. Or should we make a fix to handle every secondary vdev in rte_eth_dev_allocate() ?