Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows

[Thomas Monjalon <thomas@monjalon.net>]

05/12/2020 02:10, Pallavi Kadam:
> --- a/drivers/net/meson.build
> +++ b/drivers/net/meson.build
> @@ -1,9 +1,6 @@
>  # SPDX-License-Identifier: BSD-3-Clause
>  # Copyright(c) 2017 Intel Corporation
>  
> -if is_windows
> -	subdir_done()
> -endif
>  
>  drivers = ['af_packet',
>  	'af_xdp',
> @@ -56,6 +53,12 @@ drivers = ['af_packet',
>  	'virtio',
>  	'vmxnet3',
>  ]
> +
> +if is_windows
> +	drivers = ['i40e',
> +	]
> +endif

Let's not add an alternative list please.
I prefer disabling compilation in other drivers.


> --- a/lib/librte_eal/common/meson.build
> +++ b/lib/librte_eal/common/meson.build
> @@ -33,6 +33,7 @@ if is_windows
>  		'malloc_heap.c',
>  		'rte_malloc.c',
>  		'eal_common_timer.c',
> +		'rte_random.c',
>  		'rte_service.c',
>  	)
>  	subdir_done()
> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 89166acd7..428201872 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -124,6 +124,7 @@ EXPORTS
>  	rte_memzone_reserve_bounded
>  	rte_memzone_walk
>  	rte_openlog_stream
> +	rte_rand
>  	rte_realloc
>  	rte_rtm_supported
>  	rte_service_attr_get
> diff --git a/lib/librte_eal/windows/include/rte_windows.h b/lib/librte_eal/windows/include/rte_windows.h
> index b82af34f6..822922c11 100644
> --- a/lib/librte_eal/windows/include/rte_windows.h
> +++ b/lib/librte_eal/windows/include/rte_windows.h
> @@ -18,6 +18,11 @@
>  #define WIN32_LEAN_AND_MEAN
>  #endif
>  
> +#ifdef __clang__
> +#undef _m_prefetchw
> +#define _m_prefetchw __m_prefetchw
> +#endif


These changes are not specific to i40e, please separate.