From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 5CE393772 for ; Thu, 16 Jul 2015 01:02:08 +0200 (CEST) Received: by wiga1 with SMTP id a1so962818wig.0 for ; Wed, 15 Jul 2015 16:02:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=vR9zfl4XiKFxGk5PFpCi67jcp/wJcEtzEgDuU1x4bUs=; b=gMGFqTDeix9q6shqoSxZzqs+spFXwnN5RbMXnGoZ36KcKnflCmbjMFXPa1P0x8emoN TRa6zUeINqR49SDXns6c3r79bS2Zcjvr+4Y0HERLYQLgDRHxSnJkLhzQbiodlG6NjqiA UIprGC0Jg9obe9wodDfpilYNfI4X4bFF4CANqLbo1tZld8FtRO9F/LECHfcQA2DuEVxZ X47j0yEmtKV4LIWscBf53DDzRdJixQb6syNay8pSdxP4XM5ohPHbqvntvg+S/hmJFeUs 0YlSe71sxf04OFK5M1gVaRBpPk9Xntcab/b+2eGELGOI9Q9VEsArCv/W84nxAUY/rQJI hLoQ== X-Gm-Message-State: ALoCoQlorPSIsfpru0YbyAvhPX3a987niKhn1WzbYtJtr2/mUD2ya0Ll+tCeGP7VM3rYTByIkMGg X-Received: by 10.194.184.140 with SMTP id eu12mr12725503wjc.78.1437001328173; Wed, 15 Jul 2015 16:02:08 -0700 (PDT) Received: from xps13.localnet (guy78-1-82-235-116-147.fbx.proxad.net. [82.235.116.147]) by smtp.gmail.com with ESMTPSA id gb16sm193066wic.5.2015.07.15.16.02.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jul 2015 16:02:06 -0700 (PDT) From: Thomas Monjalon To: Helin Zhang Date: Thu, 16 Jul 2015 01:00:55 +0200 Message-ID: <1656470.VpSR9lnEEE@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1436459501-14173-1-git-send-email-helin.zhang@intel.com> References: <1435912347-19499-1-git-send-email-helin.zhang@intel.com> <1436459501-14173-1-git-send-email-helin.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v10 00/19] unified packet type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2015 23:02:08 -0000 2015-07-10 00:31, Helin Zhang: > Currently only 6 bits which are stored in ol_flags are used to indicate the > packet types. This is not enough, as some NIC hardware can recognize quite > a lot of packet types, e.g i40e hardware can recognize more than 150 packet > types. Hiding those packet types hides hardware offload capabilities which > could be quite useful for improving performance and for end users. > So an unified packet types are needed to support all possible PMDs. A 16 > bits packet_type in mbuf structure can be changed to 32 bits and used for > this purpose. In addition, all packet types stored in ol_flag field should > be deleted at all, and 6 bits of ol_flags can be save as the benifit. > > Initially, 32 bits of packet_type can be divided into several sub fields to > indicate different packet type information of a packet. The initial design > is to divide those bits into fields for L2 types, L3 types, L4 types, tunnel > types, inner L2 types, inner L3 types and inner L4 types. All PMDs should > translate the offloaded packet types into these 7 fields of information, for > user applications. > > To avoid breaking ABI compatibility, currently all the code changes for > unified packet type are disabled at compile time by default. Users can enable > it manually by defining the macro of RTE_NEXT_ABI. The code changes will be > valid by default in a future release, and the old version will be deleted > accordingly, after the ABI change process is done. Applied with fixes for cxgbe and mlx4, thanks everyone The macro RTE_ETH_IS_TUNNEL_PKT may need to take RTE_PTYPE_INNER_* into account.