DPDK patches and discussions
 help / color / mirror / Atom feed
From: Gregory Etelson <gregory@weka.io>
To: dev@dpdk.org
Cc: Wei Dai <wei.dai@intel.com>,
	wenzhuo.lu@intel.com, konstantin.ananyev@intel.com,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix calling null function of VF
Date: Wed, 10 May 2017 12:34:56 +0300	[thread overview]
Message-ID: <1659459.pG3zMYDirW@polaris> (raw)
In-Reply-To: <1494399602-33955-1-git-send-email-wei.dai@intel.com>

Hello,

The patch you proposed fixed a crash I experienced in IXGBE VF.
However, there's still another crash possibility
if the code will proceed with speed == 0 condition to ixgbe_get_link_capabilities
VF mac.ops.get_link_capabilities is also set to NULL;

Regards,
Gregory


On Wednesday, 10 May 2017 10:00:02 IDT Wei Dai wrote:
> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not
> be called directly. It had better be replaced by calling
> ixgbe_get_media_type( ) to avoid crash.
> 
> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ec667d8..ed2baec 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete)
>  	hw->mac.get_link_status = true;
>  
>  	if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) &&
> -		hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) {
> +		ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {
>  		speed = hw->phy.autoneg_advertised;
>  		if (!speed)
>  			ixgbe_get_link_capabilities(hw, &speed, &autoneg);
> 

  reply	other threads:[~2017-05-10  9:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-10  7:00 Wei Dai
2017-05-10  9:34 ` Gregory Etelson [this message]
2017-05-10  9:49   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-05-10  9:50 ` Ferruh Yigit
2017-05-10 12:20   ` Roger B. Melton
2017-05-10 12:33     ` Laurent Hardy
2017-05-10 15:18       ` Thomas Monjalon
2017-05-10 19:08 ` Roger B Melton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1659459.pG3zMYDirW@polaris \
    --to=gregory@weka.io \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=stable@dpdk.org \
    --cc=wei.dai@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).