From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id A54376CAF for ; Thu, 12 May 2016 18:08:18 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id n129so265800707wmn.1 for ; Thu, 12 May 2016 09:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=RM2I0cWpSvTSzkagsNEzrsR+qL+CoWWfgT5m0Kwsfcs=; b=Z5iR1+8mUwdZwXFyWJ0tn015LBnUgFEuFbSd8fN5ME5f1XsC0ycF4aQCa++BVKy1NR uENhY1b2hedKLnUonKM8VylSxc+CqMzxGNVouxVqxcTkFXrcJkakApB5xZFpQHrePeZm vzzcB0ybkPOewqclWG4TrOMHIaLSEiqBUc+s6StCnk/yBQOhrOZMQq4G9XXNY8yeWxIa zTtGWH8Qjon8Bvp5Y+oVlYCOvD8rUbqQTEiuP7arSnDiURKCUymHKnvj/5V2F5WucQXC nH9wN230cYL7Qe1S0SD8sU8dKDG7BeslWbiea/tWxhPD4DW2Zbf2FLUAsEcWih++haoj VOfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=RM2I0cWpSvTSzkagsNEzrsR+qL+CoWWfgT5m0Kwsfcs=; b=fcHVpKslReyvRpwG3gC9ZLUXm3qHhMU/1nUznroJ2Fu4KgTq1PhtSlk747KJfmRZTZ GbxxKzbE1zNNefAyLsDYcLz1wEKTFTZi78xcblkreD5D9P6ts7BS8vp3EVlkTyE7QPuA jFQGvs4u4Ii7KBwYwqkPywaBV/dE65l/PCtOrS0rwxPgQIksZleTj2jtyNxfhd16CIzu gT/S32vENNQZ5ANfYpLmpC3TNX4AiIo/6i4R/GwupY5TXcSs4HnxQW8tY7M7haPVn7Um 07ua16dzAy2jIETHk6oIB1/YH3EX9kG+mpocczTiDa7qlGhVJlN/ffIdZHLfH7jadV5K ytYQ== X-Gm-Message-State: AOPr4FUN17VanuPWSQ+jfPP0PpCF8Ar+gTkDF2ElTc2NEz5W2mYkxsF7f0Iv2r9pcJzYh2+Z X-Received: by 10.28.47.208 with SMTP id v199mr7453136wmv.56.1463069298465; Thu, 12 May 2016 09:08:18 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id p129sm14535844wmd.13.2016.05.12.09.08.17 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 12 May 2016 09:08:17 -0700 (PDT) From: Thomas Monjalon To: Jan Viktorin Cc: dev@dpdk.org, David Marchand , Bruce Richardson Date: Thu, 12 May 2016 18:08:16 +0200 Message-ID: <1659775.2ddTAuyrkI@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20160512175307.0573297e@pcviktorin.fit.vutbr.cz> References: <1462904011-29838-1-git-send-email-viktorin@rehivetech.com> <2242767.BO2sf06KAx@xps13> <20160512175307.0573297e@pcviktorin.fit.vutbr.cz> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 06/11] app/test: use linked list to store PCI drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 16:08:18 -0000 2016-05-12 17:53, Jan Viktorin: > On Thu, 12 May 2016 17:31:28 +0200 > Thomas Monjalon wrote: > > > 2016-05-10 20:13, Jan Viktorin: > > > The test unregisters all real drivers before starting into an array. This > > > inflexiable as we can use a linked list for this purpose. > > > > I don't understand this. Maybe some words are missing. > > Better? > > The test unregisters all real drivers before starting (stored into an array). > This is inflexiable (due to its fixed size) and we can use a linked list for > this purpose. Better with a past tense? "The test was unregistering..." > > > +/* real drivers (not used for testing) */ > > > > What do mean by "not used for testing"? > > The test now avoids the DPDK builtin drivers. It only considers its > internal fake drivers my_driver and my_driver2. So the real drivers > are temporarily store into the real_pci_driver_list and returned back > after the test finishes. Maybe adding "Save" or "Backup" would make it clear. > It is the linked list mentioned in the commit log. It replaces the > original fixed-size array. > > (For drivers, it does not matter that much. But for devices, I think, > it is not a good practice to consider them in autotests. Every PC > where you execute the tests have different set of PCI devices.) Yes