From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4C173A09E4;
	Thu,  4 Feb 2021 13:59:52 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BBA702405F2;
	Thu,  4 Feb 2021 13:59:51 +0100 (CET)
Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com
 [64.147.123.17])
 by mails.dpdk.org (Postfix) with ESMTP id 6698D240588;
 Thu,  4 Feb 2021 13:59:50 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailnew.west.internal (Postfix) with ESMTP id 5F6E5D4A;
 Thu,  4 Feb 2021 07:59:48 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Thu, 04 Feb 2021 07:59:49 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm3; bh=
 5lmjdTHk63+oitT9SJpgIsfCEaN4r2YVlyXQtISRYVs=; b=XSFhtCemjPcdOT2G
 kEQkIHoazM0YPcoUbrtuvPrGQhEpK8eVBNJomFUAJWkiMF8Q3ZQLhyqh51QK82Tc
 yEkLExY42kddiFG9/z2t0mxF1duofid9nIen86zWumysshXjsgQ8kW48j+a6yOCH
 HC4FB/LyzGrwZF3boBbYTaWlGAimkWNx/C58WnG904f7oxj2TmmBVxgqZju/mfrF
 YJSauAr2b/NnAhZrAMKotVLzHKa7V7wP9podnwZKxrtXm/UTVCSEXZN+2gL7Kd4F
 SxA9vEHnseFfIQa3ifpi3AYXLt6CVOoPTR2mBg1WzW5S0ktf/Jy9LnZt6OHaJYBE
 58vDOA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=5lmjdTHk63+oitT9SJpgIsfCEaN4r2YVlyXQtISRY
 Vs=; b=Q8WhNh475U9AcIS5v+VSC6sx/u0QZGMluo8SGqNjzAsoEv4JdSoJslEO/
 KtZmmfDyV112cFVXV7n5pT2VHW4aDPkzslHzYZt/X9agJvYvDiv1H3uEanRfiUrB
 nD7mPGAplGxqycowAZgR9Gvx6jzdd2PR7/yX/G7ilfwkT/Ege66Rb8Iz0rtya/vA
 gg6LPa/DTaV8NdJLyqmQUbvpb3eHQ6TmrA01oEuqm8+MsVcSMVXWS7MFkG5aSiYl
 C4oQkK5qeioyZtxQTHT0UeLKXeV9sgj84rs6+kWUZMRacqJFuS8G29kGSS+UCiWF
 7tN4FLdmycp6R9uDz9Oy+VzSYG5Fw==
X-ME-Sender: <xms:w-8bYPZQ0NpZ-Iy_q5Fi0OW7bzkDcMYuTfsc3UTTj3VM7G9jW8WKNA>
 <xme:w-8bYOaYLZK6WGos2jy9jb5LlAGH8Ku74p2BIIBJSVXTKMftn-y2VCsENMRX-hZiM
 PyVamhsEgpXfDMOng>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeeggdefkecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
 frrghtthgvrhhnpeekiedvhfekffejueevgfeitdekleetffejuedtleffiedviefhveel
 feettddtkeenucffohhmrghinhepohgsjhdrmhihnecukfhppeejjedrudefgedrvddtfe
 drudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm
 pehthhhomhgrshesmhhonhhjrghlohhnrdhnvght
X-ME-Proxy: <xmx:w-8bYB8WMZTuypTZARA1-EZfvemGqBsRmWZdBhIgCiFZWckyQn-k4w>
 <xmx:w-8bYFqxPb5cwJ_w1l8fOnWxBxI9p8I-drgpWLlWOP_YhX3OcAfq8A>
 <xmx:w-8bYKoj1zR2MGc7p3TYyybRxQ1HMzMJ7oVG2TXbmjkEOIT5lAM8RA>
 <xmx:w-8bYHj0VZLXss_llT9tsBNgMp4osl9Pe0R1Xjg3bndjMFlm6Mn9vI59nAM>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 0BE6724005A;
 Thu,  4 Feb 2021 07:59:45 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "Rong, Leyi" <leyi.rong@intel.com>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "talshn@nvidia.com" <talshn@nvidia.com>,
 "Kadam, Pallavi" <pallavi.kadam@intel.com>, "Menon,
 Ranjit" <ranjit.menon@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>,
 "aconole@redhat.com" <aconole@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "ci@dpdk.org" <ci@dpdk.org>
Date: Thu, 04 Feb 2021 13:59:44 +0100
Message-ID: <1660039.Gq7iE7GDot@thomas>
In-Reply-To: <d9457302-47c6-988b-6765-5eb4d64fc94c@intel.com>
References: <20210202090639.83164-1-leyi.rong@intel.com>
 <5ec7623cbb604753bb70fa9f4b0a7c3a@intel.com>
 <d9457302-47c6-988b-6765-5eb4d64fc94c@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix avx code error on MinGW
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/02/2021 13:36, Ferruh Yigit:
> On 2/4/2021 10:41 AM, Zhang, Qi Z wrote:
> > From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >> On Tue,  2 Feb 2021 22:32:58 +0800, Leyi Rong wrote:
> >>> Adds extra cflags '-fno-asynchronous-unwind-tables'
> >>> to avoid the MinGW build error:
> >>> 	Error: invalid register for .seh_savexmm
> >>>
> >>> Fixes: 5c38c33f7880 ("net/i40e: disable AVX512 with MinGW")
> >>>
> >>> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> >>
> >> Tested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> >>
> >> Re: -fno-asynchronous-unwind-tables, when cross-compiling from Linux, I
> >> observe bit-to-bit identical i40e_rxtx_vec_avx512.c.obj. My guess it that this
> >> option somehow affects GCC inlining heuristics. Similar issue existed in
> >> librte_acl (at least a year ago win GCC 6, I believe), where GCC generated
> >> incorrect code unless certain functions had been inlined (caught by test app).
> >> No an AVX expert, just my 2c.
> > 
> > Applied to dpdk-next-net-intel.
> > 
> 
> Hi Thomas, David,
> 
> Do you prefer to get this directly to the main repo, since it is fixing the 
> windows build?

Given it will be pulled shortly, I think it's OK through next-net.