From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id B1A3B7CCA; Thu, 7 Mar 2019 21:23:58 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 7C1D53753; Thu, 7 Mar 2019 15:23:57 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 07 Mar 2019 15:23:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=RyGSrz310CoaD17wAExuX3sNr+MYLp7tqM9GaexFe+c=; b=ZsNvDOI9734V 2quWvOjruxwY1VQRutthiirckXZMsI6qKq6YcvgPNQyj2jV4YOXsYu8MSnZEYCxi 9Cvh0JUf8FIGut/pAeLJJWNxuuxa5irTS42rqaRZnvsAZy2EbzLKzkYIhrkSAF1m QHckKL17UsDRHRtQtI6gd/2Xgj7cZX0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=RyGSrz310CoaD17wAExuX3sNr+MYLp7tqM9GaexFe +c=; b=xji8WTkuEQhMcax05b4yBSIxn34NXLz3+SPzo/Gh0YMBN5MzSa6f+BoXf VTd5T/O2Fjnlvmta8lxeWaSpgui2uSq0W74G2QYeItfU9kTXwmTtV3LpXT8PBKWN W4th+gWNqCgMmQltcw4sAJE1Jgzi2rQYuDaqyCsgy+iU5fv/e+9FRmakh+qHqkJF nUO2vKFGrq5QfdTNTFvC2gMBTzfjPduVYeMNo0SlxVuJVQZopCfxqWwhxhThdL5H Zf+QTOi2koZ5ic8xJpNKV+xWuJ/b7ajSIEwxVaSAb+2Lid13w8a7DyyX3fq3Lpga NMDg5Itk9nUMfTrajGKs65UYyEKiA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrfeekgddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D84F210310; Thu, 7 Mar 2019 15:23:54 -0500 (EST) From: Thomas Monjalon To: David Marchand Cc: stable@dpdk.org, dev@dpdk.org, didier.pallard@6wind.com, hari.kumarx.vemula@intel.com, stable@dpdk.org Date: Thu, 07 Mar 2019 21:23:51 +0100 Message-ID: <1660386.vIg6TEdDp7@xps> In-Reply-To: <1550088419-10812-2-git-send-email-david.marchand@redhat.com> References: <1550088419-10812-1-git-send-email-david.marchand@redhat.com> <1550088419-10812-2-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] eal: fix corelist validation with disabled cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 20:23:59 -0000 13/02/2019 21:06, David Marchand: > -l and -c options are two ways to select the cores used by DPDK. > Their format differs, but the checks on the selected cores are the same. > Use an intermediate array to separate the specific parsing checks from > the common consistency checks. > The parsing functions now concentrate on validating the passed string > and do nothing more. > > We can report all invalid core indexes rather than only the first error. > In the error log message, reporting [0, cfg->lcore_count - 1] as a valid > range is then wrong when the core list is not continuous. > > Example on my 8 cpus laptop with core 2 and 6 disabled. > echo 0 > /sys/devices/system/cpu/cpu2/online > echo 0 > /sys/devices/system/cpu/cpu6/online > > Before: > ./master/app/testpmd -l 0-7 --no-huge -m 512 -- --total-num-mbufs 2048 > EAL: Detected 6 lcore(s) > EAL: Detected 1 NUMA nodes > EAL: invalid core list, please check core numbers are in [0, 5] range > ... > > After: > ./master/app/testpmd -l 0-7 --no-huge -m 512 -- --total-num-mbufs 2048 > EAL: Detected 6 lcore(s) > EAL: Detected 1 NUMA nodes > EAL: lcore 2 unavailable > EAL: lcore 6 unavailable > EAL: invalid core list, please check specified cores are part of 0-1,3-5,7 > ... > > Fixes: d888cb8b9613 ("eal: add core list input format") > Fixes: b38693b612b4 ("eal: fix core number validation") > Signed-off-by: David Marchand +Cc: stable@dpdk.org Applied, thanks