DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH 1/2] eal: remove dead code in corelist parsing
@ 2019-02-13 20:06 David Marchand
  2019-02-13 20:06 ` [dpdk-dev] [PATCH 2/2] eal: fix corelist validation with disabled cores David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2019-02-13 20:06 UTC (permalink / raw)
  To: dev; +Cc: didier.pallard, thomas, hari.kumarx.vemula, stable

We don't need to look for trailing spaces.
This is a copy/paste block from eal_parse_coremask().
Remove it and the associated comment.

Fixes: d888cb8b9613 ("eal: add core list input format")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_eal/common/eal_common_options.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c
index b766252..c89f7ab 100644
--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c
@@ -567,10 +567,10 @@ static int xdigit2val(unsigned char c)
 eal_parse_corelist(const char *corelist)
 {
 	struct rte_config *cfg = rte_eal_get_configuration();
-	int i, idx = 0;
 	unsigned count = 0;
 	char *end = NULL;
 	int min, max;
+	int idx;
 
 	if (eal_service_cores_parsed())
 		RTE_LOG(WARNING, EAL,
@@ -580,12 +580,9 @@ static int xdigit2val(unsigned char c)
 	if (corelist == NULL)
 		return -1;
 
-	/* Remove all blank characters ahead and after */
+	/* Remove all blank characters ahead */
 	while (isblank(*corelist))
 		corelist++;
-	i = strlen(corelist);
-	while ((i > 0) && isblank(corelist[i - 1]))
-		i--;
 
 	/* Reset config */
 	for (idx = 0; idx < RTE_MAX_LCORE; idx++) {
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-03-07 20:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 20:06 [dpdk-dev] [PATCH 1/2] eal: remove dead code in corelist parsing David Marchand
2019-02-13 20:06 ` [dpdk-dev] [PATCH 2/2] eal: fix corelist validation with disabled cores David Marchand
2019-03-07 20:23   ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).