[dpdk-dev] [PATCH] doc: update i40e PMD to support on windows

[dpdk-dev] [PATCH] doc: update i40e PMD to support on windows

[Pallavi Kadam]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 2147 bytes --]

Add documentation to support i40e PMD on Windows.
Update the release notes for the same.

Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
---
 doc/guides/nics/i40e.rst               | 16 ++++++++++++++--
 doc/guides/rel_notes/release_21_02.rst |  4 ++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 20c998398..7bdaea8c0 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -46,8 +46,8 @@ Features of the i40e PMD are:
 - Malicious Device Drive event catch and notify
 - Generic flow API
 
-Prerequisites
--------------
+Linux Prerequisites
+-------------------
 
 - Identifying your adapter using `Intel Support
   <http://www.intel.com/support>`_ and get the latest NVM/FW images.
@@ -75,6 +75,18 @@ Prerequisites
       * In all cases Intel recommends using Intel Ethernet Optics; other modules
         may function but are not validated by Intel. Contact Intel for supported media types.
 
+Windows Prerequisites
+---------------------
+
+- Follow the DPDK `Getting Started Guide for Windows <https://doc.dpdk.org/guides/windows_gsg/index.html>`_ to setup the basic DPDK environment.
+
+- Identify the Intel® Ethernet adapter and get the latest NVM/FW version.
+
+- To access any Intel® Ethernet hardware, load the UIO driver in place of existing built-in (inbox) driver.
+
+- To load UIO driver, follow the steps mentioned in `dpdk-kmods repository
+  <https://browse.dpdk.org/dpdk-kmods/commit/?id=e28aabd882798f21b94918d4517621ce9e355269>`_.
+
 Recommended Matching List
 -------------------------
 
diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
index ae36b6a3f..176c6a66f 100644
--- a/doc/guides/rel_notes/release_21_02.rst
+++ b/doc/guides/rel_notes/release_21_02.rst
@@ -82,6 +82,10 @@ New Features
 
   * Added support for 64B completion queue entries
 
+* **Updated Intel i40e driver.**
+
+  * Added support on Windows.
+
 * **Updated Intel ice driver.**
 
   * Added Double VLAN support for DCF switch QinQ filtering.
-- 
2.25.4

Re: [dpdk-dev] [PATCH] doc: update i40e PMD to support on windows

[Thomas Monjalon]

21/01/2021 20:09, Pallavi Kadam:
> Add documentation to support i40e PMD on Windows.
> Update the release notes for the same.
> 
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
>  doc/guides/nics/i40e.rst               | 16 ++++++++++++++--
>  doc/guides/rel_notes/release_21_02.rst |  4 ++++
>  2 files changed, 18 insertions(+), 2 deletions(-)

The update of doc/guides/nics/features/i40e.ini is missing.
Please see the line "Windows" in mlx5.ini for comparison.

[...]
> +- To access any Intel® Ethernet hardware, load the UIO driver in place of existing built-in (inbox) driver.
> +
> +- To load UIO driver, follow the steps mentioned in `dpdk-kmods repository
> +  <https://browse.dpdk.org/dpdk-kmods/commit/?id=e28aabd882798f21b94918d4517621ce9e355269>`_.

I think we should say NetUIO instead of UIO.

Re: [dpdk-dev] [PATCH] doc: update i40e PMD to support on windows

[Kadam, Pallavi]

On 1/22/2021 3:16 AM, Thomas Monjalon wrote:
> 21/01/2021 20:09, Pallavi Kadam:
>> Add documentation to support i40e PMD on Windows.
>> Update the release notes for the same.
>>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
>> ---
>>   doc/guides/nics/i40e.rst               | 16 ++++++++++++++--
>>   doc/guides/rel_notes/release_21_02.rst |  4 ++++
>>   2 files changed, 18 insertions(+), 2 deletions(-)
> The update of doc/guides/nics/features/i40e.ini is missing.
> Please see the line "Windows" in mlx5.ini for comparison.

Thank you. Sure, I'll update it in v2.

>
> [...]
>> +- To access any Intel® Ethernet hardware, load the UIO driver in place of existing built-in (inbox) driver.
>> +
>> +- To load UIO driver, follow the steps mentioned in `dpdk-kmods repository
>> +  <https://browse.dpdk.org/dpdk-kmods/commit/?id=e28aabd882798f21b94918d4517621ce9e355269>`_.
> I think we should say NetUIO instead of UIO.

Agree. Will replace this in v2.

>
>

[dpdk-dev] [PATCH v2] doc: update i40e PMD to support on windows

[Pallavi Kadam]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 2740 bytes --]

Add documentation to support i40e PMD on Windows.
Update the release notes and features list for the same.

v2 changes:
	- updated doc/guides/nics/features/i40e.ini file
	- Replaced the name UIO with NetUIO

Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
---
 doc/guides/nics/features/i40e.ini      |  1 +
 doc/guides/nics/i40e.rst               | 16 ++++++++++++++--
 doc/guides/rel_notes/release_21_02.rst |  4 ++++
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/i40e.ini b/doc/guides/nics/features/i40e.ini
index b0a5ef424..542432c41 100644
--- a/doc/guides/nics/features/i40e.ini
+++ b/doc/guides/nics/features/i40e.ini
@@ -47,6 +47,7 @@ Module EEPROM dump   = Y
 Multiprocess aware   = Y
 FreeBSD              = Y
 Linux                = Y
+Windows              = Y
 x86-32               = Y
 x86-64               = Y
 ARMv8                = Y
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 20c998398..b8be9fe46 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -46,8 +46,8 @@ Features of the i40e PMD are:
 - Malicious Device Drive event catch and notify
 - Generic flow API
 
-Prerequisites
--------------
+Linux Prerequisites
+-------------------
 
 - Identifying your adapter using `Intel Support
   <http://www.intel.com/support>`_ and get the latest NVM/FW images.
@@ -75,6 +75,18 @@ Prerequisites
       * In all cases Intel recommends using Intel Ethernet Optics; other modules
         may function but are not validated by Intel. Contact Intel for supported media types.
 
+Windows Prerequisites
+---------------------
+
+- Follow the DPDK `Getting Started Guide for Windows <https://doc.dpdk.org/guides/windows_gsg/index.html>`_ to setup the basic DPDK environment.
+
+- Identify the Intel® Ethernet adapter and get the latest NVM/FW version.
+
+- To access any Intel® Ethernet hardware, load the NetUIO driver in place of existing built-in (inbox) driver.
+
+- To load NetUIO driver, follow the steps mentioned in `dpdk-kmods repository
+  <https://browse.dpdk.org/dpdk-kmods/commit/?id=e28aabd882798f21b94918d4517621ce9e355269>`_.
+
 Recommended Matching List
 -------------------------
 
diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
index ae36b6a3f..176c6a66f 100644
--- a/doc/guides/rel_notes/release_21_02.rst
+++ b/doc/guides/rel_notes/release_21_02.rst
@@ -82,6 +82,10 @@ New Features
 
   * Added support for 64B completion queue entries
 
+* **Updated Intel i40e driver.**
+
+  * Added support on Windows.
+
 * **Updated Intel ice driver.**
 
   * Added Double VLAN support for DCF switch QinQ filtering.
-- 
2.25.4

Re: [dpdk-dev] [PATCH v2] doc: update i40e PMD to support on windows

[Ferruh Yigit]

On 1/26/2021 11:03 PM, Pallavi Kadam wrote:
> Add documentation to support i40e PMD on Windows.
> Update the release notes and features list for the same.
> 
> v2 changes:
> 	- updated doc/guides/nics/features/i40e.ini file
> 	- Replaced the name UIO with NetUIO
> 
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>

<...>

> @@ -75,6 +75,18 @@ Prerequisites
>         * In all cases Intel recommends using Intel Ethernet Optics; other modules
>           may function but are not validated by Intel. Contact Intel for supported media types.
>   
> +Windows Prerequisites
> +---------------------
> +
> +- Follow the DPDK `Getting Started Guide for Windows <https://doc.dpdk.org/guides/windows_gsg/index.html>`_ to setup the basic DPDK environment.
> +
> +- Identify the Intel® Ethernet adapter and get the latest NVM/FW version.
> +
> +- To access any Intel® Ethernet hardware, load the NetUIO driver in place of existing built-in (inbox) driver.
> +
> +- To load NetUIO driver, follow the steps mentioned in `dpdk-kmods repository
> +  <https://browse.dpdk.org/dpdk-kmods/commit/?id=e28aabd882798f21b94918d4517621ce9e355269>`_.

Is the intention to reference the 'README.rst'? If so better to provide link for 
the documentation, instead of a specific commit, like:
https://git.dpdk.org/dpdk-kmods/tree/windows/README.rst

And for long term, I guess we need a way to host 'dpdk-kmods' repo documentation.

Re: [dpdk-dev] [PATCH v2] doc: update i40e PMD to support on windows

[Kadam, Pallavi]

On 2/2/2021 4:21 AM, Ferruh Yigit wrote:
> On 1/26/2021 11:03 PM, Pallavi Kadam wrote:
>> Add documentation to support i40e PMD on Windows.
>> Update the release notes and features list for the same.
>>
>> v2 changes:
>>     - updated doc/guides/nics/features/i40e.ini file
>>     - Replaced the name UIO with NetUIO
>>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
>
> <...>
>
>> @@ -75,6 +75,18 @@ Prerequisites
>>         * In all cases Intel recommends using Intel Ethernet Optics; 
>> other modules
>>           may function but are not validated by Intel. Contact Intel 
>> for supported media types.
>>   +Windows Prerequisites
>> +---------------------
>> +
>> +- Follow the DPDK `Getting Started Guide for Windows 
>> <https://doc.dpdk.org/guides/windows_gsg/index.html>`_ to setup the 
>> basic DPDK environment.
>> +
>> +- Identify the Intel® Ethernet adapter and get the latest NVM/FW 
>> version.
>> +
>> +- To access any Intel® Ethernet hardware, load the NetUIO driver in 
>> place of existing built-in (inbox) driver.
>> +
>> +- To load NetUIO driver, follow the steps mentioned in `dpdk-kmods 
>> repository
>> + 
>> <https://browse.dpdk.org/dpdk-kmods/commit/?id=e28aabd882798f21b94918d4517621ce9e355269>`_.
>
> Is the intention to reference the 'README.rst'? If so better to 
> provide link for the documentation, instead of a specific commit, like:
> https://git.dpdk.org/dpdk-kmods/tree/windows/README.rst
Thanks, Ferruh. I'll replace the commit link with the README.rst link in v3.
> And for long term, I guess we need a way to host 'dpdk-kmods' repo 
> documentation.
Will discuss this in the community meeting.

[dpdk-dev] [PATCH v3] doc: update i40e PMD to support on windows

[Pallavi Kadam]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=y, Size: 2819 bytes --]

Add documentation to support i40e PMD on Windows.
Update the release notes and features list for the same.

v3 changes:
	- Replaced the commit link with netuio README.rst
	  documentation link

v2 changes:
	- updated doc/guides/nics/features/i40e.ini file
	- Replaced the name UIO with NetUIO

Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
---
 doc/guides/nics/features/i40e.ini      |  1 +
 doc/guides/nics/i40e.rst               | 16 ++++++++++++++--
 doc/guides/rel_notes/release_21_02.rst |  4 ++++
 3 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/doc/guides/nics/features/i40e.ini b/doc/guides/nics/features/i40e.ini
index b0a5ef424..542432c41 100644
--- a/doc/guides/nics/features/i40e.ini
+++ b/doc/guides/nics/features/i40e.ini
@@ -47,6 +47,7 @@ Module EEPROM dump   = Y
 Multiprocess aware   = Y
 FreeBSD              = Y
 Linux                = Y
+Windows              = Y
 x86-32               = Y
 x86-64               = Y
 ARMv8                = Y
diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst
index 20c998398..45a144230 100644
--- a/doc/guides/nics/i40e.rst
+++ b/doc/guides/nics/i40e.rst
@@ -46,8 +46,8 @@ Features of the i40e PMD are:
 - Malicious Device Drive event catch and notify
 - Generic flow API
 
-Prerequisites
--------------
+Linux Prerequisites
+-------------------
 
 - Identifying your adapter using `Intel Support
   <http://www.intel.com/support>`_ and get the latest NVM/FW images.
@@ -75,6 +75,18 @@ Prerequisites
       * In all cases Intel recommends using Intel Ethernet Optics; other modules
         may function but are not validated by Intel. Contact Intel for supported media types.
 
+Windows Prerequisites
+---------------------
+
+- Follow the DPDK `Getting Started Guide for Windows <https://doc.dpdk.org/guides/windows_gsg/index.html>`_ to setup the basic DPDK environment.
+
+- Identify the Intel® Ethernet adapter and get the latest NVM/FW version.
+
+- To access any Intel® Ethernet hardware, load the NetUIO driver in place of existing built-in (inbox) driver.
+
+- To load NetUIO driver, follow the steps mentioned in `dpdk-kmods repository
+  <https://git.dpdk.org/dpdk-kmods/tree/windows/netuio/README.rst>`_.
+
 Recommended Matching List
 -------------------------
 
diff --git a/doc/guides/rel_notes/release_21_02.rst b/doc/guides/rel_notes/release_21_02.rst
index cc181dfd1..313b8bbc7 100644
--- a/doc/guides/rel_notes/release_21_02.rst
+++ b/doc/guides/rel_notes/release_21_02.rst
@@ -92,6 +92,10 @@ New Features
 
   * Added support for 64B completion queue entries
 
+* **Updated Intel i40e driver.**
+
+  * Added support on Windows.
+
 * **Updated Intel ice driver.**
 
   Updated the Intel ice driver with new features and improvements, including:
-- 
2.25.4

Re: [dpdk-dev] [PATCH v3] doc: update i40e PMD to support on windows

[Ferruh Yigit]

On 2/2/2021 7:09 PM, Pallavi Kadam wrote:
> Add documentation to support i40e PMD on Windows.
> Update the release notes and features list for the same.
> 
> v3 changes:
> 	- Replaced the commit link with netuio README.rst
> 	  documentation link
> 
> v2 changes:
> 	- updated doc/guides/nics/features/i40e.ini file
> 	- Replaced the name UIO with NetUIO
> 
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH v3] doc: update i40e PMD to support on windows

[Ferruh Yigit]

On 2/3/2021 10:22 AM, Ferruh Yigit wrote:
> On 2/2/2021 7:09 PM, Pallavi Kadam wrote:
>> Add documentation to support i40e PMD on Windows.
>> Update the release notes and features list for the same.
>>
>> v3 changes:
>>     - Replaced the commit link with netuio README.rst
>>       documentation link
>>
>> v2 changes:
>>     - updated doc/guides/nics/features/i40e.ini file
>>     - Replaced the name UIO with NetUIO
>>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Applied to dpdk-next-net/main, thanks.